Revision 547480

Go back to digest for 4th June 2006

Other in Networking Tools

Will Stephenson committed changes in /branches/work/knm-make-it-cool/src:

Give a better structure to the network activation/passphrase dialog
code. Reduce coupling, separate the backend from the ui some more, and
stop passing pointers around wildly.

Now the NetworkManagerInfo signals that it needs a passphrase with
passphraseNeeded, which is connected by the applet to the tray. The
tray launches the AcquirePassphraseDialog, which signals back to the
NMInfo when it is accepted or dismissed. The connections are managed by
the tray and the applet. Instead of creating/passing new Networks, the
networks' hal paths are used as handles for signalling, and Networks are
updated directly on the store.

NewWirelessNetwork dialog still passes Network pointers as these are new objects. They will be handled properly in an upcoming commit.

Encryption objects are created on demand by the new widget structure and
should be deleted along with their Network. The new widgets no longer
update Network and Encryption on user input, but only on dialog slotOk,
for simpler code.

File Changes

Added 8 files
  • /branches/work/knm-make-it-cool/src/applet
  •   /advencsettingswidgets.cpp
  •   /advencsettingswidgets.h
  •   /advsettings_wep.ui
  •   /advsettings_wpaeap.ui
  •   /advsettings_wpap.ui
  •   /cryptowidget.cpp
  •   /cryptowidget.h
  •   /cryptowidgetbase.ui
Deleted 1 files
  • /branches/work/knm-make-it-cool/src/applet/cryptowidget.ui
Modified 15 files
  • /branches/work/knm-make-it-cool/src
  •   /applet/dialogfab.cpp
  •   /applet/dialogfab.h
  •   /applet/knmapplet.cpp
  •   /applet/
  •   /applet/networklistview.cpp
  •   /applet/tray.cpp
  •   /applet/tray.h
  •   /libknm/devicestore.cpp
  •   /libknm/devicestore.h
  •   /libknm/devicestore_dbus.cpp
  •   /libknm/network.cpp
  •   /libknm/nminfo.cpp
  •   /libknm/nminfo.h
  •   /libknm/nminfo_dbus.cpp
  •   /libknm/nminfo_dbus.h
24 files changed in total