Issue 36616th November 2014 by KDE Commit-Digest Team
|Commits||1949 by 118 developers|
|Bugs Opened||221 in the last 7 days|
|Bugs Closed||141 in the last 7 days|
|Albert Astals Cid||
|Aleix Pol Gonzalez||
Internationalization (i18n) Status
|nowrep gmail com||
|kwadraatnope hotmail com||
|emmanuelpescosta099 gmail com||
There are 55 selections this week
Fix crash on shutdown.
Apparently the old-school Qt signal/slot connection was more
safe here before. The new-style connect gets executed when the
plugin is about to shutdown and then we'd crash. Now we manually
disconnect to prevent that from happening.
completion: added tokens that were missing in the CodeCompletionContext class.
In the big switch of the CodeCompletionContext class constructor some tokens
were missing. My fault since I was the one who introduced these new tokens in
Refactor the custom defines and includes plugin.
The compiler provider is not a plugin anymore, but a library that
is used in multiple places. In KF5, when the KCM is also not a
plugin anymore, we can merge all three together into one single
For now, this move already simplifies the logic tremendously and
removes a lot of boilerplate code that was required to access
the CompilerProvider/SettingsManager from various places.
Note that the distinction between CompilerProvider and SettingsManager
is also pretty artificial. I plan to merge the two classes together
and futher clean up the code then. There is a one-to-one relation ship
after all between these two classes.
In addition to the above, I cleaned up the code wherever I noticed
any opportunity for that. There are probably more places for that.
Do not waste time on computing include paths when not required.
This removes a major source of UI freezes for me. Most of the time
we don't have any candidates for unknown declarations. In such cases
we can return early and safe the time otherwise spent in the
expensive includeFiles function.
KLettres is now officially a KF5 based application!
R backend ported to Qt5/KF5. R server needs to be ported yet.
Replace the 'Recent URLs' tab with a 'Recent Files' one, which shows the same files as the recently opened menu item does.
Motivation as per 331011 in bugzilla.
Adapt image preview loading to use the new settings.
PreviewTask is restructured and much cleaner now.
Enable showing albums on collections which are not available (removable media)
There is currently no option in the UI to switch this off,
though there is a simple method in album manager to toggle this setting
Allow to read KPluginMetaData from .desktop files
Move the logic to create a KPluginMetaData object from desktoptojson
This allows to load metadata from a .desktop file, making it possible to
load desktop files without going through KPluginInfo (and thus
KService). This is useful for conversion to json data, which will be
used to index packages in the KPackage framework for faster lookups,
similar to the index proof-of-concept for KPluginTrader.
Use deleteLater() to delete the selection toggle in KItemListWidget
This patch should make a crash with a backtrace as provided in the bug
report impossible. I'm not sure if this would really prevent the crash
- it looks like the actual cause of the problem could be in
QGraphicsView or anywhere else, but it's hard to tell because the bug
was reported just once and does not seem reproducible. But I'm pretty
sure that this change doesn't make anything worse.
Restore adapter powered state after wakeup from suspend
[freespacenotifier] Fix hiding the SNI when avail space goes up again
The else branch handling that was one if-level above, so the SNI was
never hidden when there was enough space again
fix target install dir
installing icon themes from GHNS works again :)
add possibility for l&f package to have layouts
if the l&f package has a default layout script, make it win over the one of the shell.
this should be used for distributions to customize.
since there can be one l&f package with multiple shells, a layout is specific for a particular shell package, so search the files as layouts/shellName-layout.js, like layouts/org.kde.plasma.shell-layout.js
Reviewed by: Rohan Garg
Check usableAdapter against nullptr in regenerateDeviceEntries
Fixes occasional crash when new adapter is added.
cleanup overlay icon usage
The locked overlay should be added also for directories, as there is no
distinct "unreadable directory" icon.
No overlay icon for "gzip files with .gz file ending", there is a
mimetype icon for gzip files.
Take into account the primary screen can be redundant
We will always try to put our desktop view in the biggest screen, when 2
Monolithic: Set Passive state when Bluetooth is offline
Check adapter for nullptr in interfacesAdded/interfacesRemoved slots
Show notification configure button only if application actually has configurable notifications
This prevents that clicking the button results in an empty dialog giving our users sad puppy eyes
This is needed by kcminit_style to properly export GTK_RC* evn vars
to the launch environment.so that GTK apps start up properly styled.
Make sure to update plasma-workspace too
Provide UI feedback when waiting for opened message to be retrieved
When user double-clicks a message, the Viewer will not appear until
the ItemFetchJob retrieves the message. This can however take some
time when the Session is blocked and during that time user does not
have any feedback on what is happening.
This patch makes use of the busy dialog provided by KMCommands, so
that users can at least see that something is going on.
IncidenceFetchJob: don't get stuck when no calendar collections exist
The job never emitted finished() when the CollectionFetchJob returned no
collections. This causes KMail to get stuck when user opens an invitation
without having any calendar resource set up.
feature: New advice detecting scheduled operations having date not aligned with the last inserted operation
Fixed dynamical updates of the Transform Mask
This patch implements numerous fixes and refactoings:
1) Implemented KisSafeTransform. It works like a usual QTransform but
it takes maths into account. That is the transform and its reverse
are *not* defined on the entire R^2 plane. Instead the valid input
area is limited by the horizon line and nothing can be transformed
above it. KisSafeTransform takes that into account and clips the
desired rect/polygon to fit the valid area.
2) KisTransformMask::need/changeRect now uses safe trasnforms.
3) KisAsyncMerger recalculates the area of the clone's source to fetch
correct data. To fix concurrency, this extra area is taken into account
4) Implemented detailed unittests for dynamicat transform masks.
5) Added ability to store reference images of the unittest in a
separate folder (outside repository).
It consists of 3 major parts:
1) checkQImageExternal() is expected to be used to fetch data from
external folders only.
2) KRITA_UNITTESTS_DATA_DIR environment variable is used to search for
additional data sources
3) KRITA_WRITE_UNITTESTS=1 together with KRITA_UNITTESTS_DATA_DIR set
to a path will write the output of the unittest as a reference to
an external folder.
6) The testing images are stored in:
MovieDbConsumer: Wait for init signal
The AysncJobConsumer now understands the concept of the being "ready"
and does not process any events when it is not ready. TheMovieDbApi
informs it of being ready when it gets the init signal.
This isn't perfect as libtmdbqt does not try to initialize itself again
when we connect to the network.
Remove redirect-gateway tag from exported/imported config file
This is not used even in nm-connection-editor. Also if we are checking for this tag
which will never be present in exported OpenVPN connection from nm-connection-editor
we always set default-route in IPv4 config as true, which is not usually what users
want. I was talking with Dan Williams yesterday and NM-openvpn relies on autodetection
of the server user is connecting to. Also he plan to add functionality to this plugin
to set never-default automatically from this plugin.
[server] Introduce a base class Resource
The Resource base class is supposed to be used by all interface
classes which get created for a wl_resource.
Most interface classes are adjusted, but there are some exceptions:
* BufferInterface: is different as the wl_resource is already created
* PointerInterface and KeyboardInterface: those two need changes, the
implementation differs from all other interface implementations.
update spinner code (copied from Adwaita) to have working spinner for gtk+-3.14
Fix shared memory access in BufferInterface
The BufferInterface used nested calls of wl_shm_buffer_begin_access
and allowed multiple different BufferInterfaces to be in a block
between wl_shm_buffer_begin_access and wl_shm_buffer_end_access.
But this is not allowed: nesting is only possible if it accesses
the same buffer!
This resulted in an abort when we accessed two BufferInterfaces
at the same time. The added test case aborts in the previous
The fix now changes the semantic of the method. The BufferInterface
doesn't hold the QImage any more, but creates a new one every time
::data is invoked. The QImage is created with a custom cleanup
function which calls to wl_shm_buffer_end_access. It ensures that
we don't call into wl_shm_buffer_begin_access as long as there is
a valid QImage for any other BufferInterface still around and
instead returns a null QImage.
Thus a user of a BufferInterface::data should destroy the returned
QImage as soon as it's no longer needed or create a deep copy if
it needs to be kept around.
Adding a test application supporting output to a QWidget
This test application "testRenderingServer" is able to start a
Wayland server and uses a QWidget to render the "scene". It manages
ShellSurfaces and renders them on the QWidget in a very static way.
Furthermore input events (key, pointer, wheel) are forwarded to the
top most Surface.
This test server is able to support kwin_wayland as a client, but
weston's test application in latest release fail due to missing
Fix to allow having two audio links in the same epub
Time Line Component: Fixing frame selection issue
Use QSslCertificate's fromDevice instead fromPath to import certificates.
QSslCertificate::fromPath seems to have problem importing certs in DER format.
Ensure input is a valid regexp before enabling regexp filter mode
Checking whether the input contains '*', '?' or '[' alone will
not do since there can be files with '[' in their name.
Fix position of the Calligra logo based on height of the main menu
Fix the missing interest category for 'Buy' activities.
This fix is based on Allan's patch which is attached to the bug report
that I incorrectly thought to be fixed. I did some refactoring
because the readability of the investment activities was horrible. We
really should not have that kind of code in the application.
Vectors get iMax and iMin scalars
Now you can use the index of the max and min of a vector.
To create a label with the X value coresponding to YMax use,
[INDEX (V1)[[AZ:iMax (X26)]]]
Import the Tp account into KAccounts if it does not exist yet
This allows easy migration just by typing the password
Added the "finally" keyword.
implement back/forward side mouse buttons to navigate in the history
Reviewed and tested by: Jan Grulich
helps us align with KStandardGuiItem and provides
the missing translations on buttons
Implement FirstRun progress
Show a special screen for the first time jungle is run. Show a progress
bar for guess it queue. This way the users will at least see all their
shows categorized the first time they run Jungle.
Added settings to mousepad plugin to allow changing the default behaviour
for multi-tap input.
Optimizing "Hand" tool
Speed up pruning of the threading tree
Previously, a lot of time was spent on looking up many items in an
internal hash table, and additional time was wasted by renumbering the
siblings all the time in case multiple removals took place at the same
While each EXPUNGE is still being processed on its own, the actual
removal of each of these items now happens much faster (roughly 30% on a
synthetic benchmark based upon the callgrind's instruction fetch
As discussed by the security team
MSN Messenger has died, RIP
WIP: porting to kf5
Finish the frameworks port
KAlgebra/analitza backend ported to Qt5/KF5
DIGEST: KAlgebra/analitza backend ported to Qt5/KF5
Qalculate bckend ported to Qt5/KF5
DIGEST: Qalculate backend ported to Qt5/KF5
Maxima backend ported to Qt5/KF5
DIGEST: Maxima backend ported to Qt5/KF5
Lua backend ported to Qt5/KF5
DIGEST: Lua backend ported to Qt5/KF5