Revision 549721

Go back to digest for 11th June 2006

Features in KDE-PIM

Reinhold Kainhofer committed changes in /branches/KDE/3.5/kdepim/libkholidays:

The holiday library now also supports
-) Multiple holidays on the same date (e.g. start of summer time and easter
on the same day, etc.)
-) conditional shifting of holidays (e.g. if a holiday occurs on a saturday
or sunday, it is actually celebrated on the following monday). Example:
small "May holiday" weekend on 1.5. shift to monday if saturday || sunday
The holiday data files still need to be adapted wherever such a system
applies (UK, Wales, Ireland are known from bug reports, but I don't
know which holidays are really affected).

It's incredible, how simple it is to hack these lex/yacc parsers (which had the fame that nobody in kde would understand them), once you take the ten minutes to print out a yacc tutorial and the 45 minutes to look at the code (and then the ~2 hours to fix the inadvertant bugs in the C code that come through the ancient pointer-increasing in C to walk through a list, when you are used to Qt-style list iterators ;-) )

CCBUG:64673
CCBUG:92474

File Changes

Modified 5 files
  • /branches/KDE/3.5/kdepim/libkholidays
  •   /kholidays.cpp
  •   /kholidays.h
  •   /Makefile.am
  •   /parseholiday.y
  •   /scanholiday.lex
5 files changed in total