Revision 559197

Go back to digest for 9th July 2006

Bug Fixes in Multimedia

Jeff Mitchell committed changes in /trunk/extragear/multimedia/amarok/src/collectiondb.cpp:

Could this be the elusive "all my stats got erased!" bug? (YES!)

If either isInitialized() returns false or isValid() returns false, all tables, including stats, are dropped. Thing is, take a
look at MySqlConnection::MySqlConnection. See how if it doesn't work the first time, m_initialized is never set to true? BOOM.
Bye bye stats! That's why all these people with MySql were seeing their stats die.

Also, isValid only says whether or not all the tables it looks at are empty...and if so, it drops the tables and recreates them,
leaving them...empty. Umm.

Just get rid of this error-prone code.

File Changes

Modified 1 files
  • /trunk/extragear/multimedia/amarok/src/collectiondb.cpp
1 files changed in total