Revision 626835

Go back to digest for 28th January 2007

Bug Fixes in KDE Base

David Faure committed changes in /trunk/KDE:

Fixed 6-years old bug 20532: Undoing a copy operation might delete a modified file causing loss of data.

A confirmation message box is shown when undoing a copy after modifying the file [this relies on copy preserving the mtime though, which might not be true for all protocols but we'll have to fix that].

The less severe case of move, modify, undo (no data loss, but the modified file is moved back) can't be fixed in all cases, since moving a whole directory can be done by a simple rename() call, so we have no information on all the files inside the directory. For single files it could be done though, but that's not implemented by this.

File Changes

Modified 10 files
  • /trunk/KDE
  •   /kdebase/libkonq/konq_operations.cc
  •   /kdebase/libkonq/konq_undo.cc
  •   /kdebase/libkonq/konq_undo.h
  •   /kdebase/libkonq/konq_undo_p.h
  •   /kdebase/libkonq/tests/konqundomanagertest.cpp
  •   /kdebase/libkonq/tests/konqundomanagertest.h
  •   /kdelibs/kio/kio/copyjob.cpp
  •   /kdelibs/kio/kio/copyjob.h
  •   /kdebase/workspace/kcontrol/kfontinst/kcmfontinst/KCmFontInst.cpp
  •   /kdebase/workspace/kcontrol/kfontinst/kcmfontinst/KCmFontInst.h
10 files changed in total