Revision 733164

Go back to digest for 11th November 2007

Optimization in KDE Base

Aaron J. Seigo committed changes in /trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp:

improve the speed of KIconLoader::loadIcon and iconPath dramatically.
for cached icons, this takes us from 22k icons/s to somewhere around 118k.

windows people: you still have the bane of QDir in this hot path, but i don't know what to replace it with that will work on windows. QDir is just too expensive to use in this hot path just to check for a relative or absolute path. if you know of a clever way to do this without resorting to QDir, please make the change in the appropriate ifdef areas. otherwise you'll only get about half the benefit here.

bug 151874: i still don't know if you're having issues with the caching of icons. please test with this rev and let me know if this helps at all.

File Changes

Modified 1 files
  • /trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp
1 files changed in total