Revision 740765

Go back to digest for 25th November 2007

Bug Fixes in Development Tools

Michael Pyne committed changes in /trunk/KDE/kdesdk/scripts/kdesvn-build:

apaku uncovered another bug in the pipe() based IPC implemention. Of course, I had already foreshadowed it. For future reference, if you see a comment somewhere that says "should be enough length", it is not enough length.

Making the read buffer bigger would probably have fixed it, but instead I made the buffer even smaller and made the I/O handle message fragments instead. A nifty exercise is to reduce the 256 in the sysread call to 1 and see if everything still works in pretend mode. :)

File Changes

Modified 1 files
  • /trunk/KDE/kdesdk/scripts/kdesvn-build
1 files changed in total