Revision 744435
Go back to digest for 9th December 2007Features in KDE Base
David Faure committed changes in /trunk/KDE/kdelibs/khtml:
We've always gotten some trouble from the fact that KHTMLFactory has a dual purpose;
being the KParts::Factory (when khtmlpart is dlopened, e.g. in konqueror), and being the repository for a bunch of global things needed by khtml.
I've separated those two things, creating a KHTMLGlobal for the global stuff and leaving the KHTMLFactory to being the kparts factory only. It solves some life-cycle issues and allows to remove the ugly bool clone from the constructor. I also improved the refcounting mechanism in KHTMLGlobal to make it debuggable.
This doesn't fix the KHTMLFactory assert though; this only showed that the problem lies in DocumentImpl refcounting, not in KHTMLFactory itself...
OK'ed by carewolf.
File Changes
Added 2 files
- /trunk/KDE/kdelibs/khtml
- /khtml_global.cpp
- /khtml_global.h
Deleted 1 files
- /trunk/KDE/kdelibs/khtml/khtml_factory_init.cpp
Modified 18 files
- /trunk/KDE/kdelibs/khtml
- /CMakeLists.txt
- /khtml_ext.cpp
- /khtml_factory.cpp
- /khtml_factory.h
- /khtml_part.cpp
- /khtml_settings.cc
- /khtml_settings.h
- /khtmlpart_p.h
- /khtmlview.cpp
- /khtmlview.h
- /test_regression.cpp
- /testkhtml.cpp
- /css/cssstyleselector.cpp
- /html/html_documentimpl.cpp
- /html/htmlparser.cpp
- /misc/loader.cpp
- /rendering/font.cpp
- /xml/dom_docimpl.cpp
21 files changed in total