Revision 830998

Go back to digest for 13th July 2008

Other in Multimedia

Dan Meltzer committed changes in /trunk/extragear/multimedia/amarok/src:

rework some of QueryMakers api.

instead of calling startXQuery (which never made much sense to me as a construct, as it doesn't actually begin a query) create a new method, setQueryType that takes an enum of various types.

In the future we may want to transform this into a bitfield and allow for constructs like setQueryType( Artist | Album ) but thats a future question.

This will allow for the removal of the enums in most private classes that do this same thing at some point in the future

File Changes

Modified 39 files
  • /trunk/extragear/multimedia/amarok/src
  •   /AmarokMimeData.cpp
  •   /collection/CollectionLocation.cpp
  •   /collection/CollectionManager.cpp
  •   /collection/MetaQueryMaker.cpp
  •   /collection/MetaQueryMaker.h
  •   /collection/QueryMaker.h
  •   /collectionbrowser/CollectionTreeItemModelBase.cpp
  •   /context/CoverBling.cpp
  •   /covermanager/CoverManager.cpp
  •   /dialogs/TagDialog.cpp
  •   /dynamic/Bias.cpp
  •   /dynamic/BiasedPlaylist.cpp
  •   /dynamic/BiasSolver.cpp
  •   /dynamic/RandomPlaylist.cpp
  •   /playlist/PlaylistModel.cpp
  •   /playlistbrowser/DynamicBiasWidgets.cpp
  •   /servicebrowser/DynamicServiceQueryMaker.h
  •   /servicebrowser/ServiceSqlQueryMaker.cpp
  •   /servicebrowser/ServiceSqlQueryMaker.h
  •   /collection/nepomukcollection/NepomukCollection.cpp
  •   /collection/nepomukcollection/NepomukQueryMaker.cpp
  •   /collection/nepomukcollection/NepomukQueryMaker.h
  •   /collection/sqlcollection/OrganizeCollectionDialog.cpp
  •   /collection/sqlcollection/SqlMeta.cpp
  •   /collection/sqlcollection/SqlQueryMaker.cpp
  •   /collection/sqlcollection/SqlQueryMaker.h
  •   /collection/support/MemoryQueryMaker.cpp
  •   /collection/support/MemoryQueryMaker.h
  •   /collection/support/XmlQueryReader.cpp
  •   /collection/support/XmlQueryWriter.cpp
  •   /collection/support/XmlQueryWriter.h
  •   /servicebrowser/ampache/AmpacheServiceQueryMaker.cpp
  •   /servicebrowser/ampache/AmpacheServiceQueryMaker.h
  •   /servicebrowser/mp3tunes/Mp3tunesServiceQueryMaker.cpp
  •   /servicebrowser/mp3tunes/Mp3tunesServiceQueryMaker.h
  •   /servicebrowser/scriptableservice/ScriptableServiceQueryMaker.cpp
  •   /servicebrowser/shoutcast/ShoutcastServiceQueryMaker.cpp
  •   /servicebrowser/shoutcast/ShoutcastServiceQueryMaker.h
  •   /context/engines/lastfm/LastFmEngine.cpp
39 files changed in total