Revision 835741

Go back to digest for 27th July 2008

Bug Fixes in Office

Fredy Yanardi committed changes in /trunk/koffice:

First part of refactoring the presenter view feature. Now we don't need to open a new view to enable the presenter view. The new code at least fixes (and will fix):
* Crash when enabling presenter view for the second time (seems there is a bug somewhere in one of the docker)
* Canvas not positioned correctly on first page in presenter view widget
* Crash when playing the click action. Now the click event is only played once even when we have more than one presentation canvas.
* Crash after the last page
* The code is better, reduced some event forwarding which can be confusing ;-)

It can also be extended to more than two synchronized presentation canvases (maybe useful later if we want to support more than 2 monitors)

There are some changes in KoPageApp:
* Now KoPAViewMode::paintEvent() and KoPAViewMode::viewConverter() takes KoPACanvas * as additional argument since we need to repaint more than 1 canvas and each canvas can have different viewConverter

The presenter view widget is still not shown, only two presentation canvases are shown if Presenter View is enabled, I'll reenable it soon

File Changes

Modified 16 files
  • /trunk/koffice
  •   /kpresenter/part/KPrAnimationDirector.cpp
  •   /kpresenter/part/KPrAnimationDirector.h
  •   /kpresenter/part/KPrView.cpp
  •   /kpresenter/part/KPrView.h
  •   /kpresenter/part/KPrViewModeNotes.cpp
  •   /kpresenter/part/KPrViewModeNotes.h
  •   /kpresenter/part/KPrViewModePresentation.cpp
  •   /kpresenter/part/KPrViewModePresentation.h
  •   /kpresenter/part/KPrViewModePresenterView.cpp
  •   /libs/kopageapp/KoPACanvas.cpp
  •   /libs/kopageapp/KoPAView.cpp
  •   /libs/kopageapp/KoPAView.h
  •   /libs/kopageapp/KoPAViewMode.cpp
  •   /libs/kopageapp/KoPAViewMode.h
  •   /libs/kopageapp/KoPAViewModeNormal.cpp
  •   /libs/kopageapp/KoPAViewModeNormal.h
16 files changed in total