Revision 924631

Go back to digest for 15th February 2009

Other in Office

Boudewijn Rempt committed changes in /trunk/koffice:

Make it once again possible to compile KOffice with KOXML_USE_QDOM defined; this is not defined by default because it breaks kpresenter, kchart and kplato and it is slower, but it should be definable so we can check for errors in our dom implementation.
(And I'm sure there is one, since if I define KOXML_USE_QDOM, krita loads its documents with Qt45 again, which is broken if it's undefined, but I can now start to debug the problem again).

Note well: KoXmlNode has never been meant as a class you can extend with convenience methods.
Its API should be completely identical with the correspoding Qt class!
Convenience methods should be defined outside this class!

Also note: I have marked all places where applications use the aforementioned convenience methods with XXX!!!

File Changes

Modified 38 files
  • /trunk/koffice
  •   /kspread/Validity.h
  •   /kchart/shape/ChartDocument.cpp
  •   /kchart/shape/ChartDocument.h
  •   /kchart/shape/ChartShape.h
  •   /kchart/shape/TableModel.cpp
  •   /kformula/flake/BasicElement.h
  •   /kpresenter/part/KPrCustomSlideShows.h
  •   /kpresenter/part/KPrPage.cpp
  •   /kpresenter/part/KPrPlaceholderStrategy.h
  •   /kspread/shape/TableShapeFactory.h
  •   /kword/part/KWOdfLoader.h
  •   /libs/flake/KoEventAction.h
  •   /libs/flake/KoEventActionRegistry.h
  •   /libs/flake/KoFrameShape.h
  •   /libs/flake/KoToolManager.cpp
  •   /libs/guiutils/KoToolBoxFactory.cpp
  •   /libs/kokross/KoScriptingOdf.cpp
  •   /libs/kokross/KoScriptingOdf.h
  •   /libs/kotext/KoInlineNote.h
  •   /libs/kotext/KoTextShapeData.h
  •   /libs/kotext/KoVariable.h
  •   /libs/kotext/KoVariableRegistry.h
  •   /libs/main/KoGridData.h
  •   /libs/main/KoGuidesData.h
  •   /libs/odf/KoOdfPaste.h
  •   /libs/odf/KoOdfReadStore.h
  •   /libs/pigment/KoColorSpaceRegistry.cpp
  •   /libs/store/KoXmlReader.h
  •   /libs/store/KoXmlReaderForward.h
  •   /kplato/libs/kernel/kptschedule.h
  •   /kplato/libs/ui/kptsplitterview.cpp
  •   /kpresenter/part/pageeffects/KPrPageEffect.h
  •   /kpresenter/part/pageeffects/KPrPageEffectRegistry.h
  •   /kpresenter/part/pagelayout/KPrPageLayout.h
  •   /kpresenter/part/pagelayout/KPrPlaceholder.h
  •   /kpresenter/part/shapeanimations/KPrShapeAnimationRegistry.h
  •   /libs/kotext/opendocument/KoTextLoader.h
  •   /libs/kotext/styles/KoParagraphStyle.h
38 files changed in total