Issue 159

fix a usability bug: display 'open project' action when in project tab, makes lokalize a bit more friendly for those who start it first time

Always shutdown monav-routingdaemon on shutdown on Maemo, even if we didn't start it in this instance.
This makes it more unlikely that USB mounting is being blocked, or at least provides the workaround of starting and terminating Marble once after a crash to get rid of the block.

Prevent crash when creating a contour plot.
I don't know what the *ok is used for, but as OL is passed I guess it's more a provision than anything else.

Now I can at least create an image and it does not crash.
But it's pretty slow...

- Make it visually clear that the new option belongs to tied zoom
- Improve the wording from "Tie Between Tabs" to "Tie Across All Tabs
(though as a non-native speaker I feel a bit unsure changing something defined by a native speaker => please undo the change if you don't agree)

3**x is different to x**3.

Improve rendering of items for projections which repeat in the x-direction: Items are now drawn at geo-coordinate positions and not at pixel positions.

This way, Marble renders them in all places on the screen which represent these coordinates.
However, the current check for whether items are visible does not seem to work in all cases and needs to be investigated later.

Forgot that some language have more than one localisation (en_us).
Splitting the string and getting the first value should do the trick.
Thank missive for testing.

Switch to new Facebook API for requesting application permissions.
This have prevented all new users since July 2010 to upload photos to specific album or download photos (own or from their friends).

Redirect the result of the realloc() operation, to avoid memory leaks when reallocation should fail.

This patch will be included in the next official libPGF release, until then we patch it locally in our source tree.

Conditionally changes KFilePlaceEditDialog's title to "Add"/"Edit" to reflect the operation that is actually being performed.

In the item view constructors, call setFocus() only after m_extensionsFactory is initialised.
This fixes a possible crash in Konqueror when changing the settings or manipulating tabs.

- Return the full icon path for favicons.
- Keep the list order of the search engines so that the user's default search engine is always the first item in the list.

Remove selection only when receiving input

Port away from kde3support (k3command/k3commandhistory -> qundocommand/kundostack)

Fix crash due to "delete cur_item ; cur_item = foo" without telling the caller of the method
who passed cur_item by pointer and kept using it afterwards. Interestingly this has been in the
code forever...

FIXED-IN: 4.6

Load parts using RTLD_GLOBAL so that the domtreeviewer can catch exceptions from khtmlpart.
Otherwise it just crashes.
Since 2005...

FIXED-IN: 4.6

Backport of two important fixes:
* Fixed KInotify which sometimes thought / was deleted which resulted in removal of all indexed files from the index.
* Do not delete all graphs which contain information about removed files. Instead remove the resources since the
graphs might also contain information about other resources.

backporting r1197040 "clipping error on VD change"

backporting r1183245 "secure clientGroup pointer accesses"

Implement the "past names map" bug-compat feature from HTML5;
needed by libero.it e-mail app (the old one)

Do not free unallocated data in case of corruption

Daniel, if you manage to find the XCF (GIMP format) file that
causes the crash and it loads fine in GIMP, please attach it.
It is possible that there is some weird format that KDE does
not handle yet.

FIXED-IN: 4.5.4

Fix more bugs in the locale kcm, most of the widgets actually work now, almost ready to turn saving back on.

Insert mountpoints only once in currentMountPoints, to fix misbehavior on Volker's weird chroot setup :-)

Revert: it's perfectly valid to mount the same thing twice, e.g. with mount --bind:
/d on /home/dfaure/bind_d type none (rw,bind)
/d on /home/dfaure/bind_d2 type none (rw,bind)

I'll have to fix the unittest instead.

Temp fix for some crashes when changing profiles in Konsole Part.

Fix two bugs that were compensating each other in the unittest here:
1) kbuildsycoca would not emit databaseChanged("...") for resources where desktop files had been deleted
2) a name clash ("screensaver.desktop" in both servicetypes and services) made kbuildsycoca4 always
emit databaseChanged("services")

And of course the unittest was for "deleting a desktop file in the services resource" so it was passing by pure chance (and not on Volker's machine which didn't have both desktop files).

Fixed 2) by using resource+path as the key in that dict rather than just path.
and fixed 1) by looking at g_ctimeDict at the end, to see which resources are still there
(which needed the fix for 2 in the first place)

The fix for 1) uncovers a new bug though: databaseChanged("apps") is always emitted, so we never go into the fast path of "no need to save to disk"; I'll look at this tomorrow.

More fixes to locale kcm, and now re-enable saving!

Better solution for checking if config changed, but would be even easier if KConfig/KConfigGroup provided an isDirty() call (and a way to open as read only would be nice too).

Languages fixed to load/save correctly, but I still can't get the KActionSelector widget to work properly, to save tearing my hair out anymore I'm going to tear it out instead and do it myself.

fix remaining time and profile changing signals, to match those in PowerDevil
(battery applet fixes coming up next)

Ensure that KStandardDirs always returns resolved paths (when $HOME or $KDEHOME is a symlink),
even when returning paths that don't exist yet. Otherwise, via caches (the kstandarddirs one
or in applications), we can end up with a different path once it does exist, and comparisons
will fail (e.g. the one in KConfigPrivate::parseConfigFiles which detects the local file).

(So this fixes "kconfigtest testRevertAllEntries" when $HOME is a symlink, but has its own
setup-independent unittest now)

Don't crash when someone (e.g. kmail) passes in some html w/o a KHTMLPart that contains a named iframe.

It'd be best if HTMLQuoteColorer in kmail 4.4 were changed to use the part just in case, though.

Allow changing to pages that have no module proxy

KSettings::Dialog adds items without module proxy, so we cannot change from or to those.
The check can be removed completely, because "resolveChanges" already makes sure it does only ask for changes on pages having a proxy.

Make the bug reporting link open when clicked.

Fix wrong email link being launched.

Patch from George Metaxas, Thanks!

This patch fixes bug 74938, which is related to the way in which the
systray icon of KMail behaves. Currently, clicking on the systray icon
has the effect of minimizing the KMail window, irrespective of its
position in the window stack, and maximizing it if it was previously
minimized. In the latter case, the current virtual desktop is changed to
the virtual desktop where the KMail window was minimized. As noted in
the corresponding bug entry, this behavior is different than the
corresponding behavior of other KDE applications (e.g. Akregator).

The patch modifies the behavior of the KMail systray clicking handling,
by making it identical to other applications (e.g. Akregator). When
the KMail window is the top level window in the virtual desktop, it
is minimized. If it is visible in the desktop, but not at the top,
it is brought to the top. If the window is minimized, then it is
maximized to the current virtual desktop.

Fixed a full refresh for Clone layers

Now the Async Merger knows about one more type of layer position:
N_EXTRA. Such layer will be counted in a need rect chain and will be
updated (original+projection), but it will not be merged into the
final projection of the image. This is done for preliminary updates of
the sources of Clone layers.

Btw, i would suggest everyone to perform 'make clean' in
./krita/image/ folder, because many parts of walkers are
inlined. There is no need to do a full clean, just in ./image/
directory.

Fixed a docx filter case where image would be drawn twice.
Image is nowadays always drawn in vml part and the old part was not valid anymore.

Fixed drawingML bug where extra pictures would be inserted after buBlip element.

Fix the bug and implement the KMyMoney header functionality in a much nicer way.
Instead of hiding the standard header and having the KMyMoney header in all the views remove the standard header from the layout and replace it with one instance of the KMyMoney custom header (the text is adapted after a page change).

Improve the layout of the budgets and forecast views for a better vertical space usage.
The only thing that was preventing the usage of KMyMoney on 1024x600 was the settings dialog which is fixed by this commit.
For the status and tool bar reported for this bug they can be shown if the KMyMoney header is hidden using the settings.

So a user with 1024x600 can hide one of the following 3 items to make KMyMoney fit into 600 pixels in height:
- the title widget
- the tool bar
- the status bar

Reports
*fix memory leak in KRSectionData: property set
*remove redundant properties(), use propertySet()

Fix Cost breakdown: Planned startup/shutdown cost is included in actual cost.

Fix OO.org error-message 'Format error discovered in the file in sub-document settings.xml at position 2,1425 (row,col).' on loading just any ODP produced by kpresenter.

The reason was that we added the xmlns:ooo twice and neither OO.org nor MSOffice like that.

* call adjustSize() direct in postLayoutHook() to be sure we first adjust the size and then position the shape (where it's size was used).
* cache the documentSize. An even better way would be to calc the document's size while layouting but that's for later.
* on centered vertical-alignment proper position in the middle. This fixes page #21 in the a.odp.

Task performance calculations:
* Add startup and shutdown cost to bcws/bcwp/acwp calculations,
part of Bug 257413 - Different material costs inclusion in BCWS of kplato.
* Don't add a day too much when calculating a map of effort/cost pr day.
* Handle non-specified end time when fetching actual effort/cost.

don't crash when unexpected data is found in the CompObj stream (and whatever would be read there was ignored anyway).

Big fix in checking for the first call of loadBody

factory() can be NULL according to View.cpp (grep for factory()).
This should fix a reported Rekonq crash while browsing a ods file.

DOC: Fixed a crash related to processing of the Header document.

Fix the bug plus as an extra feature to display the institution value with the negative color if it's value is negative.

Show entries in normal color (again) if their balance becomes positive while another account is added.
Backported to stable branch

KoReports
*properly pass parent to ReportScene and ReportSceneView superclass, this also fixes one memory leak

Fix reading of WavPack streams without a length information in the header

When the WavPack's total_samples header fiels contains -1, try to find the final block and get the number of samples from there as block_index + block_samples.

Do not check for host, since that would dissallow opening local torrent, metalink etc. files.

HACK to display again the column-header-actions.
Their state is still not restored correctly though.

If a download did not report a totalsize do not use the finished chunks to calculated its processed size, as none has been set to finished.

Fixed writing to ~/.nsmbrc file prior to mounting.
This is needed since the credentials cannot be passed otherwise.

Several fixes for queue handling.
Also remove the confirmation dialog, since the confirmation really needs to occur before the transaction is added to the transaction stack, and I don't have a sufficiently accurate way to predict download size without actually marking things for installation

Display the name of the window that called gstreamer installer helper
Fixed detection of decoder/encoder

Rework clirarplugin's line reading logic again.

The code looks more like a state machine, which is good and should make it
easier to understand.

This also made it possible to add some code to check the column names written
before the header lines and decide whether we're using unrar-free or unrar
based on that (which should fix Ark crashing when being used with unrar-free).

If we're using unrar-free, we never try to parse the third file name entry
line, as unrar-free never outputs it.

It should be hopefully safe to backport, but I'll wait at least a few days. As
I'm unsure whether it's OK to backport it, the FIXED-IN version will be 4.6.0.

FIXED-IN: 4.6.0

use more properties in Tile and UIWall, simplify code about computing and placing tiles.

This fixes at least one bug
(in scoring game, quickly move meld from player to player to player was misplacing the focusRect)

make sure a robot player never plays dangerous game

If a player wins because of dangerous game, make correct payments.
Both in scoring game and when playing

animation and progress bar do not go together: the tiles leave artifacts when they move near the hand where the clientdialog is shown.

So we interrupt the progress bar while animating.
Try to revert this with next Qt.

Add the ability to include Qt3 support members in the smoke modules for QtCore, QtGui, etc.

Jump to the start of the route when enabling guidance mode independent of whether position tracking is active.

Distinguish between driving instructions that provide turn type icons and those that do not when scoring alternative routes.

OSX:
- build libs as framework, then we could use macdeployqt
- add deploy script (asciidata plugin only atm)

add dirfile support to kst for osx

- Menu option to specify if tied zoom spans tabs.
- The tied zoom button *toggles* tied stat in current tab. Since individual plots can be tied and untied, it is not a latching button.
- Add a head to curves, so the most current data can be identified in XY plots that do not have monotinic X vectors.

Enable BLOB handling policy to be set per property, and not per device as previously defined.
This will enable the user to fine-tune which BLOBs to receive from drivers.

Adding external links to Webelements and the Jeferson Lab pse.

full implementation of new extended demosaicing settings in paramater container

implement new interpolation options in settings widget. Not yet complete

Unleash non-destructive editing:
The interface is now fully adapted to versioning (includes
a first toolbar action cleanup). Yes, Save/Save As is gone.
Icons perfectly fitting to our concepts are missing, so I'm using
what's available. (I filed a request for icons, but dont know when/if it will be done)

I plan to extend the setup a bit, possibly allowing to switch off
non-destructive completely for those that really want,
and to define the default close action.
(We had planned to default to "save current" when closing the window,
but now I think that per default, the user must be asked)

You'll also see that "Revert to original" kind of changed its nature.
There's a "Load Original", but that's like opening a file.
Then there's a "discard changes", which is effectively like clicking
Undo to the end. Something like "remove the current version, delete
the version file and all its intermediates up to the original" has a lot of
implications, if other files were forked in between.

Hotpixels: Read and provide FilterAction, properly register with DImgFilterManager.
Storing in XML, for simplicity, is done by using one compound string for each hotpixel.

The last bits:
Make filterAction() a pure virtual method of DImgThreadedFilter.
This means that every single filter in Digikam is now providing
a filter action! (99% thanks to the work of Martin)

Todo: Superimpose

implement FBDD noise reduction before demosaicing provide by libray 0.12

* Ported to latest Olena (non-released git version now included in the source tree)
* Ported to Tesseract3

drag&drop support for launchers (now the manual sorting works with launchers)

Sort the favorite engine list before adding/putting the default one on top of the list.

* Rewrote most of the FileSystemTree. It no longer uses templates.
* Added some tests
* Filled the code with debug statements. :)

I know the code is a mess. I'll clean it up later.

Add the K_CATALOG_LOADER macro and KGlobal::insertCatalog
Acked by k-c-d

Added olena support and a global token tree

- add a first notification implementation for wince

use the corona for all screen geometry, should now in theory work in multihead

* add a screenId(const QPoint &) to DesktopCorona since it will be used in a few places now
* use multihead-aware numScreens() instead of consulting Kephal directly in checkScreens

use DesktopCorona where sensible instead of directly using Kephal

use DesktopCorona where sensible instead of directly using Kephal

Make deleting emails work, add mark as spam & todo

Two things are interesting in this commit:
1) We use the deleted flag for deleting emails, let's see how clients
handle this. I *think* this solution is quite elegant, but we might want
to move items into the trashfolder (which?!) instead. SpecialCollection
might help here. Or maybe we want to _really_ delete items?

2) The context menu offers some additional options to mark emails, spam
or task. These options would clutter the UI too much, but are nice to
have available for power users (those are more likely to find them there)

Report supported file patterns on WinCE, where we do not have sycoca.

Use native file dialogs more aggressively on Maemo5 and WinCE.
Also, cleanup a lot of the WinCE special cases while I was at it.

Move alternative calendar systems into a sub-menu so it's quicker to get to the main use case of the users locale calendar.
New string OK'ed on i18n list.

support nvidias proprietary refresh rate through asking nvidia-settings

Supports KDE3 way of starting man-pages (#term) and info-pages (##term).

Disable Defer button when no deferral is possible

Extend the Attachment flap to provide 'Remove Attachment', 'Sign' and 'Encrypt' actions.

Furthermore show the sign/encrypt status as icon for each attachment list entry and show the size of the attachment in the listview as well.

Remove empty autosave files as well.

Add dialog to select the crypto format of a message

Ask the user how to attach an email to an event or todo

Use KEditListWidget instead of KEditListBox when available.

Make the 'Generate free/busy alarms for' option available in collection properties page again.

Use the CollectionGeneralPage from kmail in kmail-mobile as well.
This provides us with all the kolab-specific collection properties configuration.

dial a phone number on wince

set default dialer via cmake.
seems to be the only possibility to change the default dialer for wince

Add a BlockAlarmsAttribute class to mark collections whose alarms shall be blocked.
Furthermore added a general collection properties page for calendar applications.

Add a patch that provides kldap with the option to use Winldap (System LDAP) on Windows systems, this does not work yet for Windows NT but only for CE

Keep settings as a member instead of a singleton, in preparation for running in the agent server.

akonotes and contact resource are running in agent server now

Add first (incomplete) version of the settings dialog for message list.

You can switch the grouping mode already, everything else is not implemented yet ;)

Show notifications when mail sending failed.

Implement sorting for the following options:
- by date/time
- by date/time (most recent)
- by sender/receiver
- by subject
- by size

Descending sorting seems to be bugyy right now, and the comparison for smart sender/receiver doesn't work yet

Include statistics in fetch job, so that the maintenance page can show actual values ;)

New filtered table view.
Rework of all plugins to use it.

load cover art from musicbrainz

install a bunch of kspread headers to make it somewhat possible to write a document viewer based on kspread outside the koffice source tree

New feature: New "show" button

Added support for msoptFlowChartDelay OfficeArt shape

Convert a complex delete changes to a simpler format and generate xml for the simple format.
TODO: Loading of this generated XML

Call the Edit > Clear action when the Del. key is pressed
Patch by "Francisco Fernandes"

FEATURE: New function on operation: "Merge sub operations"

FEATURE: New advice for budgets

* implement ODF draw:auto-grow-width and draw:auto-grow-height.
* turn changing resizeMethod into a QUndoCommand to be able to undo/redo
* this makes those a.odp working if it got loaded+saved once by ooimpress what is the case cause ooimpress has a bug where it always sets auto-grow-height=true

Added support for round-rectangle in libmso

Show webcontent per default

new mimes 64x64, finished next 48x48

new mimes 48x48, 223 to go (rest time now bbl)

new mimes 48x48, 186 to go (im gonna have dinner with jorge salgueiro and CA)

new mimes 48x48, 150 to go (me done for today more tomorow)

slimglow 4

Big overhaul of progress reporting for transactions:
- Add a queue so that you can browse/install other packages while downloading
- Send out custom signals from the ApplicationBackend

This allows us to report progress in both the application delegate extender and the application details view, without progress being reported in all delegates or extenders.

ADDED: option: Panel > General > Flat Origin Bar

Add QApt::History, a class giving an interface to the APT history logfiles.

Removing nepomukshell from kdereview. Moved to extragear.

Nepomukshell can be found https://projects.kde.org/projects/extragear/utils/nepomukshell

Initial work on the HistoryView.
It basically works, but isn't sorted and doesn't have search/filter capabilities

Add a GUI For searching and filtering history.
The history view is now complete

More polynomial code simplification.
Made the code more flexible as well, so more simplifications are available again :).

Google Code-in task solved by Cezar Mocan, consisting of code refactoring in the ObservingList class.

He removed significant parts of duplicated code and also identified a bug in the trunk (the context menu
was not showing for object on the session list) and fixed it pretty fast, even though he was not required to do so.

Results: cleaner and efficient code, one bug solved.

- Make sure the dirty flag is only set when a new web shortcut is created or an existing one is modified or deleted.
This prevents the entire list of web shortcuts from being saved everytime.

Replaced the simple query-based token detection with the one written by Mikhail Kotelnikov which uses a token tree of all named entities.

This is faster and also handles tokens which contain strings.
But on the other hand it does not handle substring matching yet and uses an in-memory tree of all named entities.

Save some space (no spacing, no seek slider icon)

Hide volume slider if there is not enough room

- increase application priority to make it more responsive

No need to do the initial filtering when there are no filters.
Should improve startup performance in that case.

Optimize SingleIdent::identifier() a bit, saves a few percent during thread model population (both in desktop and mobile KMail).

Reduce the number of times the thread model is re-populated on entering a folder from 12 to 2.

Redo the calculation of the bounding box in a better way.

The new way means that the bounding box is only recalculated when
there is a drawing operation. This means that changes to the
window/viewport origin or extension with no drawing are
disregarded. It also means that there is no recalculation when both
org and ext are changed in between but just after both have changed.

This probably means that we get a much better bounding box in many
cases.

Make sure the initial placement of shapes that are anchored is far far down
This makes sure we don't relayout more than needed - speedup
This makes sure no holes happen in 900kb.doc test file
This makes sure the images at the end in 900kb.doc ends up correctly

Better perfo on dashboard

Better performances on tracker page

Optimize painting tables.

Cache the bounding rect
Read the format once and then read the data from the format. e.g. getting the rowSpan creates a format
which is quite expensive. So get the format once and then read the data from the format directly.

don't do double pixmap caching; with the caching in the sheetview we can get rid of the caching in the cellview

Migration on kdateedit

Removed stop and loop buttons

Do not show the volume slider if there is no audio output

Do not say yes to search by default

Fix showing weekday names for history categories less than a week old.
With KDE 4.6 we can do neat things, like calling categories "Today" and "Yesterday"

show the client dialog (asking for actions) sooner, not only after
the discarded tile reaches its end position

animation: show rotating and scaling tiles above all others,
including those only changing position

ClientDialog: make it inherit from QWidget instead of QDialog,
works just as well and needs a bit less coding

Get rid of scheduleJob use as it is deprecated.

the git plugin has no more (unused) x11 headers, enable for any platform

Split up Smoke into Qt and KDE directories.
Move libsmoke stuff into the generator directory
Split up Ruby into qtruby and korundum directories

QtCore4.pm, KDECore4.pm: Allow client modules to tell QtCore4.pm about an array type they implement, for ambiguous method resolution.

handlers.cpp: Fix the from Perl marshaller for classes to use a version of Smoke::cast that correctly handles module boundaries.

util.cpp: Signals can be overloaded, but we want to check to make sure that the number of arguments passed to the signal are the same the number the signal accepts. So if we find a signal with the correct name but the wrong number of arguments, keep looking for another one.

util.cpp: Some weird cases when using the kperlpluginfactory ends up with entries in the pointer map that have a refcount of 0. Running hv_delete causes Perl to abort. So check the refcount before trying to delete them.

kperlpluginfactory.cpp: Use a "use lib" line instead of passing "-I" in argv to perl_parse. This way we can support loading in multiple plugins.

kdecore4handlers.cpp, plasma4handlers.cpp: Add a bunch of list handlers, copied from Ruby.

Update kdeui examples to not use the Qt4:: namespace anymore.
Update the analogclock plasmoid example. Now complete with calendar!

Now we also support OSX

Marble is _Virtual_ Globe now

provide per channel black offsets

Add a shallow DImgThreadedFilter wrapper for DImgBuiltinFilter,
if these semantics are needed

Here we go again... :-)

Adapt digiKam coding style guides:
This is a huge patch to finally have a common coding style in the source code.

This patch adds:
- curly brackets to all single line statements
- left pointer / reference operator style (char* bla)
- indent 4 spaces
- convert tab -> spaces

I did not change the libs from 3rdparty and the ones from libs/jpegutils.
Code compiles fine under Linux, there shouldn't be code breakage because we
only reformat the code and add missing brackets. If code is broken now
(logic errors due to missing brackets), it was broken before.

I add this as one single patch so we can easily revert it, if needed.
I think it is really important to have one common style in the code, and that we don't mix it.

I will also add some comments to the HACKING file later on.

Gilles,
can you check if all compiles fine under Windows and Mac?

Web extractor has moved to git

remove sidebar; remove old kde version check

- Replaced the direct use of webshortcut plugin configuration files with the new APIs in KUriFilter.
- Changed the code that launches the webshortcut configuration dialog to use KRun::runCommand.
- Connect to dbus signals to be informed of webshortcut configuration changes.
- Commented out all the debug statements. They can be uncommented when needed.

less direct kephal usage; moving panels when screens are removed is still an issue, but needs testing before i'd dare touch that

Testcase for form past names map
CCBUG: 137348

- increase the IntervalCheckTime to 60 minutes, because we have imap idle and manual sync

Make 'setSelectedPart' public for now.

The long time goal is to let AttachmentController base have its
own QItemSelectionModel which handles selection internally.

Move CollectionGeneralPage and CollectionAnnotationsAttribute from
kmail/ to mailcommon/

Do not introduce custom actions if you want custom behaviour.
Intercept the actions of the standardactionmanager instead, otherwise
all the advanced features of the standardactionmanager won't be used!

Move HierarchyResolver to mobile/lib as preparation for shared usage between tasks-mobile and kmail-mobile

Mark all tests expected to fail as Expected Fail.

This still doesn't make the whole test pass, though, even if the end report of TestLoadAndSave is 37 tests passed and 0 tests failed. :-/

ktorrent now in git

libktorrent has moved to git

Never change an active animation.
This is sometimes a nice effect in scoring games (quickly moving from player to player to player) but not worth the trouble

Add KrossWordPuzzle documentation converted from UserBase

Hope it will be useful if the game would be developed somewhere, sometime