Revision 1216557

Go back to digest for 30th January 2011

Optimization in Utilities

Raphael Kubo da Costa committed changes in /trunk/KDE/kdeutils/ark/kerfuffle:

cliinterface: Merge create the process creation and execution methods.

Inpired by what Okular does in its comicbook generator, it also makes
sense for us to remove the process we run in the same method (ie

findProgramAndCreateProcess, createProcess and executeProcess have
been merged: the process is now crated, run and destroyed in the same
method, which makes us not need to wory about deleting the process in
different places.

While at it, doKill()'s implementation could also be simplified, as we
waitForFinished() right after calling KProcess::start(), so we need
not call it a few more times in doKill().

File Changes

Modified 2 files
  • /trunk/KDE/kdeutils/ark/kerfuffle
  •   /cliinterface.cpp
  •   /cliinterface.h
2 files changed in total