Issue 173

6th March 2011 by Vladislav Blanton

Contributors

Vladislav Blanton
Marco Krohn
Paulo Dias
Marta Rybczynska
Danny Allen

This Week...

Strigi analyzers now read meta-data in their own thread, solving over 35 crash-related bugs in Dolphin and Konqueror. Global shortcuts can now be used to switch between keyboard layouts. Collections shared over NFS & SMB/CIFS networks return to dynamic collections in Amarok along with a refactoring of how plugins are managed. In KStars, labels can now be assigned to points on celestial lines and comet trails are rendered in OpenGL mode. New grouping by drag and drop in Digikam amongst other work. Support for Mobile Broadband on/off switch together with general bug fixing in NetworkManager. Support for SWIFT mt940 files and new "bubble" and "stacked area" graphs in Skrooge. Feature work and bugfixing in throughout Calligra. Work on bookmark handling in KOffice. Work on video capture support in Phonon, equalizer support in Phonon-Gstreamer, and optimizations throughout Phonon-VLC. Revamped UPnP plugin in KTorrent. Work on Oxygen-Gtk and Oxygen icons. New PSTricks backend for Cirkuit. First steps for OS X framework support in Smoke. Work on the collection scanner in OwnCloud. Bugfixing in Konsole, Kdesrc-Build, KDE-PIM, Kopete, Rekonq, and Krusader.

Statistics

Commits 2346 by 212 developers
Open Bugs 23536
Open Wishes 17423
Bugs Opened 506 in the last 7 days
Bugs Closed 477 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
173
 
/branches/stable
89
 
/trunk/KDE
48
 
/trunk/www
38
 
/trunk/kdesupport
37
 
/trunk/extragear
34
 
/trunk/playground
33
 
/trunk/l10n-support
32
 
/src/animations
20
 
/branches/work
14
 
Files Developer Commits
322
 
Hugo Pereira Da Costa
116
 
147
 
Harald Sitter
72
 
370
 
Marco Martin
70
 
150
 
Lamarque Souza
62
 
1542
 
Thomas Zander
48
 
57
 
Sergio Luis Martins
43
 
96
 
Casian Andrei
39
 
345
 
Yuri Chornoivan
36
 
813
 
Zarko Pintar
32
 
171
 
Michael Georg Hansen
31
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Brazilian Portuguese (pt_BR)
99%
 
Swedish (sv)
98%
 
Spanish (es)
95%
 
French (fr)
94%
 
British English (en_GB)
94%
 
German (de)
92%
 
Dutch (nl)
92%
 
Low Saxon (nds)
91%
 
Italian (it)
90%
 

Bug Killers

Person Bugs Closed
mg fork pl
82
 
Kurt Hindenburg
36
 
lamarque gmail com
32
 
David Solbach
24
 
Milian Wolff
22
 
Andrea Diamantini
22
 
Dawit Alemayehu
16
 
Christophe Giboudeaux
15
 
Tom Albers
15
 
Darío Andrés
12
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] [] []   []

Educational

[] [] []   

Graphics

[] []    

KDE Base

[] [] [] [] []

KDE-PIM

[] [] []   

Office

[] [] []   []

Konqueror

     

Multimedia

[] [] []   []

Networking Tools

[] [] []   []

User Interface

  [] []   

Utilities

[] []    

Games

[] []    

Other

[] []    

There are 169 selections this week

Bug Fixes

Development Tools

Michael Pyne committed changes in [kdesrc-build] kdesrc-build-test.pl:

Fix one more reference to my home dir layout.

The logging subsystem test case was passing because of an old log
directory I still had on my system. I've fixed the test case to use the
existing temporary test directory and to not use any existing log
directories.

I've gone over the code one more time, this should hopefully be the last
reference to anything on my system. :-/

Aleix Pol Gonzalez committed changes in [kdevelop/4.2] projectmanagers/cmake/cmakemanager.cpp:

Don't remove project items while the project is being reloaded.

Michael Pyne committed changes in [kdesrc-build] kdesrc-build-test.pl:

kdesrc-build: Make testsuite $HOME-compliant.

Pino Toscano noted that there were several tests failing on his system
after (well, and before ;) he changed the source directory setting in
the test suite to be under the home directory.

Indeed he is right, although I removed references to my home directory
when uploading my test suite, I did not remove references to my source
and build directories, which naturally did not contain svn sources on
Pino's system, which caused several tests to fail.

Now the testsuite will do a svn checkout (of kdesupport at this point as
I feel it is most likely to hang out in svn) before running tests on
functions requiring a svn source directory. The checkout is constrained
to avoid checking out any files or referencing any external svn
checkouts and is only run when running the test suite, so hopefully this
doesn't represent any significant load on the KDE svn servers.

In addition the base directory for all operations is under a temporary
directory, cleaned up when the test suite completes. Right now the
temporary directory is created under the normal temp dir (/tmp on my
system), the Temp::File docs seem to indicate this can be changed by
specifying DIR => /path/to/dir when running tempdir() if desired.

Finally, I ended up adding a test for the directory creation function in
the process of testing the test suite, which I left it because it's a
good idea anyways.

All tests pass on my system now with these changes, hopefully that will
be the case elsewhere.

Milian Wolff committed changes in [kdevelop/4.2] projectmanagers/cmake/cmakecodecompletionmodel.cpp:
Erlend Hamberg committed changes in [kate] part/script/data/haskell.js:

fix crash in haskell indenter

when searching for a “do”, the search could go above line 1. thanks to
Jakub Jaróżek for the patch.

Educational

Aleksey Khudyakov committed changes in /trunk/KDE/kdeedu/kstars/kstars/skymap.cpp:

Fix bug 242710. It was fixed alredy and reintroduced with OpenGL
rendering. Child widgets of SkyMap did not have mouse tracking
enabled

Graphics

Andi Clemens committed changes in [digikam] /advancedrename:

Set the parse timer duration to a smaller amount in singleFile mode

Jonathan Marten committed changes in /branches/work/kooka-kde4/libkscan:

Fix null pointer crash when looking up the current scan resolution
if the SANE_NAME_SCAN_RESOLUTION and SANE_NAME_SCAN_X_RESOLUTION option
names are not the same and the scanner only has the former. They were
equivalent in SANE 1.0.19, but in 1.0.20 they are different.

Marcel Wiesweg committed changes in [digikam] /:

Use a fitting zoom for the initially loaded picture.
This is a bit a workaround; I have the feeling the best solution would
be to port Canvas to the same codebase as the ImagePreviewView.

KDE Base

Oswald Buddenhagen committed changes in [kde-runtime] kdesu/kdesu/kdesu.cpp:

properly parse "kdesu command arg1 arg2 ..." syntax

fixes #265026
(cherry picked from commit a68bd758ca347a82e19d266f0c8356988d9d7e78)

Peter Penz committed changes in [kde-baseapps] /src/views:

Fix issue that wrong directory is shown

Commit 680009b522b2c9eda03201ac02dc18994b5a8bd0 resulted in a regression when switching from a view in the column-mode to a view in the icon- or details-mode: The wrong content has been shown. This patch reverts commit 680009b522b2c9eda03201ac02dc18994b5a8bd0 and solves the performance-issue in combination with previews by triggering the preview-generation in a queued way.

Oswald Buddenhagen committed changes in [kde-workspace/KDE/4.6] kdm/config.def:

default to poweroff for HaltCmd on linux

now that linux can have more bsd-like shutdown implementations (both in
form of gentoo and of systemd), it makes sense to treat it the same.


FIXED-IN: 4.6.2

Oswald Buddenhagen committed changes in [kde-runtime/KDE/4.6] kdesu/kdesu/kdesu.cpp:

properly parse "kdesu command arg1 arg2 ..." syntax


FIXED-IN: 4.6.2

Sebastian Trueg committed changes in [kde-workspace] /generic/runners/nepomuksearch:

Fixed mimetype detection for files: KMimeType::mimeType might return an
invalid mimetype since Strigi is not very reliable when it comes to
mimetypes.

Kurt Hindenburg committed changes in [konsole] src/MainWindow.cpp:

Correct issue where new tabs start in wrong directories.

Currently, Konsole only updates the tab folder ~2 seconds. After this
patch, when a new tab is requested the working directory is updated.

Patch by Christoph Feck.


FIXED-IN: 4.7

Dawit Alemayehu committed changes in [kdelibs] kioslave/http/http.cpp:

Correctly parse the parameter portion of the content-type header based on
RFC 2616 section 3.7.

Oswald Buddenhagen committed changes in [kde-workspace] kdm/config.def:

default to poweroff for HaltCmd on linux

fixes #267490 (and #270228)
(cherry picked from commit a58c0a17217b14e2e47415cfdfb1e8bb0b61a4d3)
(cherry picked from commit 4b7ec7c9966df0c705bc0c9b9bff1010475347b6)
(cherry picked from commit 28b79d8d04cce4d0a0899cadcc8fe6fd69d38e01)

Lukáš Tinkl committed changes in [kdelibs/KDE/4.6] solid/solid/backends/udisks/udisksstorageaccess.cpp:

USB drive is still powered on after disconnecting it in Device Manager

Peter Penz committed changes in [kdelibs] /:

KFileMetaDataProvider: Don't crash if a Strigi analyzer crashes

Some Strigi analyzers are still unstable and crash under certain circumstances. This patch moves the reading of the meta-data into a custom process instead of doing it in a thread, which assures that a crashing Strigi analyzer does not result in crashing Dolphin or Konqueror when hovering some items.

FIXED-IN: 4.7.0

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision d125496...
John Layt committed changes in [kde-workspace/KDE/4.6] libs/plasmaclock/calendartable.cpp:

Plasma Calendar: Re-enable akonadi event updates

Fix the plasma calendar to set the right flag to indicate a refresh of
the akonadi events is required. This should fix the problem, but while
I have confirmed this does now send a query to akonadi again, I don't
get any events back, but this si probably an artifact of my test
environment, it should work ok once in a full desktop/akonadi
environment.

Dawit Alemayehu committed changes in [kdelibs/KDE/4.6] kioslave/ftp/ftp.cpp:

Use "PASS" instead "pass" when sending password to workaround broken ftp server.


FIXED-IN:4.6.2

Oswald Buddenhagen committed changes in [kde-workspace/KDE/4.6] kdm/kfrontend/themes/oxygen-air/oxygen-air.xml:

revert wallpaper to "air"

why is this called oxygen-air and the screenshot shows an "air"
background? right: because the wallpaper is "ethais".
and why is this in kdebase? right again: because the wallpaper is in
kdeartwork.

uhm, maybe not right, after all. whatever the artistic vision behind
this is, the current state is technically bogus. consider moving this
theme to kdeartwork as a whole and making adjustments there.


FIXED-IN: 4.6.2

John Layt committed changes in [kde-workspace/KDE/4.6] /generic/dataengines/calendar:

Plasma Calendar: Update copy of Akonadi calendar model

The akonadi calendar model is required to understand the akonadi
calendar data, but is not yet publically available. This updates
the model to the latest version from kdepim 4.6 to include a number
of bug fixes.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 0182fae...
Timothy Pearson committed changes in /branches/trinity/kdebase:

Fix the following problems under Qt4:
* Konsole compilation failure
* ksplash exit failure
* kicker rounded tip masking behaviour
* kwin auto-exit issue

Diffs: 1, 2, 3, 4, 5, 6 Revision 1223001
Oswald Buddenhagen committed changes in /branches/KDE/4.6/kdeartwork/kscreensaver/kdesavers/Flux.cpp:

add missing glu.h include


FIXED-IN: 4.6.2

Oswald Buddenhagen committed changes in [kde-runtime/KDE/4.6] /:

add peer identification on openbsd


FIXED-IN: 4.6.2

Kurt Hindenburg committed changes in [konsole] /:

Move the 3 Search Bar options into their own popup menu.

Opening the search bar causes the terminal width to be increased due
to the length of the three Search Bar options text.
Ideally, this should be redone using .ui file (consider looking at the
KHTMLFindBar code in kdelibs). The Search Bar in general needs some
rework.

FIXED-IN: 4.7.0

Dawit Alemayehu committed changes in [kdelibs] kioslave/http/http.cpp:

Fix the issue of HTTPS over proxy not working properly when connecting to two or more secure sites.


FIXED-IN:4.6.2

Oswald Buddenhagen committed changes in [kde-workspace/KDE/4.6] kdm/config.def:

fix font defaults

of course it was extraordinarily clever of me to remove support for qt2
font specs from the config parser without adjusting the defaults.


FIXED-IN: 4.6.2

Lamarque Souza committed changes in [kdelibs] solid/solid/networking.cpp:

Verify if DBus reply if valid before using it. Prevents potential crash.

KDE-PIM

Laurent Montel committed changes in [kdepim] kmail/kmmainwidget.cpp:

Fix copy message to folder

Ingo Klöcker committed changes in [kdepim-runtime] resources/imap/settings.cpp:

Fix IMAP getting stuck if KWallet is not used.

- Make requestPassword() work if KWallet is not used.
- Do not crash if wallet is 0.
- Make the password prompt less cryptic.

Reviewed by Volker

Volker Krause committed changes in [akonadi/1.5] /:

Unbreak searching with Nepomuk 4.6.

Apparently, the Nepomuk query service D-Bus API changed *again*, breaking
searching in Akonadi. Now we use the interface used in KDE 4.6, so older
versions probably don't work anymore.

Diffs: 1, 2, 3, 4, 5, 6 Revision be3b9db...
Tobias Koenig committed changes in [kdepimlibs/komo3] mailtransport/smtp/smtpsession.cpp:

Report connection errors correctly to prevent hangs

The SmtpSession did not report socket errors back correctly
which lead to hangs inside the maildispatcher who was waiting
for the SmtpSession to finish its job.

Tobias Koenig committed changes in [kdepim/komo3] /ldap:

Fix blocking LDAP search queries

Make sure the LDAP search queries are really executed in their
own thread, so that weak network connections or slow servers to
not block the UI.

Sergio Luis Martins committed changes in [kdepim] /korgac:

When dismissing an alarm, check if it's in config and remove it from there too.

Otherwise it will popup when you restart korgac.
Fixes kolab/issue4382
MERGE: trunk
(cherry picked from commit ba29b5af5d7ea89a4c2f62d4d44365ba96be7707)

Conflicts:

korganizer/korgac/alarmdialog.cpp
korganizer/korgac/alarmdialog.h

Diffs: 1, 2, 3 Revision ee76d1e...
Andre Heinecke committed changes in [kdepimlibs/komo3] kcalcore/icaltimezones.cpp:

Write a valid VTIMEZONE on Windows CE

On Systems that do not provide a valid database about
Timezone transitions the VTIMEZONE entry of the ical
data would only contain the Tzid.

For WinCE there is now a fallback to write the current Timezone
information in the entry. This works since the gui on WinCE
does not offer the user to create an Event in a different Timezone.

I've added the code here in kcalcore instead of KTimeZone because
this is tailored specifically to what the ical format requires
and can not be generalized to other timezones then the current
Zone.

Office

Lukáš Tvrdý committed changes in [calligra] /libmso:
Jarosław Staniek committed changes in [calligra] kexi/widget/tableview/kexitableviewdata.cpp:

Tables: fix inserting row when field has "required" atribute set

Sven Langkamp committed changes in [calligra] /:
Dan Leinir Turthra Jensen committed changes in [calligra/nondestructive-unavail-leinir] /musicshape:

Add a textAsPath property to MusicStyle and use it when drawing

This ensures that the notes etc are drawn correctly into the SVG
preview files. It should also by all rights be in a self contained
class for exporting to SVGs, but as it seems impossible to do any
real extensions on QSvgGenerator, this has become the hack that
became the only solution...

Diffs: 1, 2, 3 Revision 6bfe71f...
Cristian Oneț committed changes in /trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck:

Printcheck plugin fixes:
- fix typo
- added payee's post code
- fix a rounding bug when displaying the fraction as string
- add a check templated created by Bob Donnelly

Diffs: 1, 2, 3, 4, 5 Revision 1223910
Inge Wallin committed changes in [calligra] /vectorshape/libemf:

Fix the EMF parser: All MoveTo and polyline records use signed numbers.

I don't understand how this could have been undetected this long.

Diffs: 1, 2, 3, 4, 5, 6 Revision 136c27c...

Multimedia

Harald Sitter committed changes in /trunk/KDE/kdemultimedia/dragonplayer/src/app/stateChange.cpp:

when the Phonon MediaObject's video presence changed, we need to trigger a fake state change to get QActions enabled that are depending on the presence of video. In particular Phonon VLC only detects video *after* it switched to playing state which essentially means that the video related menus will be disabled until a state change occurs (say switching to pause). By manually triggering a change from current state to current state we can easily work around this.

Ralf Engels committed changes in [amarok] /:

Report Sql database errors during startup and scanning as error dialog.
It seems that our focus group is not looking for the debug output when running Amarok or even when reporting errors.

Bug: 262086

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision a64c357...
Peter C. Ndikuwera committed changes in [amarok] /core-impl/collections/db/sql:

Fix NFS & SMB/CIFS Remote collection

Using Max's Mass Storage Device code as a guide, this commit returns
network-based collections, shared over NFS & SMB/CIFS to the dynamic
collection architecture.

This should re-validate http://amarok.kde.org/wiki/Dynamic_Collection,
which some people have complained to longer applies.

Test it & break it!

Networking Tools

Andrea Diamantini committed changes in [rekonq] src/urlbar/completionwidget.cpp:

Do NOT take the first element of an empty list

Lamarque Souza committed changes in [networkmanagement] backends/NetworkManager/nmdbussettingsconnectionprovider.cpp:
Lamarque Souza committed changes in [networkmanagement] kded/service.cpp:
Andrea Diamantini committed changes in [rekonq] src/opensearch/opensearchmanager.cpp:

Do NOT parse suggestions referred to empty strings

Lamarque Souza committed changes in [networkmanagement] applet/nmpopup.cpp:

Fix/Optimize Wwan (Mobile Broadband) detection.

Lamarque Souza committed changes in [networkmanagement] /:

Removing notifications Event::UserConnectionAttempt and
Event::AutomaticConnectionAttempt. They have never been implemented and
they do not make much sense since we also have a Event::Connecting
notification.

Andrea Diamantini committed changes in [rekonq] /useragent:

Prevents rekonq from crash if an UA service cannot be found.
This fix needs IMHO an extra informational string that will be postponed to after 0.7 stable
release.

Andrea Diamantini committed changes in [rekonq] src/history/historymodels.cpp:
Lamarque Souza committed changes in [networkmanagement] /:

Implementing Event::ConnectFailed notification.

Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp:

Do not call setWrong if the password prompt has been cancelled by the user.
Thanks Christopher January for the patch.

Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete:

Applying patch from http://reviewboard.kde.org/r/5364/
Thanks Igor Poboiko for the patch.

Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp:
Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete:
Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete/libkopete:

Applying patch from http://reviewboard.kde.org/r/3260:
Do not ask whether to come back from auto-away when there are no accounts connected
Thanks Teemu Rytilahti for the patch.

This patch is not meant to be backported to 4.6.

Lamarque Souza committed changes in [networkmanagement] applet/activatablelistwidget.cpp:

Prevent potential crash if ActivatableListWidget::setHasWireless(false)
is called after ActivatableListWidget::listDisappeared().

Joachim Wilke committed changes in [kfritz] libfritz++:

Fix logging into Fritz!Box without password


FIXED-IN: 0.0.8

Andrea Diamantini committed changes in [rekonq] src/mainview.cpp:

This changes fixes a crash that can occur on fast closing a lot of tabs.
It anyway changes a bit the behavior in that situation, running to set as current
the first tab (That FOR SURE will NOT be deleted)

Utilities

Yuri Chornoivan committed changes in [krusader] /:

Fix b.k.o. bug #267695: Remove listitem with wrong description.

Yuri Chornoivan committed changes in [krusader] /:

Fix b.k.o. bugs #267708, #267718.

Diffs: 1, 2, 3 Revision 0a3f625...

Games

José Manuel Santamaría Lema committed changes in [knights] /proto:

Store autoLogin setting when changing the checkbox.

Miha Čančula committed changes in [knights/2.3] /:

Really fix the crash when starting a new game.

All the winner handling code is moved to Manager from Board, and moves are ignored when the game is not running.

Diffs: 1, 2, 3, 4, 5 Revision 2ebf58f...

Other

Nicolás Alvarez committed changes in [kde-ruleset] /:

Add simple script for merge-synthing and a parentmap for kig.

The script is basically a simpler wrapper around add-parents and
translateRevlist. We still need more scripting to iterate over all repos
and do filter-branch with the correct paremtmap.

Features

Development Tools

Michael Pyne committed changes in [kdesrc-build] kdesrc-build:

Allow cloning XML-based modules from command line.

kdesrc-build prefers module names fed in from the command line
(obviously ;), but if the module didn't already exist on disk then the
only source of info about the module is probably encoded in the rc file,
but the modules read from the rc file were ignored.

This change simply copies over the more accurate rc-file-based modules
that have matching names, without this change you'd get modules that
tried to git-clone themselves from "kde-projects" instead of
git://anongit.kde.org/foo.git since the pass the alters repository
settings only runs on modules that are supposed to be based off of
projects.kde.org.

BogDan Vatra committed changes in [android-qt-creator] /:

improve ProWriter editing capabilities

- completely replacing existing value lists
- creating assignments instead of appendings
- writing value lists as a single line

Diffs: 1, 2, 3, 4 Revision fcbbdf9...

Educational

Jérôme Sonrier committed changes in /trunk/KDE/kdeedu/kstars/kstars/skycomponents:

Add labels for important points on the equator/ecliptic.

Andreas Cord-Landwehr committed changes in /trunk/KDE/kdeedu/rocs/src/Plugins/GenerateGraph:

Implement creation of random graphs by usage
of BOOST's random graph library

Jérôme Sonrier committed changes in /trunk/KDE/kdeedu/kstars/kstars/skyglpainter.cpp:

Implement SkyGLPainter::drawSkyLine().
Trails are now drawn also in GL mode.

Graphics

Marcel Wiesweg committed changes in [digikam/development/2.0] /:

A graphics item which manages mouse events to draw a rectangle.
It is positioned on top its parent and is transparent.
Both Press-Drag-Release and Click-Move-Click are supported.

Diffs: 1, 2, 3 Revision 713bb62...
Marcel Wiesweg committed changes in [digikam/development/2.0] /items:

Remaining glue code to make grouping work.

Current status:
There is basic support for grouping by drag-drop and context menu.
TODO: The visual representation is to be improved - we'll probably need some
custom drawing, as there are no suitable icons. Some visual indication
for items that come from opened groups.
The actions are very context-sensitive, so adding to the main menu
is not straight-forward.

Kåre Särs committed changes in [skanlite] /:

Save scanner options on exit + add revert button to settings dialog

Diffs: 1, 2, 3, 4 Revision e8a7114...
Aurélien Gâteau committed changes in [gwenview/compare-images] /:

Implement "deselect" button

Marcel Wiesweg committed changes in [digikam/development/2.0] /:

Implement manually adding a face

Marcel Wiesweg committed changes in [digikam/development/2.0] /dragdrop:

Implement grouping by drag drop
The structure of the code was not entirely clean, and is still not very well structured.
Expecting some rough edges, there are many situations to consider.

Aurélien Gâteau committed changes in [gwenview/compare-images] lib/documentview/documentview.cpp:

Nicer current indicator

KDE Base

Nikhil Marathe committed changes in [kdelibs] /:

Added HUpnp version reporting and detection.

FindHUpnp.cmake now exposes HUpnp version extracted from HUpnpCore/public/hupnpinfo.h
Solid will require HUpnp v0.9.0

Marco Martin committed changes in [plasma-mobile] /appletstrip/package/contents/ui:

start of a gesture based system for extra actions

Diffs: 1, 2, 3, 4 Revision ac029b0...
Nikhil Marathe committed changes in [kdelibs] /solid/backends/upnp:

Update UpnpInternetGateway to use HUpnp v0.9.0 API

Lamarque Souza committed changes in [kde-workspace] /:

Add support to NetworkManager's Wwan (AKA Mobile broadband) on/off switch.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision bd86ea1...
Casian Andrei committed changes in [kde-runtime] /:

Add basic support for video capture devices

Use the existing device discovery mechanisms to add support for video
capture devices. Mostly copy paste with adaptations.

Attempt to get a list of video capture devices from Solid, and
corroborate them with PS and Phonon.

Some changes for the platform plugin device access lists.

Extend the KCM module to display video capture devices. Currently
it doesn't suport testing them. Only tested by showing a video
device.

Add blank lines here and there.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision d23edaf...
Casian Andrei committed changes in [kde-runtime] phonon/kcm/devicepreference.cpp:

Rethink categories system in device preference

Each device type (audio output, audio capture, video capture) may now
have it's specific categories. If new categories are added, they can
be used only by the device types that fit it.

Andriy Rysin committed changes in [kde-workspace] /keyboard:

Allow (global) shortcuts per keyboard layout

FIXED-IN: 4.7

Kurt Hindenburg committed changes in [konsole] /:

Add command-line option --list-profile-properties

This new option will list all the profile properties' name and type.
This info can then be used with the -p name=value; command line option.

Diffs: 1, 2, 3, 4, 5 Revision 78f0d05...
Rafael Fernández López committed changes in [libbluedevil] /:

Add usableAdapter that will return the first usable (powered) adapter connected
to your computer.

The rationale behind this is that we can have more than one adapter connected
to our computer, and the default one (usually the builtin one, if present) could
be powered off for energy saving or whatever reason. This method will return the
first adapter found that is ready to be used.

KDE-PIM

Thomas McGuire committed changes in [akonadi-facebook] libkfacebook/noteinfo.cpp:

Sucessfully create message!

We now create create valid messages!
They show up (sucessfully) in kjots!

Thomas McGuire committed changes in [akonadi-facebook] /:

Basic deletion of notes works!

Diffs: 1, 2, 3, 4, 5, 6 Revision 91978e8...
Volker Krause committed changes in [kdepim] /:

Allow to disable indexing for individual folders.

Makes a lot of sense for trash and spam folders for example, and we cannot
auto-detect all of those.

Office

Thomas Zander committed changes in [koffice] /:

Add a dialog to jump to bookmarks

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 18426de...
Lukáš Tvrdý committed changes in [calligra] /:

Improve the bullet list rendering

o Load&save the text-properties in
list-level-style-* from the ODF spec.
o Don't render the mark shapes with QPainter,
but use font directly (as OOo or MS Office does)

This patch includes also work from Gopalak's patch

REVIEW:100733
REVIEW:100679

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 188d51f...
Yue Liu committed changes in [calligra] /src/plugins/dockers/stencilboxdocker:

add new stencilshape factory

Marijn Kruisselbrink committed changes in [calligra] /:

add implementations for the various COUP* functions that were missing

Diffs: 1, 2, 3 Revision 4fffe1d...
Lukáš Tvrdý committed changes in [calligra] /plugins/tools/defaulttools:

Improve the multihand tool

o add support for the airbrushing mode
o improve the gui per mode
a) vertical, horizonatal and both mirroring is possible
b) allow to setup radius for the area of the translated brushes

Lukáš Tvrdý committed changes in [calligra/krita-multihand-ltvrdy] /plugins/tools/defaulttools:

Improve the multihand tool

o add support for the airbrushing mode
o improve the gui per mode
a) vertical, horizonatal and both mirroring is possible
b) allow to setup radius for the area of the translated brushes

Yue Liu committed changes in [calligra] /src/plugins/dockers:

add knewstuff3 support for stencilboxdocker

Diffs: 1, 2, 3 Revision 0a0dd09...
Stephane Mankowski committed changes in /trunk/extragear/office/skrooge:

feature: New "stacked area" graph type

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 1222963
Marijn Kruisselbrink committed changes in [calligra] /:

add a number of extra functions from the openformula spec

Diffs: 1, 2, 3, 4 Revision 12b957d...
Michel Ludwig committed changes in [kile] /widgets:

Add a directory selection button (and the corresponding dialog) which allows it to
select the default location for projects in a more comfortable way.

Patch by Felix Mauch

Stephane Mankowski committed changes in [skrooge] /:

feature: New "bubble" graph type

Diffs: 1, 2, 3, 4 Revision 918ce69...
Pierre Ducroquet committed changes in [calligra/words-save-table-style] /kotext:

First draft for saving table style... Not really interesting so far, only the width is saved, and not in the right place... But things are coming...

Diffs: 1, 2, 3 Revision 9d574ab...
Marijn Kruisselbrink committed changes in [calligra] /:

Commit GCI patch by goffrie; implement the PERMUTATIONA function

Diffs: 1, 2, 3, 4, 5 Revision 9f7f5a9...
Thomas Zander committed changes in [koffice] /:

Add create bookmark dialog

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision b9d7c81...
Stephane Mankowski committed changes in [skrooge] /:

: Support for mt940 files

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 6d5236a...

Multimedia

Harald Sitter committed changes in [phonon-gstreamer] /:

Map gst equalizer name to the one used in pxine

This allows API consumers such as Amarok to actually maintain a working
equalizer with phonon gstreamer, even though gstreamer uses a different
name for the EQ than phonon xine. This ought to be fixed in spitfire as
we are targetting an enum based identification system there. So, ideally
application developers can then check the available effects for
Effect::Equalizer and request that from the backend. Much more scalable
than the current name-based approach.

What I'd like to see meanwhile is amarok check for both KEqualizer and
equalizer-10bands in the EngineController. The manual mapping is very
ugly and should go away ASAP.

Bart Cerneels committed changes in [amarok] /services/opmldirectory:

Enable search in OPML directory.

A bit hackish since it will only search in already expanded nodes (i.e. doesn't automatically fetch more).
Usuability suggestions welcome.

Diffs: 1, 2, 3, 4, 5 Revision 18061ca...
Casian Andrei committed changes in [phonon-vlc] /:

Improve device finding and handling

- Mark all audio output devices as advanced, we don't want to pollute
the user with all kinds of strange named outputs that don't work
- Improve the device name and description
- Remove experimental ifdefs around anything related to
Phonon::DeviceAccessList

Diffs: 1, 2, 3, 4, 5 Revision 5113eb9...
Casian Andrei committed changes in [phonon] /:

Add new capture device setters for MediaSource

Diffs: 1, 2, 3 Revision 0a68f15...
Casian Andrei committed changes in [phonon] /:

Add AvCapture include

Diffs: 1, 2, 3 Revision e4b6065...
Casian Andrei committed changes in [phonon] /:

Implement communication with the platform plugin

Now video devices are properly fetched from the platform plugin.

Rick Chen committed changes in [amarok] /:

Merge branch 'rickc-pluginselection'

This merge is a refactor of how plugins are managed. The goal was to
make loading all plugins optional (except the db collection plugins).

o plugins include service, device, and collection plugins
o plugins (and scripts) selectors are available in the config dialog
o gui part of ScanManager is taken elsewhere

note: you may need to clean the build directory first.

Conflicts:
src/App.cpp
src/ScriptManager.h
src/context/applets/lyrics/LyricsApplet.cpp
src/core/plugins/Plugin.h
src/dialogs/ScriptManager.cpp
src/scriptengine/AmarokLyricsScript.cpp

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 161 more) Revision fb3ab32...

Networking Tools

Lamarque Souza committed changes in [networkmanagement] /:

Add support to Wwan (AKA Mobile Broadband) on/off switch.
I included a Plasma::CheckBox to enable/disable mobile broadband. The
checkout will auto-hide if there is no Gsm/Cdma interface available.

Diffs: 1, 2, 3 Revision 5ba7c57...
Florian Reinhard committed changes in [telepathy-accounts-kcm-plugins] /:

Add telepathy-sunshine configuration plugin.

Reviewed-by: David Edmundson

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 830b7e5...
Florian Reinhard committed changes in [telepathy-accounts-kcm-plugins] /:

Add skype (bigbrownchunkx-skype-dbus) support to haze plugin.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision c8db119...
Joachim Wilke committed changes in [kfritz] /:

Add provider selection in dial dialog


FIXED-IN: 0.0.8

Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete/plugins/statistics:

Applying patch from http://reviewboard.kde.org/r/5629/.
Thanks Luca Tettamanti for the patch.

Diffs: 1, 2, 3, 4 Revision 1223427
Lamarque Souza committed changes in /trunk/KDE/kdenetwork/kopete/kopete/contactlist:
Florian Reinhard committed changes in [telepathy-accounts-kcm-plugins] /:

Add MySpaceIM (myspace) support to haze plugin.

Reviewed-by: David Edmundson
REVIEW: 100776

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 86c7c86...
Joris Guisson committed changes in [ktorrent] /:

Revamp UPnP plugin:
- Remove useless connection field from widget
- Forward ports on all detected routers instead of only the default one

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk/1.0] /:

added gdk_visual_has_rgba to remove code duplication.

Hugo Pereira Da Costa committed changes in [oxygen-gtk/1.0] /:

added cairo_rectangle_negative method.

Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

4 for the price of 1

Diffs: 1, 2, 3, 4, 5 Revision 1222957
Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

commiting icons not staging them for commiting them later ;)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 1223425
Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

41 to go

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 1223436
Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

40 to go

Utilities

Eike Hein committed changes in [yakuake] /:

Pull the window to the current virtual desktop under certain conditions.

When the window is set not to show on all virtual desktops and is not
residing on the current virtual desktop, but is open (i.e. set to stay
open regardless of focus loss), the Open/Retract action normally used
to either retract it, or, when the option to also use the action to
focus the window is enabled, cause the window manager to switch to the
virtual desktop the window resides on. The former case, i.e. when the
option to also use the action to focus the window is disabled, has now
been changed to move the window to the current virtual desktop and
focus it, rather than retract it.

Also augments the What's This blurb on the focus option to mention the
window manager's VD switch behavior, and added some code comments to
help charting the codepaths.

Matteo Agostinelli committed changes in [cirkuit] /:

Improved template management

Now it is possible to properly edit and remove templates using the
template manager

Diffs: 1, 2, 3, 4 Revision e46b8aa...
Matteo Agostinelli committed changes in [cirkuit] /:

Improved image viewer

Moved some actions inside the image viewer to add support for popup
menus.

Diffs: 1, 2, 3, 4 Revision 5aaa1fe...
Yuri Chornoivan committed changes in [krusader] /:

Fix b.k.o. bug #267546: Replace Bookmark with BookMan II

Matteo Agostinelli committed changes in [cirkuit] /backends:

New PSTricks backend

Added a new backend for PSTricks. Basic functions are implemented.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 8af61fc...
Jan Lepper committed changes in [krusader] /Filter:

new class FilterSettings
stores settings of the filter dialog;
loads/saves them from/to config;
generates a KRQuery from the settings.

Diffs: 1, 2, 3 Revision 3cfc3b6...
Guillaume de Bure committed changes in [skrooge/plasma-dashboard] /:

Add Banks datasource to the dataengine

Games

Arno Rehn committed changes in [smokegen] /:

Use QHash instead of hash_map. Removes hacks and deprecation warnings.

Other

Jakob Sack committed changes in [owncloud/refactoring] /:

Make it possible to use several datadirs.
This could be useful if the user does not want his gallery images on the webdav storage.

Arno Rehn committed changes in [smokekde] /config.xml.cmake:

first step for OS X framework support

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision bbff0b2...

Optimization

Development Tools

Dmitry Risenberg committed changes in [kdevplatform] /:

Add projectOpeningAborted signal to IProjectController to handle situations when loading a project encountered errors or was aborted.

Diffs: 1, 2, 3, 4, 5, 6 Revision cd7eb84...
Andrey Batyiev committed changes in [kdevplatform] plugins/git/gitplugin.cpp:

Turn off colored diff and external diff tool while doing "git diff".

Thanks to Michal Malek.

REVIEW: 100765

Educational

Aleksey Khudyakov committed changes in /trunk/KDE/kdeedu/kstars/kstars/skycomponents:

Fix mempory leak! SkyPoints were never freed

KDE Base

Alex Fiestas committed changes in [kde-workspace] plasma/generic/applets/notifications/ui/stackdialog.cpp:

adjustSize of the Stack Widget once the StackDialog is hidden

Right now a notification with a long title will create a very long
NotificationWidget and that widget will resize the stackdialog to
its size. The problem is that once the large notification group is
closed, the StackDialog will continue having the notification width
and it won't resize to a normal size.

This patch calls to "adjustSize" when the stackdialog doesn't
have any notification, so it will be resized to the right size.

Casian Andrei committed changes in [kde-runtime] /kded-module:

Refactor PS::AudioDevice and PS::AudioDeviceAccess

- remove commented stuff
- move method implementations to cpp
- remove inlining because readability > very minor performance benefits
- reorder methods a bit
- insert blank lines for readability

Diffs: 1, 2, 3, 4 Revision bb3e865...
Vishesh Handa committed changes in [kde-runtime] /services/backupsync/service:

Properly fix the memory bloat problem

The problem was that the changeLog and identification set produced could be very large in size. Therefore keeping the entire thing in memory was not a viable option. This patch makes sure that entire ChangeLog is never kept in memory while creating a Backup. ( It is still going to be required when restoring a backup )

Diffs: 1, 2, 3, 4 Revision 76074bc...
Sebastian Trueg committed changes in [kde-runtime] nepomuk/services/strigi/indexscheduler.cpp:

Do not update all folders recursively. This fixes an issue where all folders are
updated when something in the home folder changes.

Vishesh Handa committed changes in [kde-runtime] /services/backupsync/lib:

Faster Identification when minScore == 1.0

The identifiation process is very slow in the case when minScore == 1.0. This is because findMatch calculates the score for each property matched and then prunes the resources whose score falls below the minScore. This all cannot be done in one sparql query.

However, when minScore == 1.0. The entire identification process gets reduced to one query. Making it a gazillion times faster!

KDE-PIM

Sergio Luis Martins committed changes in [kdepimlibs/4.6] /:

Revert: Add getter methods for the destination collection and items (e72698f6eb1934603ad1661eceee4bca0b849b0d)

We shouldn't add new API in the 4.6 branch.

Found by Kevin.

Office

Dmitry Kazakov committed changes in [calligra/krita-bounded-pooler-kazakov] /image/tiles3:

Added a benchmark for COW to measure the pooler help

The results of the benchmark:
We measure a write access to every tile of an RGB16 image of size
4096x2048 pixels. This rewrite demands COW for every tile.
The measured time is:
o with pooler enabled: 12ms
o with pooler disabled: 94ms

Conclusion:
the pooler is worth spending time on it ;)

Diffs: 1, 2, 3, 4, 5 Revision c3177f1...

Multimedia

Harald Sitter committed changes in [phonon/mrl] /:

Add warning about temprorary deprecation

After some discussion we condcluded that there is no gain from
deprecating the QUrl interfaces, but instead provide Mrl interfaces and
use Mrl internally (hence the interfaces so that API consumers can avoid
pointless conversion to Mrl and the inflicted overhead).

Harald Sitter committed changes in [phonon-vlc] /:

style++ && turn backend into a semi-singleton (in that it has a self
member) since there is no phonon-vlc without actual backend instance we
can do that, not terribly nice though as backend only gets accessed to
get hold of the devicemanager. Now since there is also only one DM the
DM should probably be the singleton. For now lets keep it safe tough.
This eliminates the need of holding a reference to the backend in AO and
ADO.

Diffs: 1, 2, 3, 4, 5, 6 Revision 21cb2c7...
Harald Sitter committed changes in [phonon-vlc] /:

cleanup++ style++ and all that mumbo jambo

I also shot m_buffer dead, which was an amazingly useless member as we
alloc the buffer in lock() and free it in unlock(), both are callbacks
and in both we get a ptr to the buffer.

Harald Sitter committed changes in [phonon/zeitgeist] phonon/mediaobject.cpp:

More performant function order

Fist check the state as it can cause a return, getting metadata before
that would be a waste if we are in a returning state.
Also add some empty lines for readability... one gets to think this
should be a class ;)

Casian Andrei committed changes in [phonon-vlc] /:

Remove wrong and no longer useful libV4L2 stuff

Diffs: 1, 2, 3, 4 Revision 59d4ee1...
Harald Sitter committed changes in [phonon-vlc] vlc/mediaobject.cpp:

Make Video appear quicker (aka almost instantly)!

Let us be a bit daring here. Rather than looking for video on the 15th
timechanged event, let's try 15 times and then no more. Usually I get
video on the first or second timechanged event, so there is no point in
having it delayed for as long as 15 event callbacks.

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:

Clean up the "rekonq handling chain" to work as:

1. preHandling: about, javascript, abp protocols. Stops if protocol is NOT known
2. WebKit handling: Allow WebKit to try doing its job
3. postHandling / unsupported content handling: try what is possible to let users see it :)

This also prevents some possible infinite loop on opening...

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk/1.0] /:

Simplified access to widget orientation.

Diffs: 1, 2, 3 Revision 01ce4bb...
Hugo Pereira Da Costa committed changes in [oxygen-gtk/1.0] /:

do not use (soon obsoleted) GdkRegion to generate gap mask.

Hugo Pereira Da Costa committed changes in [oxygen-gtk/1.0] /:

cleanup: renamed dialog_find_button into gtk_dialog_find_button and simplified code.
Also fixed debug messages.

Diffs: 1, 2, 3 Revision ac2d29f...

Security

KDE Base

Oswald Buddenhagen committed changes in [kde-runtime/KDE/4.6] kdesu/kdesud/secure.cpp:

Other

Development Tools

Milian Wolff committed changes in [kdevelop/4.2] projectmanagers/cmake/cmakedocumentation.cpp:

make sure cmake documentation stay readable on dark color schemes

we force a white background as that is what most HTML pages assume the host browser would default to

KDE Base

Vishesh Handa committed changes in [kde-runtime] /services/strigi:

Only emit notification events if actually indexing

The "Suspending of Indexing to preserve resources" and vice versa messages are emitted every time the power
status changes. They should only be emitted if the power status changes AND the indexer was indexing files.

Otherwise they are just annoying.

Harald Sitter committed changes in [kde-runtime] phonon/platform_kde/kdeplatformplugin.cpp:

nice code is the first step to world peace

(0 == foo) == (!foo)

Chris Burel committed changes in [perlqt] /lib:

Update version number. Currently 96% of the Qt examples work in Perl, so we're at version 0.96.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 11 more) Revision 3b8f633...
Vishesh Handa committed changes in [kde-runtime] /services/backupsync:

Rename backupsync ontology to NRIO

The ontology was still called "backupsync", since that is what it was called when this code was in the playground. It's time to move to the new name - NRIO ( Nepomuk Resource Identification Ontology )

Additionally, since rdf:type is a sub-property of nrio:IdentificationProperty. It is no longer requested separately in the IdentificationSetGenerator

Diffs: 1, 2, 3, 4, 5, 6 Revision 9ba66e1...

Office

Thomas Zander committed changes in [koffice] /:

Lets stop maintaining 5 year old docs

The docs writing action is something that we moved to the userbase
wiki already and to be frank; these docs don't reflect the software
at all anymore. Any user will feel frustration and any
docwriter will feel guilty having to delete big parts.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 637b555...

Multimedia

Robin Appelman committed changes in [owncloud/media_player] /media:

More collection scanner improvements.

It now manages to scan my entire collection successfully

Diffs: 1, 2, 3 Revision 1945d5c...
Trever Fischer committed changes in [phonon-gstreamer] /:

Move swaths of plugin installation code to the PluginInstaller

Cleanup is probably needed. The mediaobject is still pretty freaking
huge; its hard to catch everything. Plugin installation still behaves as
previously (broken in places, but works for mp3s and rsndvdbin).

Diffs: 1, 2, 3, 4 Revision ae379e2...

Networking Tools

Andrea Diamantini committed changes in [rekonq] src/main.cpp:

Re-enabled the raster graphics system by default on X11.

Previous problems were not really regarding QtWebKit, but the graphic layer on.
Hope they will no more cause troubles..

Lamarque Souza committed changes in [networkmanagement] applet/nmpopup.cpp:

Hide the "Enable Wireless" checkbox if there is no wireless interface
available. The checkbox still takes space in the plasmoid, there is no way to
prevent that without some sort of code logic that I think is not worth the
trouble.