Issue 181

fix crash in ADL helper

Display more realistics twilights in Alt vs time tool.
This should also fix bug 179389.

CollectionManager: fix for collections on network shares

QUrl default constructor expects an unencoded URL. If an encoded
URL is used, the '%' is again encoded and the resulting URL
is unusable. AlbumRootLocation::identifier seems to be already encoded,
therefore use the proper QUrl::fromEncoded() method.

Without this fix, existing collections on network shares are always
marked unavailable and new collections can not be generated.

Signed-off-by: Matthias Welwarsky

BUGFIX: thumbnails for videos showed up too large in thumbnail viewer

Reason: when an image request was made for a video thumbnail from say
the annotation dialog, then it was unconditionally added to the cache,
which is wrong, as this would then be the image that is used in the
thumbnail viewer then.

BUGFIX: Insert "broken image" icon into the cache when failed loading
video

Without this, the video is attempted at being loaded over and over
again.

Finish always clear()ed the loaded items. Change name and semantics
of the call and check that the item is really going to change.

Keep order of the main album view in the rename dialog

No OpenGL/GLX compositing on Gallium softpipe


FIXED-IN: 4.7.0

Implemented the required copy constructor and assignment operator for ExtraFields since it used
in a Qt container (QMap).

Don't use the qobject_cast macro for detecting interface inheritance.

The CodeCompletionModelControllerInterface4 interface extends the interface
CodeCompletionModelControllerInterface3 but qobject_cast cannot detect this
inheritance. Hence, the CALLCI macro in katecompletionwidget.cpp always uses
the default implementation for CodeCompletionModelControllerInterface3
instead of the potentially overridden methods that may be present in a code
completion model implementing CodeCompletionModelControllerInterface4.

Test the case where there are no mimetypes installed at all.

Surprisingly, it works: KMimeType::findByUrl does not return NULL,
contrary to what the bug report says. There must be a subtle difference
somewhere.

Perform glFlush before deleting the EffectFrame's pixmaps

On NVIDIA it is possible that the actual rendering gets delayed to
after the deletion of the pixmap during the end of fullscreen effects.
This was causing freezes. By using glFlush before deleting the pixmaps
we can ensure that the pixmap is not needed anymore after the pixmaps
are deleted.


FIXED-IN: 4.6.3

Fix panel controller width when running on multiple monitors.

The panel controller was taking only a portion of the bigger screen
width (that was primary). With this patch, we force the widget to
calculate its size before being shown.

Also, syncToLocation needed a small tweak, since when updating
struts were needed (this is, dragging the panel from horizontal to
vertical [or reverse] layout), the panel itself was taking the whole
screen (because of setting the maximum size to QWIDGETSIZE_MAX).

REVIEW: 101254

On redirection, update the proxy script URL so that it avoids a catch-22:
proxy url retreival require a proxy url! Fixes a long long standing bug.


FIXED-IN: 4.6.3
(cherry picked from commit 32fffc6767d5f93796c804ea5528e404698a0455)

Install wallpaper system wide

Otherwise the default config can't find it when installed from package

Fix glitches with scaled windows for the XRender backend

Scale window contents and decorations togheter in order to
avoid 1px glitches caused by rounding errors;
This has the net benefit of scaling only one pixmap instead of two
for each window*clipper and should actually give some performance bonus

I've tested this for some time with no issues, but this commit
*might* cause regressions. In case, let me know.
CC

Do not allow the adition of a source that is already connected

If you try to connect a source that is already connected, it should
return and not create a duplicate of that source.

Signed-off-by: Artur Duque de Souza

While processing changes in the source, don't process selections.

Because the proxy hadn't processed the rowsInserted or rowsRemoved
signal yet, it was creating corrupt internal data.

Possible crash fix. Please retest.

KWin does not require a decoration plugin any more

With config option "NoPlugin" in group "Style" it is possible to
no request that KWin should be run without a decoration plugin.
This is a change for Plasma Active to properly support no decorations.

As well if a decoration plugin cannot be loaded, KWin will no longer
exit, but continue to run just without a decoration. As a nice
side-effect changes in Oxygen no longer destroy my kwin build ;-)


FIXED-IN: 4.7.0

Make Logout Effect work again with OpenGL 2 backend

It's more of a hack, but at least it is working again. Still needs
a proper rewrite to also support GLES.

only use lanczos filter when either direction is scaled below 90%

Fix a couple of 'put-slave-on-hold' bugs that prevent the feature from working
properly under certain circumstances.

Fix the job accounting issue, a greater number of jobs running than actually
are, when an ioslave is put on hold.

REVIEW:101244

Make present windows effect not preserve space for windows from other activities
REVIEW:101180

Do not store cookies for HTTP jobs

Bug 271580: Fix crash displaying New Alarm dialog from system tray

Fixes a crash on some systems when the New Alarm dialog is displayed
from the system tray icon menu.

Change check in RTM::Task::setDeleted from isCompleted to isDeleted. This typo caused that it was not possible to delete completed tasks (the commonest usecase for deleting tasks).

Bug 266082: highlight alarm when message window KAlarm button clicked

Fix the KAlarm button in the alarm window not always showing the main
window, and not highlighting the alarm in the main window.
Applies when using kresource framework, not Akonadi.

Reactivate the functionality to remove shapes.
Seems there are cases where the frameset isn't probably destroyed.

PPT: Updated application of character styles.

implemented odf loading support for axis font size, read global
text settings in the filter to fix 262694

PPT: Ignore bookmark in calculation of the end of a text chunk.

* Bookmark are not supported at the moment, so let's keep it simple.

Fix endless updating of page variables

There was a problem with updating the page number on the page. It created an endless
loop which updated the page number all the time.
The problem was caused by the fact that sometimes when we try to set the page number
when resizing the variable the text position was not layouted yet and therefore a
the rootArea was a 0 pointer which let the page number be set to 0. Then later it was
set to 1 and the game began from the start.

To avoid that problem we break variable processing here until we get a valid rootArea.

It would be nice if someone with more knowledge on the text layout could have a look at
this and tell me if it is the right way to do.

The code works nicely and removes the endless loop and paints the correct page number.

libmso: Check for exceptions while parsing complex data.

Fix Bug: Footer in the ppt files is not displaying

Reactivate the presentation variables.

Refresh tag editor if collection is updated while visible.

The indefatigable Giorgos Kylafas managed to troubleshoot the cause of a bug
where the Tag Editor's artist, genre, and track name fields would be reset to
the first item in the respective combo boxes after the collection was updated,
although this behavior only occurred if the tag editor was visible when it
happened.

I would say this should have tipped me off, but I haven't had enough time for
JuK recently so honestly I haven't looked at it. Giorgos has, however, and I
can confirm he tracked down the issue correctly and fixed it.

Going through the bugs seems to indicate this might be the cause of 271054
(JuK tag guesser works improperly if tag editor is open), which I believe is
caused the the tag editor being updated when the file renamer operates,
immediately updating the relevant fields to the wrong values and (somehow?)
then saving those changes.

This commit is against trunk, I will backport to 4.6.3.

restore mimetypes removed in r1225583 as x-scheme-handler/ instead

Remove runtime backend switching

This was causing super horrible issues as it gets somewhat ugly when
phonon does not destruct the backend objects completely.
In the past this caused various problems (e.g. in gst callbacks to
objects that were not existing anymore) as well as recreatable
crashes on switching itself, not just of the KCM but *all*
currently running Phonon applications.
Generally speaking it required the backends to implement object
tracking as to destroy the whole backend graph upon backend switch,
which was only implemented in Xine and even there was insanely
complicated given the use.

Talking about use... it was agreed that the benefit of runtime
switching does not justify the work involved to implement and
support across multiple backends. Additionally switching the backend
ought not be something you do every day, but ultimately not ever as
the default backend installed by the user or the distributor should
be of sufficient stability and use. Should this not be the case it
*must* be considered a bug and treated as such. Working around by
switching to another backend does not contribute to the long-term
user experience in any way.

The implementation at hand replaces the backend switching logic with
a QMessageBox informing the user that she will have to restart the
application in order to apply the backend change.
In KDE 4.7's Phonon KCM we will introduce a more visually compelling
way of feedback. Unfortunately, as to maintain support for older
releases both the DBus interface and the handler function must remain
present to provide the silly messagebox feedback :S


FIXED-IN: 4.6.0

Re-establish chat after going offline and back online part 1

this patch is in preparation for closing bug #270725.
I basically created some setup methods for connecting the signals and slots for the textchannels, chat tab
and the contact model of chatwidget.
Plus the search for duplicate tabs is no longer done by matching the incomingTextChannel, but the targetId
of the channel.

Fix wrong required diskspace calculation in some rare circumstances

Add notifications for VPN connections.

Re-establish chat after going offline and back online PART 3 of 3

Final part of bug 270725: An existing chat window/tab stops working when going offline and back online. When
user goes offline, the chat is invalidated. If the user comes back online, and the previous chat window is
still open, the chat with that contact is re-established.


REVIEW: 101260
Reviewed by: David Edmundson

Try to avoid dangling pointer when setting signal strength for an access
point that has just been destroyed.

Make "Show More" button work as expected when going to and coming back
from interface details widget.

Try to avoid dangling pointer when deleting RemoteInterfaceConnection
objects.

do not eat mouse-move + button press events caught by the window manager at end of grab.

Add CWL file for the soul package.

Patch by Thomas Braun.

Avoid crashes when running Kile in a non-English locale.

In the EditorExtension class it was assumed that the opening and closing
variants for double quotes in a given option string for inserting double quotes
are always separated by two space characters. Unfortunately, this option string
was also passed to an i18n function call. Hence, in some languages (e.g. French)
these two spaces were sometimes not added to the translation, which could result
in a crash when the opening and closing quotes were to be extracted from the
option string. This has now been fixed by using two lists for internal and
external (i.e. internationalised) double quote options.

KTouch increased the level even if there's only one level. This fix allows this feature only if there is more than one level.

Expected behaviour: KTouch doesn't restart the lecture when the "Automatic level adjustment" configurations are achieved in case of a custom lecture file.

Fix for spanish keyboard layout. Thanks to Juanlu

* Add Ruby extensions for some more Qt libs

Activate JIT support.

* Change existing Ruby extensions to the QtRuby 3.0 style

Added move support to cmake, some refactoring.

* Add Ruby customizations for the various QtGui classes

Add Brazilian keyboard layout. Thanks to:
Juliano F. Ravasi
Rodrigo Dias


CCMAIL: bugs+

Initial POI icons support.

New static class called OsmGlobals, where default colors and POI icon styles are stored.

Initial osm rendering support.

Ways are rendered as GeoDataLineString without any styling.
Support for rendering polygons (areas) and buildings.
All nodes are stored as GeoDataPoint in singleton class NodeFactory.
*.osm files can be loaded through File->Open menu or from command line.

Add a placemark search option to the 'Go To...' dialog.

Similar to the 'Navigation' tab of the desktop application, a line edit
can be used to enter search terms and runners fetch matches presented
in the list view.
REVIEW: 101261

FIXED-IN: 1.2.0

Added firsts files to develop Scilab backend.

Initial osm rendering support.

Ways are rendered as GeoDataLineString without any styling.
Support for rendering polygons (areas) and buildings.
All nodes are stored as GeoDataPoint in singleton class NodeFactory.
*.osm files can be loaded through File->Open menu or from command line.

Make it possible to remove selected results from the search results list.

Allow all the tab widths to be the exact title length.

This toggles between the current calculations of the tab width and just
using the full title for the tab width.
This is a dbus method which will have to do unless I can get a GUI
in before the freeze.

Implement a CLI tool allowing to add remote plasmoids

Use the D-Bus call on the Plasma Desktop shell to create a cli helper
tool allowing you to add a remote widgets based on its URL. So something
like "plasma-remote-helper plasma://host:port/name" will add the
plasmoid "name" exported from "host" to your current activity.

port klipper to use Prison for barcodes

Outline effect to replace rendering of the outline

It just uses the selection of the EffectFrame for the outline.

FIXED-IN: 4.7.0

Add description for the plasma protocol

We now support publicly plasma:// URLs, so add a protocol file which
calls the plasma-remote-helper application to deal with such URLs.
Particularly handy from the network:// ioslave which exposes Plasma
remote widgets.

REVIEW: 1515

New QML based notifications plasmoid for mobile.

Small Plasma Remote Widgets browser

QML based small Plasma Remote Widgets browser allowing you to see
all the computers exposing those, and the actual content. Also allows
to add such remote widgets to your current activity just by clicking on
them.

Allow to get tooltips to popup instantly on hover

Add an "instant popup" property on ToolTipContent allowing to control
for a given tooltip to popup immediately when the corresponding widget
is hovered. The default is the usual behavior though.

The ToolTipManager behavior itself got adjusted to take care of the
instant popup flag.

kwin: Implement shadows in XRender compositor

There are still some glitches to be fixed, but
it works well for most use-cases.

Show "Version Fixed In" if available, for reports marked as FIXED.

REVIEW: 101200

Implement a dialog to show unhandled Bugzilla errors.

I created a dialog that will show the RAW Bugzilla HTML output when
the response can't be parsed by DrKonqi. The user is encouraged to
perform the action again later or save the HTML data to submit a DrKonqi bug.

REVIEW: 100681

Different themes support and install

Allow to specify an icon field and adjust plasma url

Now for services building you can specify an icon field to be used from
the service advertising. Use that in the case of plasma which uses that
feature. Also adjusts the generation of the plasma:// url to map with
what's used internally for the plasma remote widget feature.

Add more explanations about why DrKonqi requires certain amount of characters in the bug description.

Tells the user that the required information is proportional to other information,
such as the backtrace or the reproducibility rate. Also, check and tell the user
if he/she has previously selected that they could provide some contextual information.
Additionally add some line breaks to make it easier to read.

REVIEW: 101203

Implemented support for monitoring local proxy configuration script files for
changes so that those changes could be applied automatically.


FIXED-IN: 4.7

Update Solid's support to org.freedesktop.NetworkManager.Device
interface to NM-0.8.2. Two properties have been added: IpInterface and
FirmwareMissing. Now only Ip6Config is still missing from that NM's
interface.

IpInterface is slighty different from the already supported Interface
property. In most cases they return the same value, but for serial
devices (dial-up modems, Gsm, Cdma, Bluetooth) Interface returns the
serial device (/dev/tty*, /dev/ttyACM* /dev/ttyUSB*, /dev/rfcomm*) and
IpInterface returns connection's IP interface (usually ppp0).

Modify the applications tab to use breadcrumbs

FlipScrollView can now be controlled from the outside to set which
item is used as its root view. Also now it notifies the outside of
root changes.

At the other end, the launcher now adds an extra row of buttons at the
top of the application tab to create a breadcrumb bar. The buttons of
this bar simply ask the FlipScrollView to jump at the right place in
the model.

forward port of a389a45ecaea2577f5162edd1485356c81263cce

prevent accidental desktop swaps

Suport NetworkManager's Bluetooth devices. This is needed for Plasma NM
recognise bluetooth devices (usually cell phones) and use them as means to
access the Internet (tethering).
Since the patch changes Solid's ABI it will be available only in KDE SC
4.7.0.

QML Bindings for Plasma::ToolTips

Implementation of a proxy to make it easy to declare tooltips in QML,
that will use Plasma::ToolTipManager to display tooltips in any item
that is declared in QML.

The syntax is:

import org.kde.plasma.core 0.1 as PlasmaCore

PlasmaCore.ToolTip {
target: id_of_the_target
mainText: "hello"
subText: "world"
image: "konqueror"
}

The syntax looks pretty straightforward and simple. "id_of_the_target"
is the id of the element which will show the tooltip in case it's hovered.

If the target is a QGraphicsWidget, the code path is really simple but if
it's a QDeclarativeItem, then we create a wrapper (that is a QGraphicsWidget)
and setup that in a way that we set this wrapper as the target on Plasma's
API. For libplasma2 we may want to change this so it's more generic (and
also put this together with the components).

Right now there is two open issues for me:

1) we should use "image" or "icon"? Allowing the use of a image that is
a string that identifies the icon for KIconLoader seems simpler and more
beautiful to me, but it would be nice to specify a random QPixmap. Besides
being able to use the bindings for QIcon it doesn't look very good. Marco,
do you have any thoughts on this issue?

2) for touch oriented UIs, the tooltip as it is right now is not very
useful. Is there any "touch" scenario where we may want to use them?


Signed-off-by: Artur Duque de Souza

allow hiding of xembed icons, treating them as application status icons

Add Coisceim.

This is an example application showing what is possible with the KDE PIM platform.

Implement readOnly() for Akonadi kresources.

Now it doesn't ask me if I want to save in my local calendar
or in my Facebook folder anymore, since only the local calendar
is writeable.

REVIEW: 101229
(cherry picked from commit 8f85db2a32cab4bad987b2100424fbaf42f6ed26)

feature: Merge of an imported operation with a manual operation is now possible even if amounts are different

Make SVM support in the vector shape permanent.

It's not a setting anymore, we can actually show a significant part of
many SVM images.

DOC: Improved processing of group shapes.

* Added support for the REF_WITHOUT_KEYWORD field.

* Preparing a graphic style for the draw:g element. It's required for correct positioning in case of floating object.
Wrapping and positioning attributes are not required in graphic styles of child shapes. Also the child element does
not require the draw:anchor-type and draw:z-index attributes.

* Setting draw:auto-grow-height and draw:auto-grow-width to false by default in libmso. It's absence seems to affect
the layout of floating objects. The logic to set those attributes remains a TODO!

feature: New advice to align scheduled operation amount with the last amount inserted

SVM: Implement META_TEXTCOLOR_ACTION that controls the text color.

Added structs for basic SVM datatypes

Make DBus optional even when Qt is built with it

Sometimes it is desirable to build and deploy Phonon without dbus even though
the Qt build has dbus support. To achieve that we have a new cmake option
PHONON_NO_DBUS and a new header providing the setting to the world.
Additionally if QT_NO_DBUS is set, we also set P_N_D, making latter the
ultimate macro to go by.

switch from (lib-)xine to (lib-)vlc

- many issues (esp. crashes) vanish / are easier to fix
- likely you need the 'full' vlc package (with X11 plugins)
- this commit introduces introduces various regressions ;-)
- big picture problems with libvlc:
- dvd navigation (likely solved with libvlc 1.2 once it's released)
- VDPAU
- make MediaWidget more state-orientated, i.e. separate between
- functions, which modify the state (e.g. a signal from the backend)
- functions, which rely on the state (e.g. ui updates)

Add button in wireless configurator to copy the current access
point's MAC address to BSSID.

Uses KAuth (KDE's Policy Kit wrapper) to authorize users to
create/delete/modify system connections. I am not sure if this is the
right way to use KAuth but it works for me.

Updates for bluetooth tethering support.

Full support only in KDE SC 4.7.0 because Plasma NM needs Solid 4.7.0 to
detect bluetooth network interfaces. In the mean time Plasma NM will treat
bluetooth network interfaces as gsm network interfaces. I still need to
implement bluetooth tethering for Cdma phones and Gsm/Cdma) Panu.

Without Solid 4.7.0 Plasma NM will not list the bluetooth interface nor
the bluetooth connection, so the only way to connect is setting the
bluetooth connection to autoconnect. There will be no notifications from
knotify either without Solid 4.7.0 and of course interface details tab
will not work because the interface is not listed.



FIXED-IN: 4.7.0

Improve handling of 802.1x certificates

Certificates are now imported to $HOME/.kde/share/networkmanagement/certificates
for user scope connections and /usr/share/kde4/apps/networkmanagement/certificates
for system scope connections. This allows the user to move the original file out
of the way without worrying about connections. Certificates are passed to NM using
the path scheme to enable support for files containing multiple certificates.


REVIEW: 101275

Imported Opera feature to load favorite page with number 1..9 by pressing CTRL + 1..9

Courtesy patch by Thomas Murach. Thanks :)

Reviewed by Pierre, Felix... and me!

RB: 101043

PS:
Thomas, I see one corner problem with your patch:
Opera has clearly indicated favorites preview
number, while rekonq hasn't. Any idea to fill the gap?

Updates for bluetooth tethering support.

more work on 32x32

more work on 32x32

more work on 32x32

Add context menu to route stop items

Menu with these entries:
- Create a filter for departures via the clicked stop
- Show an intermediate departure list for the clicked stop
- Copy stop name to clipboard

New state "showing intermediate departure list" (entered by the new
context menu action)

Library updated to help adding/finding/removing intermediate stop
settings, which get deleted automatically when "Back to Departure List"
gets pressed.

FEATURE: middle mouse button on tab change highlight color

Avoid repeated consecutive calls to the private class.

According to callgrind the function call is executed often enough to
lead to a measurable runtime fraction.

Do not preload files that has already been loaded
This is the setup:
The thumbnail view is resized, and as a consequence all thumbnails are
scheduled to be loaded. At the same time, the thumbnailview will request
all images visible to be created (this with a higher priority).

This commit makes the code which preloads the thumbnails check if they
are still needed (and thus not recreate them if they were already
created by the thumbnail view).

This will speed up things if there esp. is many videos visible in the
view.

Notice the above also applies to images that was scrolled too before
they were reached by the preloader.

Improve duplicates count on the Report Information Dialog

In the Report Information dialog (duplicate selection page):
- Do not show the "bug XXX was marked as duplicate of this one" comments.
That should help people to read the important information (other cases explanation).
- Count the crashes attached inline (by DrKonqi) as duplicates
(when showing the duplicate count on the top of the report).

REVIEW: 101079

Improve duplicates search by filtering out more (system and Qt) core functions

This patch filters out more system and Qt core calls that may appear or not
on duplicates; as an attempt to make the duplicates search more reliable.

Removed some notifications: don't annoy users with nepomuk suspended/resumed messages every time they are running on battery.

Automatically delete the notification when action clicked

When the user clicks on the button that will trigger the action of
the notification, we delete the notification so it doesn't hang there
'forever'. Let's see how it goes, but I think it improves the usability.



Signed-off-by: Artur Duque de Souza
Reviewed-by: Marco Martin

Update frame animation once every 20msec to KWin

The rationale here is that kwin paints 50 frames per second, so we make
sure that the coordinates of the thumbnails are updated at least once
for every frame.

The mechanism is implemented using two timers, the frameUpdater
refreshes the coordinates from the QDeclarativeItem every 20msec. It's
started when an "animation event" (contentXChanged) arrives.
The frameController is started at the same time, but is a single shot.
It's there to stop updating the frame after 200msec, so the updating
only happens during animations.

This patch has the effect that it fills in frames in between that are
skipped because the contentXChanged signal doesn't fire often enough for
us to keep the animation updated.

I've removed the timer from the QML file, since that's now basically
redundant, and more performant in the C++ part (less signals crossing
QML -> C++). More code cleanup in here as well.

Indeed, it makes the animation feel much more smoothly, although there's
still a slight perceived lag when you start dragging.
prop.diff

Does not reload images if they already exist.

This speeds up looking at the most recent comic strip if one had already visited it before.

Adding an option GLLegacy to force OpenGL 1

Setting option "GLLegacy" to true in config group "Compositing"
will disable all GLSL shaders and kwin uses the legacy OpenGL 1
code pathes. Obviously the option is ignored with GLES.

As my Qt Designer is refusing to work, there is no GUI option yet.

Removed dialog asking what set of settings should be loaded at next burn.

Most of the new users are not able to answer this question sensibly. Not because they're dumb but because they don't know the application well enough and it's hard for them to forsee the consequences of their choice. For this reason the dialog is frustrating.
Now by default the saved settings will be loaded which is IMHO the best choice for most users.

Add Elektrobit priceless work, I'm sorry but I could not keep the history.