Revision d2caddd...

Go back to digest for 15th May 2011

Optimization in Multimedia

Ralf Engels committed changes in [amarok] /core-impl/collections/daap/daapreader:

Make the DAAP protocol parsing in Amarok more robust

The Firefly version installed on my Readynas Duo (Radiator 4.1.7) sends the
aeMK (mediakind) field as an 32 bit int instead of a 8 bit char.

Amarok currently only consumes one byte instead of four, despite the fact that
the field length is correctly reported as four bytes by the server. The
attached patch reworks the DAAP protocol parsing to be more robust.

Courtesy Lukas Sandström

File Changes

Modified 2 files
  • /core-impl/collections/daap/daapreader
  •   src/Reader.cpp
  •   src/Reader.h
2 files changed in total