Issue 201

Use more "standard" Perl for kde: auto-handling.

Laurent Montel reported an error that indicates a syntax error in the
git error handler for the kde: support. Even after extracting out the
error handler and forcing it to run Perl works just fine here, so it's
not a semantic issue either.

So instead, just use a plain 'ol Perl 5.0-style hash to figure out the
error message, no need to make it complicated.

In addition I added the stderr > /dev/null redirection that I forgot to
have in place before.

PositionTracking: only keep detailed level accuracy positions

Support gpsd 2.96 and 3.1.

Patch based on Vincent Batts patch submitted in bug 269165, thanks!
Tested with gpsd 2.96 (berlios tarball), gpsd 3.1 (berlios tarball)
and 2.95 (ubuntu package).

Don't crash when evaluating a bvar with a list (container) value.

Titration calculator is now correctly shown.

Unable to export original file to Flickr

do not use prefix operator with pointer. this doesn't work, at least with DNG converter. The result image is a black hole.

Picasa import fetches scaled-down photos

ctrl+wheel: zoom font

before, ctrl+wheel was "scroll a page". This got lost with this commit.
However, pretty much all applications (web browswers, qt creator) zoom
font with ctrl modifier.

Added file item count for the size field of directories in metadata.

Metadata of directories used to show block size inside the size field
and not the actual size. Actual size calculation can be very time
consuming, so added the number of items in a directory (based on the
discussion on the bug page).

FIXED-IN: 4.8.0

ANSI escape code "\e[1;93m" should generate intensive color.

The current behavior is bold(1) will toggle the intensity of an
intensive color(93), so the result is a normal color. This is
counter-intuitive. Xterm, rxvt, and all vte-base emulators generate
intensive color in this case.


FIXED-IN: 4.8
REVIEW: 102554

When using -e <command> don't save to profile for new tabs.

Currently using -e <command> will cause all new tabs/windows to run
<command>. This patch fixes that such that new tabs/windows will start
the default profile.

Patch by Gu Rui with minor edit by self.
FIXED-IN: 4.8
REVIEW: 102602

Konsole should never save a profile with empty name into disk.


FIXED-IN: 4.8
REVIEW:102559

Workaround repaint issue in blur effect with GLES

This is actually a bloody hack by forcing the screen to be
repainted in each frame. This needs to be fixed in a different
way or we at least have to turn blur off by default for GLES in
the next release.

When searching, apply change in case sensitive option immediately.

Patch by Francesco Cecconi

-Do not set WA_OpaquePaintEvent attribute for line edit clearButton
(should fix the not transparent background bug)
-Optimize a bit the code to enable/disable it



FIXED-IN: 4.7.2

Fix desktop locking with opengl screensavers

phonon: Don't assert on critial failures from PulseAudio.

While this indicates a pretty bad situation that we'd like to get more
feedback on, it's not really a nice user experience to crash, so limp
on and dome some info into kDebug() instead.

fix kiosk restrictions for user switching and logout

it was using authorizeKAction, which means the keys would be "action/logout" while documentation
clearly states it is just "logout". that is now fixed, including keeping support for "action/logout"
so as not to break existing configurations.

switch_user simply wasn't being checked at all, now it is.

Fix bug 276276 SMS length should be limited to 70 chars when using non-ascii chars

Thanks to David for his help
FIXED-IN: 4.7.2

Add Key_Enter to open reader dialog box

Don't hang when the wallet service is completely disabled.

This apparently is different than just denying the resource access to
the wallet.

Fix bug : Bug 230357 - Conditional jump or move depends on uninitialised value when editing filters

FIXED-IN: 4.7.2

Bug 207035 - Composer gives no indication when editing in overwrite mode, rather than insert mode

FIXED-IN: 4.8

Revert "Inform when we make a bad password (not new i18n)"

On the next mail check, the user will be asked for the password
again, since we set mAskAgain to true.
In addition, the error message is shown by AkonadiTray, like
any other error message from Akonadi.


This reverts commit 38af197f1f73242a8739e704a39bdeb75ce61020.

Make the maildir resource more standard compliant:
- regarding file names (233379)
- moving out files from new to cur (233378)
- storing flags
- reading flags from filenames (252449)

Make sure we always use the part id for creating part file names.

This was found by the new overlapping part checker and seemed to result
in a <0.07% chance of having a part overwrite the file of another one.
Since this will not be written back to the resource normally, the actual
risk of data damage is probably even smaller.

Prevent possible loose of filters if Akonadi is not running

Fix crash on agent_launcher exit.

Don't unload plugins here. They will be unloaded on application exit,
so it's redundant.

Seems they are being unloaded too early, before QThreadStorage
cleanup occurs:

==18802== Invalid read of size 8
==18802== at 0x53178AE: QThreadStorage<QFontCache*>::deleteData(void*) (in
/data/installation/qt/qt-4.7/lib/libQtGui.so.4.7.1)
==18802== by 0x5E8F8CF: QThreadStorageData::set(void*)
(qthreadstorage.cpp:165)
==18802== by 0x5317940: void
qThreadStorage_setLocalData<QFontCache>(QThreadStorageData&, QFontCache**)
(qthreadstorage.h:92)
==18802== by 0x53165BA:
QThreadStorage<QFontCache*>::setLocalData(QFontCache*) (qthreadstorage.h:148)
==18802== by 0x531407A: QFontCache::cleanup() (qfont.cpp:2632)
==18802== by 0x5406536: QFont::cleanup() (qfont_x11.cpp:182)
==18802== by 0x5104E35: qt_cleanup() (qapplication_x11.cpp:2647)
==18802== by 0x50603B2: QApplication::~QApplication()
(qapplication.cpp:1172)
==18802== by 0x41B1F6: main (agentlauncher.cpp:28)
==18802== Address 0x11a090b0 is not stack'd, malloc'd or (recently) free'd

Fix Bug 233735 - kmail deletes text in body instead of subject when pressing Ctrl-K in subject line

FIXED-IN: 4.7.2

Properly migrate imap accounts with separators different from '/'

We had to add some more checks to actually find out from the kmail
config which separator was used per namespace and use that instead
of simply hardcoding '/'.

Fix Bug 266456 - Message list tabs icons are not refreshed when changing the current one.

FIXED-IN: 4.7.2

Make the maildir resource more standard compliant:
- regarding file names (233379)
- moving out files from new to cur (233378)
- storing flags
- reading flags from filenames (252449)

Add visual info to signal that we can't rename folder to empty string or we can't have "/" in name.

FIXED-IN: 4.7.2

Change synchornous akonadi job execution to async to prevent strange deadlocks.
Remove code that doesn't make sense anymore, and try to actually make it work (fails though, too tired to debug it, but see the existing FIXME).

Monitor file changes as well, not just directory changes.

Monitor file changes as well, not just directory changes.

Watch the root maildir and the .NAME.directory folders for changes to recognize there newly moved mails and folders.
Fix recognizing newly created mails in the maildir folders.

PPT: Do not alter bullet character information, use correct numbering.

* Save the bullet character as stored in the binary. We provide the font information
so let the upper layers decide what to do in case the font is not installed.

* Improved the logic when to restart/continue numbering in numbered lists,
especially nested numbered lists.

Fix the remaining anchoring issue.

This fixes anchoring issues at least in following documents;
* books.evc-cit.info%2Fxforms_ooo_%306_%308_15.odt
* docs.globaltext.terry.uga.edu%3A8%3095%2Fanonymous%2Fwebdav%2FInformation%20Systems%2FIS%20Book%20Version%202%2FSection1%2FISChapter%301.odt
* offthechainak.org%2Fbikerepair1%301%2Fhandouts%2Fhandout-cranksBottomBrackets.odt
* wiki.documentfoundation.org%2Fcgi_img_auth.php%2Fc%2Fce%2F%302%305WG3-PrintingExportingEmailing.odt
* wiki.services.openoffice.org%2Fw%2Fimages%2F9%2F91%2F%305%308IG3-SlidesNotesHandouts.odt
* wiki.services.openoffice.org%2Fw%2Fimages%2Fe%2Fe6%2F%303%304CG-ChartsAndGraphs.odt
* www.odfauthors.org%2Fopenoffice.org%2Fenglish%2Fuserguide3%2Fimpress3%2F3%30_published%2F%305%308IG3-SlidesNotesAndHandouts.odt

REVIEW:6791

If an existing cash dividend transaction is selected, the form shows widgets
for Date, Amount, Total and Status, which is what is expected.
If that transaction is then opened for editing, additional widgets show for
Security, Quantity and Price, which aren't expected for a cash dividend.
If, while the transaction is open for editing, 'Dividend' is reselected, the
additional fields disappear. Similar behaviour occurs for Buy transactions.

Also, in numerous places, the likes of -
QWidget* w = haveWidget(*it_s);
if (w)
w->hide();
were found to produce unreliable results.

Also, When a Dividend transaction is opened for editing, the fee category field is
active, but there is no label. If a fee category is entered, the fee amount
field becomes active - again no label, and if an amount is entered, the total
reflects this change. However, when the transaction edit is accepted, the fee
amount has been lost.

Also, fees have been removed from Dividends, and interest income has been removed from
Buy and Sell, as these seem most unlikely combinations.

I've noticed various other anomalies in the various investment types, to do
with unnecessary fields, missing labels and one where it's possible to enter a
value for a fee without a category, and which doesn't get retained.

Don't add the shape via a KWFrame to words if the page-number is invalid.
The specs say that the page-number needs to be a positive integer. If the
page-number is not, and is either negative or zero, then OO.org just does
not display the frame. Now we do the same.

CC
Some more on average calculation (more usage of float instead of long).

Moved K3bSetup functionality to K3b's config dialog

K3bSetup never really belonged to SystemSettings. When user wanted
to change device or programs permissions he'd needed to switch to
SystemSettings which was not obvious. Hence this settings were moved
to K3b settings window. Program permissions can now be changed in a new
"Permissions" tab on "Programs" section.
Modification of devices permissions has been removed altogether. In
all (?) modern systems optical devices belongs to a certain user group
(e.g. "cdrom"). If the current user does not belongs to this group,
he's offered to add himself to it in "Devices" section of K3b settings
window.


FIXED-IN: 2.1.0
GUI: K3bSetup no longer exists

Fretplay.com is down, so stop asking for tabs from that site.

However support for ultimateGuitar.com is still available.
Nevertheless I will try to work on adding support for songsterr.com.
It's a growing new site, provides better graphical tab display and
also has an open API to fetch tabs.

K3b::IsOverburnAllowed: Don't count used capacity twice.

Get sure page is extant before searching for DOM elements there

Check for Accounts KCM before trying to open it

Reviewed-by: Mr. Edmundson

Improve code in plugin loading (not yet perfect, I fear...)

Fix close & session

First, I'm really sorry for this bad commit ('git' talking..).
The fact is that the 3 bugs fixed here were found chained playing
with close code. Here it is the report:
- fix close window (it now really appears on multiple window closing)
- fix saveSession (saving one call for each site loaded and storing
better information): saveSession is now called on loadFinished
- clean up some compilation warnings

Inform the user of a failed preview correctly when a sub-tool (like BibteX or Makeindex) fails

Fix the scriptengine breakage causing non-working game examples

,

The comment was changed in those two lines:
- d->appendScript( asset, className );
- //d->buildScript();
...
+ //d->appendScript( asset, className );
+ d->buildScript();

If it is intentional, it might require further study. That was the culsprit
of the breakage. It was a bit hard and sleep deprivated time to follow git
bisect so long, but the games are at least now working nicely. :)

Say hello to Quadruplor !

Quadruplor is an android application used by android/runtests.pl script
to run qt tests. After the test is finished the script gets and stores
the results.

Make it possible again to compile just one file, use CMakeFolderItem
instead of ProjectFolderItem to pass the relative path.

Render Plugin: GpsInfo

REVIEW: 102571

Statically simplify (x->x+1)(x+1) into x+2.

Makes use of | much more fluent.

introduce OverpaintBlending

OverpaintBlending paints a tile on top of another, respecting transparency.

Added displaying/editing the coord in the Bookmark editor

Use the complete filename (until the last point)
in the slideshow screensaver

add GPS info to gallery.xml in htmlexport plugin

FEATURE: add service for powermanagement tasks such as suspension and shutdown

Use new modal system nofitication dialog in kdebase smserver
Add fancy startup dialog to match the fancy shutdown dialog
This is only used if the themed splash screen is turned off

Replace the matches label with a "Select all ### matches" checkbox

Allow to configure email indexing in Nepomuk KCM.

This adds an option to the Nepomuk KCM to disable email full text indexing.
It's somewhat comparable to file system indexing in terms of resource
usage, so there has been demand for such an option and this seems to be
the natural place to put it.

This goes together with a number of patches to kdepim that make KMail and
the email indexing agent honor this setting, which have been committed
already.

REVIEW: 102440

working video player

a component for pinching, still experimental

and MeeGo specific, all those pinching related features can be enabled in the default build when it will depend from Qt 4.8

First attempt at the poppler based PDF analyzer

It currently caches most of the file in memory, and doesn't
support produce rdf for the metadata present in the pdf (Author,
Title, etc)

Additionally, the FindPoppler.cmake has been copied, and isn't
what we want - It looks for the presence of the Qt4 version, which
we don't care about.

Initial import for videoviewer

Improved online/offline handline for the POP3 resource.

- set the status of the agent to "offline" when it is offline
- abort the current mail check when going offline

Allow '#' in emails domain part for simpleAddress

Also include tests for the other ways of processing email addresses.

Allow non-local folders as target for SPAM mails

With Akonadi there is no reason anymore why only local folders
are allowed as target folder.

Add database janitor thread.

All it can do right now is vacuum a MySQL database, triggered by a D-Bus
method call.

Add support to search from the current cursor

The support is now there now we need to find a way on how to use it with the current UI

libmsooxml: Added missing numbering types.

* Re-ordered according to the spec. to improve the readability.
* Added also support for prefixes.

Begin work on a properties dialog for anchoring properties

Make a "smart positioning" tab in the shape properties.
For now we can only view the anchoring properties of the selected shapes
Later we should implement applying it to the shapes in question

K3b::IsOverburnAllowed: Increase tolerance from 10% to 25%.

10% are not enough to allow using CD-R90 and CD-R99 media to full capacity.
The new 25% tolerance allows using those media while still catching the common
case of DVD ISO vs. CD media.


REVIEW: 102648

Make Dragon Player use Phonon instead of xine-lib for DVD menus.

This long overdue patch drops all the xine-lib dependencies for Dragon Player.

DVD menu support (VideoWindow::toggleDVDMenu) is now implemented in terms of Phonon. This requires at least Phonon 4.5.0, otherwise the function will do nothing (which is the same thing it previously did when not building against xine-lib).

I also fixed a string in mainWindow.cpp which was referring to xine-lib. Distros backporting this patch may or may not want to skip this string change.

Builds in Rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=263774

REVIEW: 6794
FIXED-IN: 4.8.0

CC
Fix volume writing. Backport to branch 4.7

K3b::IsOverburnAllowed: Increase tolerance from 10% to 25%.

10% are not enough to allow using CD-R90 and CD-R99 media to full capacity.
The new 25% tolerance allows using those media while still catching the common
case of DVD ISO vs. CD media.


REVIEW: 102648

Prepend 'Typing...' to the window title if the other side is typing

Reviewed-by: Francesco Nwokeka

Plasma applet first implementation.

Add basic drag&drop support for contact list

Currently only dragging between groups is supported, but much more is planned (and in the works already).

Reviewed-by: David Edmundson
REVIEW: 102543

DIGEST

Allow DSL connections be associated to ethernet interfaces.

Add first GTFS accessor: us_trimet

- The zipped feed is ~15MB, which extracts to ~110MB
- In the database it uses ~140MB, where approx. the half is used
for indices, which are used to make the used SQL queries fast
- This is the first official data source and they have some courtesy
text to be shown, this text is in the <credits> tag of the accessor
XML. TODO: Always show this text in the applet, instead of
"data by: XXX"

Add support for exceptionally added availability of transit services

- This implements support for GTFS exception_type=1 in calendar_dates,
which adds one day of availability to a transit service
- Also change date comparison operators to BETWEEN .. AND

Improve error handling, progress reporting, non-blocking import

- Report progress/errors of importing/downloading GTFS feeds through
the data engine to visualizations
- Add optional <timeZone>-tag to accessor XMLs, can be used to define
a timezone to use, if none is given otherwise. Used by GTFS accessors
if the imported feed doesn't include timezone information in
agency.txt (although required for valid GTFS).
- Create new class GeneralTransitFeedDatabase, which manages GTFS
databases
- Do importing of GTFS feeds in a separate thread to not block the
whole data engine and thus whole plasma
- Check required files in GTFS feeds before importing them
- Check minimum records for GTFS feed files (eg. at least one stop)

Add GTFS import test, fix calendar table

- Use Google's sample GTFS feed for the test
- Fix 'weekdays' field in calendar table, which combines GTFS fields
'monday'-'sunday' into a string of 1's and 0's
- Fix conversion of dates to be stored in the database. It now stores
dates as strings, storing QDates directly does not work
- Fix target directory for extracted GTFS feeds, ie. do not use the
path of the zip file for the directory name, which may include double
dots and thus change the path away from /tmp
- Fix filling missing fields with invalid QVariants in
GeneratTransitFeedImporter::readFields() (if => while)

Make the tool factory configure the tools whenever they are created already

- Make all the constructors of tools protected so that only the factory can create them
- Connect the tool signals in 'quickpreview.cpp' correctly, which fixes the quick preview
- Improve the implementation of starting the 'archive' tool

Add GTFS importer and accessor

- The GeneralTransitFeedImporter imports GTFS feeds and writes the data
with little changes into an SQLite database, eg. using integer IDs,
insead of strings. Importing the data may take some time to complete,
the data engine should report progress here (TODO)
- Add reading of "<feedUrl>" tags to AccessorInfoXmlReader, contains
the URL to the GTFS feed for GTFS accessors. Currently that URL is
stored as DepartureRawUrl, but with new getter/setter functions
- TimetableAccessorGeneralTransitFeed uses the database to get
timetable information. If the database does not exist, it downloads
and imports the GTFS feed (new <feedUrl> tag).
It overwrites TimetableAccessor::requestXXX() functions instead of
::parseXXX() to directly return data from the database, no need to
wait for a download to complete

Update TimetableAccessor, accessor types, add DepartureTime enumerable

- New AccessorType enumerable for the coming GTFS accessor, renamed
other enumerables (now all end with ...Accessor)
- Require a pointer to the used TimetableAccessorInfo object in the
TimetableAccessor constructor, because it's always needed and would
actually crash if it is not set by derived classes
- Remove return values from TimetableAccessor::requestXXX functions,
not needed and the GTFS accessor will work without network requests,
therefore it will not create a KIO::StoredTransferJob.
Make these functions virtual, so that derived classes can do
something else than download a document
- DepartureHour/DepartureMinute values are used to create a
DepartureTime value, if it is not available
(same for ArrivalHour/ArrivalMinute)
- DepartureTime, ArrivalTime can be used with second information
- Will be used for GTFS, which can include seconds in time values
- Used by the XML accessor (de_rmv), to store the time as QTime object,
but without seconds
- Update DepartureInfo/JourneyInfo::generateHash functions in
libpublictransporthelper to include seconds

optimize: don't restart quickopen model twice

generally, I think this should and could be optimized even more
right now e.g. the include path model (kdevelop/languages/cpp)
is quite slow (easily ~150ms and more on my machine) to restart,
most notably because of CppUtils::allFilesInIncludePath

make AlphaBlending an alias to OverpaintBlending

The overpaint blending has the same effect as the alpha blending, but is faster.
Therefore, bye bye alpha blending.

Treat UID substituting KCMs as external apps

When a KCM desktop file has set:
X-KDE-SubstituteUID=true
Systemsettings now handles it as if it were an external application.
Rationale for this is that there are some KCMs that still require
to be run as root for whatever reason. While those KCMs should
really provide an externalapp desktop file and not be KCMs to
begin with, they would have to have two identical desktop files
(except for X-KDE-ServiceTypes and X-KDE-ParentApp) which does
not seem worthwhile. Instead whenever substitution is defined
we treat them as if they were actual external apps.

Also this change, along with the KRun change to externalapps,
now allows distributions to drop their X-KDE-RootOnly patches
and simply use X-KDE-SubstituteUID.

First step to optimize collection deletion.

Reduces number of queries per item in a deleted folder by 2 and prepares
the code for moving more operations out of the O(n) part. Which would
actually be easy if Sqlite would support joins on DELETE queries, as
MySQL does :-/

Envelope is enough for deciding what to expire.

This should prevent KMail from downloading my spam folder from the IMAP
server once a day, and reduce memory usage during expiring by about 90%.

reimplemented renumbering of footnotes

Improve adblock

improve adblock docs
check third-party option before (faster)

Remove just the last organization and application name, not everything



Using chop is a better approach if we are about to remove certain string values
from the end of another path string. It cannot be broken by any install path
this way coming from the build system. As of performance, it is even faster
since it does not need to look up the substrings this way.

Along the way: I also fixed the place the slash where to add it to the string.
The concern is that here, paths normally return the directory path without the
leading slash, and that is actually how this API has been designed and used by
the API users heretofore.

KRun ExternalApps rather than QProcess them

This has the advantage that advanced desktop file magic like
X-KDE-SubstituteUID and X-KDE-Username will be honored as
exepcted.

Also cleaned up the includes a bit.

be sure to include ALL role names

some dataengines can have a different set of keys for each item (ie metadata dataengine) the whole mapped roles must be the complete superset
this is not very efficient, but unfortunately is necessary.
(another reason why DataContainers should become models)

Make sure we always use the part id for creating part file names.

This was found by the new overlapping part checker and seemed to result
in a <0.07% chance of having a part overwrite the file of another one.
Since this will not be written back to the resource normally, the actual
risk of data damage is probably even smaller.
(cherry picked from commit add06052104974356404a0eccf09dc1c21325b0c)

Don't skip the last line in an Mbox file.

Usually you only have useless boring legal disclaimers there, but maybe
someone actually wants to read that, so better keep it around, for
completeness.

Resolve build trouble (OSSv4 vs OSSv3)

Reverse direction on horizontal QWheelEvents

Send an interesting User-Agent header because usage metrics are cool

First refactor of MainWidget class. So far, only avatar handling code was moved out to a separate class and bunch of slots were moved and/or renamed.

Reviewed-by: David Edmundson
REVIEW: 102584

Temporarily disble few connections to non-existant slots/signals. This kills the errors in console output and apparently everything still works. I plan to do a review of the overlays so if I'll find out these are indeed not needed, I'll remove them for good.

Install chat-ui and adiumxtra-protocol-handler in libexec.

Huge konquest refactoring.
I aknowledge this overwrite some Jeffrey Kelling's patches, I'm going to port them to this 'new' Konquest.
For more information about this rewrite, see http://blog.pinaraf.info/2011/09/konquest-it-is-alive%E2%80%A6/
Basically : huge refactoring of the game to make it more maintainable, and open the door for improvements later

Replace the Brazilian debug messages into proper English expressions

It is a Rocs left-over, so it can safely be removed. Once, it even made sense to
eliminate the Brazilian debug message, and just use Q_FUNC

KSecret file serialization logic rewrite

Abandoned the parts format
A special device is introduced allowing custom reads/writes
All the encryption logic moved into a dedicated class
KSecretEncryptionFilter
All tests pass but information is stored unencrypted for the moment.
This is for debugging reasons. I'm now working on the encryption filter.

Also, the daemon jobs switched to KCompositeJob