Issue 210

Make the link in a message box in review board plugin work
REVIEW: 103139

properly initialize client context for compatibility with subversion API

this should hopefully fix the crash with svn 1.7 in kdevelop, please test

correctly do spellcheck when accel is _

Fixes: The arab and australo-asian people want satellites, too!

Prior to this commit satellites only appeared on the western
hemisphere due to non-normalized longitudes fed into
GeoDataCoordinates objects.

Fix crash in moon phase almanach

1. Read Moon images from texture manager
2. Store array of pixmaps instead of array of pointers to pixmap
and avoid manual memory management entirely.

Remove secondary shortcut Shift+Del from Cut action, so that Delete permanently can work

Fix repainting for repaints with small regions

Makes this statement similar to the one that uses pe->rect() instead of pe->region().rects()

You can test it by:
* Opening a document with okular
* Scroll down a bit so that you are not on the top of the viewing area
* Open the review tool
* Move the review tool around
* See how it leaves unrepainted garbage
* See how this patch fixes it
(cherry picked from commit 9f654a0029976965024a09bf3c095f9f07d031cd)

make transparent copy/paste and transparent text writing work again

Fix "Changing positions does not enable Apply button"

We had two identical bug reports ... therefore, we got two review
request... Closing both.


REVIEW: 102631

See also:

REVIEW: 103093

Guard against use of NULL pointers.


FIXED-IN: 4.7.4

(cherry picked from commit d5675e5850b1d25d55c9482ed8deff712b9bcc6f)

don't ::updateRules() in ::updateActivities()

breaks remember rules when called by ::setActivity() in ::manage()
TODO: add activity rules and make remember state applying more robust in 4.9

unify source names, it might confuse the battery plasmoid when devices get added/removed

(possible fix for https://bugzilla.redhat.com/show_bug.cgi?id=753429)

don't crash, but rather exit, if the keyboard plasmoid is unavailable

Do not crash when setting maximum number of items to something smaller than the number of default items.

Delete the OntologyLoader once the repository goes down.

This is required to make sure the ontology loader does not try to use
the repository while it is being re-opened and thus, does not work
(even asserts on queries).

FIXED-IN: 4.7.4

Remove "Rename inline" option

The new view-engine currently does not support inline-renaming
and because of more important pending issues this cannot be
implemented for the 4.8 release of KDE applications.

The plan for 4.9 is to implement inline-renaming again and
to make it "so good" (tm) that it is always turned on (-> there is
no need anymore for an option to disable it ;-)

Changed the default shortcut key to CTRL+SHIFT+S to avoid conflict.



FIXED-IN: 4.7.4
(cherry picked from commit d800e027f994dccbe7089a306a42d2bff4e193ce)

Fix keyboard layout global shortcuts

use contentsrect to calculate window size if baseUnit isn't 1,1

Make the swap disappearing issue more robust.

Before there was some questionable logic surrounding the swap detection
code. Make this logic more understandable and robust. This should fix
random resizes that occur for some people.

FIXED-IN: 4.8.0

Set pointer to 0 after deleting.


(cherry picked from commit 5e6e56e5249d1f0215b59d798e27b09b15d44fbc)

Check pointer for NULL before use.

Move SessionSwitching into declarative plugin

SessionSwitching becomes a reusable component which handles all the
interaction with the underlying session handling by itself. No need
any more for exposed properties or context properties.

Fix crash when toggling the menu-bar visibility

Use a queued connection to prevent that the menu
gets hidden during it is still open. Thanks to
Christoph Feck for the hint!

Frank and I could not reproduce the issue in our
environments even when following the steps from
bug 278366, however Christoph's hint sounds sane
and let's hope it works (leaves a bad gut feeling
to "fix" bugs without being able to verify them).



FIXED-IN: 4.7.4

Improve dragging pixmap

When dragging multiple files, those files should be shown as part
of the dragging pixmap like in Dolphin 1.7.


FIXED-IN: 4.8.0

Prevent crashing when dumping binary files to terminal.

"cat"ing binary files often crashes Konsole. This patch checks the
indicies.
Note that there are tons of 'undecodable sequences' that also print
out. These likely should not be displayed unless debugging.

FIXED-IN: 4.8

Fix issue with the system/cores value not being received.

The systemmonitor data engine is 100% asynchronous. Unfortunately this
makes polling any source impossible. This caused a hard to pin down
bug related to certain cpu sources not being connected. To correct this
the system/cores value is now properly polled. This should avoid/fix
any issues with 'show usage of all processors' option.

FIXED-IN: 4.8.0

Avoid potential crashes by using a QWeakPointer to store the reference to the
broweser KPart.


FIXED-IN: 4.7.4

(cherry picked from commit 8c33c21e3382febf8a04713c7f6f975bb74cd8a3)

In sendBody if the specified content-length is 0, then simply return without
any attempt to obtain data to send to the server.

Prevents potential crashes in the screwed up client code. See bug # below.

Delete the OntologyLoader once the repository goes down.

This is required to make sure the ontology loader does not try to use
the repository while it is being re-opened and thus, does not work
(even asserts on queries).

FIXED-IN: 4.7.4

Workaround brain dead clients that set the username and password of the
request URL to "undefined".

Do not crash when QNetworkRequest::ContentLength is either 0 or not specified
for a PostOperation.

Filter out collection when listing items
(cherry picked from commit 4cc4a63e55900cc1eabb685ea38a864287344a73)

In mailkernel, create a new method kernelIsRegistered() that says
whether or not the interface dealing with the mail settings has
been registered yet.

Then, in KMail::IdentityPage ctor do not attempt to access the
IdentityManager unless the mail settings interface has been
registered; since the IdentityManager lives in that interface.

This allows one to use the Kontact configuration dialog even if
KMail is not loaded.


MERGE: 4.7

Event crossing month bounderies wasn't being shown.

Patch by Reimar Imhof.

I changed it a bit and replaced downcasts with date roles.

Fix Bug 286889 - Move Thread to Trash Context Menu

FIXED-IN: 4.7.4

Fix Bug 276343 - Incorrect message is displayed when move of messages to trash and elsewhere is completed

FIXED-IN: 4.7.4

Fix Bug 286875 - Redirected email is stored in wrong sent-folder

FIXED-IN: 4.7.4

Fix Bug 286922 - edited mail from outbox deleted after closing

FIXED-IN: 4.7.4

Fix date value when date was selected

When the date is selected and the Key_Return/Key_Enter pressed, the value in the
QLineEdit is set to the value of the first item in the QCompleter, here "friday".

To fix this issue, we deselect the date when the Key_Return/Key_Enter
are pressed.

Fix Bug 286663 - Kontact crashed when canceling creation of sieve script

FIXED-IN: 4.7.4

Hide tag editor if nepomuk is not initialized

add a crash and sanity check in removeChild() in case the child map
is empty or the specified item to remove is not in the map.

might fix bug 258080.
but can't know for sure since I can't reproduce.
appreciate testing by those affected by the crash.

Fix Bug 278060 - Mailing list detection does not work

FIXED-IN: 4.7.4

Make GetQuotaRootJob more robust to accept different responses and fix some bugs in it.
Create a unit test for GETQUOTAROOT.
Based on patch by Lukáš Krejčí.


REVIEW: 103150

Fix update bug for moving nodes

Modified KisFullRefreshWalker to calculate change rect of the nodes
in right way.

See comment in KisFullRefreshWalker::changeRect()

fix saving quadratic bezier curves

quadratic bezier curves need to properly converted to a cubic
bezier curve to be written out (at least odf does not understand
quadratic bezier curve, which sucks)
the old code attempted to do a very naive conversion to a cubic
bezier curve, which was wrong.
Fixed by using the correctly working KoPathSegment::toCubic function
to do the conversion.

Fix handle multiLvlStrRef (a multidimensional stringlist) in the category-definition.
This fixes quit a bunch of 2007 issues where we completly
ignored the categories.

Fixed updating after crop in QPainter canvas

Fixed createDataSetsFromRegion, labelRegion and categoryData.

* Fixed createDataSetsFromRegion

The way we where dealing with multi-dimensional cell regions, means cellRegion.width()>1 %% cellRegion.height()>1, was wrong. That could lead in us completly ignoring complete rows/columns.

1) proper sorted either from left-to-right if the dataDirection is Qt::Horizontal or from top-to-bottom when Qt::Vertical.
2) have multiple dimensions proper split-up into single rows/columns to produce one DataSet per row/column.

* Fixed labelRegion

1) Fallback to internalTable for labels.
2) Fix random index-number fetching caused by using depending on a proper value for dataSetNumber to calc the labelRowCol index offset.

* Fixed DataSet::categoryData to return the expected category-data for multi-dimensional cell regions.

* Use table:table-columns and table:table-header-columns to set the number of columns to a minimum rather then ignoring such definitions.

* Guard against multiple table-header-rows definitions in the XML that could end in us dealing with wrong header vs data offsets.

BUG: Better default size of the "category" panel in the split table to avoid manual resizing

: Renaming categories doesn't rename relevant search/process rules (not fixed but better error management)

Update reports automatically when schedule changes

Fixed lines appearing on a canvas on non-integer zooms

This happens because for scaling we may need some areas outside
current update rect. And these external areas may not be prepared yet
by other threads. So our current thread reads empty (not-yet-updated)
areas and uses them for scaling. This causes while lines.

Now the problem is solved like it is solved in
KisLayer::needRect/changeRect. The update, updates it's own rect, and
small adjoining areas around which depent on it, that may be called
"changeRect". Then the patch (KisImagePatch) requests even more pixels
to make the scaling right (that may be called "needRect").

repalced wpd/wpg/vsd import filter with writerperfect, added microsoft works document import filter, added WriterPerfect as new dependency, removed depency LIBWPG, WPD remained for wpd export filter

Make ora work with calligraconverter

The ora importer used KisImage::resize to resize images after loading
all the layers. This broke when KisImage::resize was ported to the
strokes framework and actually became an asynch crop+resize implementation.

Somehow, the resize never finished when run in batch mode, which meant
that subsequently the png export couldn't even start.

Better fix for the text-shrinking logic for pie-charts in KDChart.
The whole logic was flawn by design so I had to rewrite it. Results look pixel-perfect now.

Don't create multiple rollback records in case the same object
gets modified more than once during the same transaction. Keeping
the state before the transaction started once is enough.

EMF: Fix bug 286713: EMF: Crash: Assert "0", EmfOutputPainterStrategy.cpp

The reason for the crash were unnecessary ASSERT(0) in
SelectStockObject. I removed all asserts there and made sure that a
font was always selected. So no more crashes for stock objects, at
least.

Fix don't recalc during loading just because a sheet got added.
This makes loading the HeroForge_V6.1.0.1.xls from
bug 284325 by a few *factors* faster.

Fix 'whole column' and absolute definitions in Excel formulas.
Excel allows to define a whole column in a cell-region like "A:B" whereas that is not possible in ODF. So we need to translate that to something like "A$1:B$65536" to be sure the proper cells are evaluated in Tables.

This fixes the VLOOKUP problem visible in the document attached to bug 284601 but was a more general issue not related to only one formula but to all Excel formulas that where using such 'whole column' definitions.

Also it should fix a few cases where we did not proper evaluate absolute vs relative column/row definitions.

QA done with cstester and unittests.

read layout direction from xls files, now all the rendering bugs in RTL just need to be fixed...

Fixed a bug in the KisUpdateSubtreeWalker

If we update a subtree with some root, we should not write
anything into the root's projection. We use N_EXTRA type of
"dirtiness" for that.

Workaround for a scaling bug in the canvas

The line at the bottom-right corner appears due to different
behavior of QPainter while scaling. Added a workaround and reported
a bug: https://bugreports.qt.nokia.com/browse/QTBUG-22827

Fixed crash during MusicBrainz search.

FIXED-IN: 2.5

Fix audio CD detection on Amarok start

Get a list of optical discs, rather than looking for optical discs in
StorageAccess devices.
This does not fix other audio CD issues such as "play audio CD with Amarok" not
working.

Patch by Luc Menut.



REVIEW:102580

Update icon as per choosen profile when a new account is added

Reviewed By : David Edmundson and Martin Klapetek

Use correct slots for blocking/unblocking contacts

Prevent connection activation from freezing plasma-desktop for a few
seconds.

Hide chunkbar when download of stream is complete

Reload config and secrets when changing EAP method for WPA2 TTLS wifi
connections.

Fix creation of Bluetooth PAN connections.

NM refuses to add Bluetooth PAN connections if they include settings for
Gsm, Ppp and Serial configurations. On the other hand those settings are
required by Bluetooth DUN connections. Because of the way our internal
libraries are coded it is not that trivial to check the correct type
(DUN / PAN) before creating a connection, so I am removing the unneeded
settings when creating / editing a connection.

check that parent groupbox is registered to engine before rendering groupbox
background.

Discard pending changelog fetch jobs before cache reloads. This prevents changelog jobs
finishing when the QApt::Backend is in a state where package pointers are invalid.

Fix signal/slot connection between import dialog and query engine.

Set signals between worker thread and QueryEngine as direct
connections.
Set signals/slots between QueryEngine and the import dialog as queued
connections.

Signed-off-by: Riccardo Bellini

Compile against updated libgit2 API

* All object setter functions removed
* Single-function API to create objects shall be added

Connect routing UI options (motorcar, bike, pedestrian) to the model.

Kinetic spinning for Marble (by Ariya Hidayat).

Now Marble behaves even more like the globe on your desktop.
Thanks for the patch, and sorry for having it sit in svn.reviewboard
unnecessarily long.
REVIEW: 6171

Add a 'space view' activity.

Defaults to showing a globe with satellite theme, options to enable
clouds and satellites as well as switching to other planets easily.

add Kodak HIE infrared filter to the list of B&W analog films simulated by digiKam black and white Image editor converter.

Ratio Crop Tool is now able to display Histogram from selected region to crop

Aspect Ratio Crop tool : new section to display crop information. Currently resolution of cropped image in Mpx

Apply patch #65631 to prevent Overexposure with Withe Balance adjustement.
Modify patch to always compute RGB multipliers over original image in case of preview rendering in image editor.
Use more private internal container plus code polish

Support Plasma Active lockscreen

A new config option is added to specify the main qml file used
by the greeter. The Active lockscreen qml is imported and works
together with the greeter.

Add session switching to Plasma Overlay

UI for setting start page, adblock and history

Only half-kinda-works, but good progress. It currently writes to the
wrong configgroup, that's something to be streamlined in the
webbrowser's config, or we just use separate objects for the different
config groups.

Add ActivateAnimation to mobilecomponents plugin

Animation itself is not very good yet, but allows us to steer this in a
central place.

switch pages with a drag gesture

Support for Caps Lock warning in Greeter

Same event filter needs also to be installed in the Plasma Overlay.

massive step towards QGraphicsView being separated from libplasma

* remove extenders (never panned out, used by exactly two components that we can find .. anywhere)
* move animations to libplasmagqv
* schedule js anims to be put into the js scriptengine
* move all QGraphicsProxyWidgets, except for IconWidget which is still used by PopupApplet, into libplasmaqgv
* create a subclass-able private class for Applet

TODO: move out icon widget, address FIXMES in graphicswidgetappletprivate.cpp and decide how to register the "right" private class for instantiation in Applet ctors

Pretty resize RenameDialog form to show more information

Several fixes to make RenameDialog look prettier and show more
information if it's possible.

What's done:
- new private slot added to resize information scroll area after
metadata for items is fetched
- preview job is deferred to the moment when metadata is fetched
to show it a little bigger according to updated size of metadata

REVIEW: 103160

Add support for multipart/related messages

Add support to templateparser for handling inline images.

visualimagecompare: support for viewing PDFs

We generated PDFs for almost every document in our document pool.
Now, this patch allows us to display them directly in visualimagecompare.

Usage :
- launch visualcompare with the --pdf /home/of/pdfs option
- key P will switch from/to the PDF view
- buttons +/- allow to navigate in the PDF (if there is an offset between
the pages we generated and the PDF pages)

If you want that feature, you must compile visualimagecompare with poppler.

docx: paragraph/text styles inheritance Kung Fu

* Let's set line-height=100% in the default paragraph style if the corresponding part
of the w:spacing element is not provided.

* Do not interpret a default named style (w:default attribute in the w:style element)
as additional information for the defaults. The "Normal" style for example on top
of the defaults was applied to any paragraph which was not correct. Then finally
the corresponding style referred by a paragraph was applied. So the "Normal" style
messed up the formatting.

* Any paragraph and text chunk that does not provide the style information should used the
corresponding default named style (w:default attribute in the w:style element).

* paragraph/text styles for footnotes/endnotes belong into content.xml, not styles.xml
and also make use of the default named styles.

* headers/footers also make use of default named styles.

More work on the auto color.

It should work now - famous last words..

Added setHeader method to svgwriter to add a customized header according to application creating the svg

docx: Write text-properties only in case of empty paragraphs.

* From MSWord point of view the text-properties in a paragraph style are meant for
the paragraph mark and should not be used to format any of the text chunks.

* text-properties of the paragraph mark are used to format the list label, so they
are part of the inheritance hierarchy, which I broke at the moment.
I will fix it ASAP.

* Sync with the DOC filter.

Use calendar popups for all datetimes

Add and use new multihand icon

Icon created by Animtim

Let's support embedded fonts too ! Have fun showing off at the plugfest :)

Create a command for inserting an inline object

Inserting inline objects was not undoable. Creating a shape was. Undoing
the creating of shape without undoing the creating of an inline object
that refers to the shape, like an anchor, leads to crashes when the
undo action command gets deleted.

let history, bookmarks and passwords sync on change (first bits)

add global presence message

NetworkPropertiesDialog refactoring.

Removed right panel and added Extended Away status

Added extended away support

Suspend/resume queue when middle clicking on tray icon

Use dialog-less setup for link-local xmpp (salut)

Reviewed-by: Dario Freddi
REVIEW: 103117

Display the balance of a budget. I would have liked to have this information several times while creating a budget.

REVIEW: 103134

enable hover effect on sunken scrollareas that supports focus.

Use the RPM support detection code from f8a2d09 in master.

*sigh* It looks like in the conversion from svn to git the changes to
FindLibArchive.cmake in SVN r1209188 which defined LIBARCHIVE_VERSION
were did not make it to git.

This means the version check always failed and Ark always thought
libarchive did not have RPM support...

Improve positioning of the message widget

The popup message widget is now centered both horizontally and
vertically over the image preview. The WidgetFloater class has been
borrowed from GwenView.

Props to Aurélien Gâteau for writing the class and suggesting to use it.

Placing libksecretsservice in the ksecrets repository

See the kde-core-devel for context information about not putting this
into the kdelibs branch 4.7.

The code was reviewed by Albert Astals Cid and by Kevin Krammer at
the time it was in kdelibs.

Workaround QtWebKit's propensity to emit the loadFinished signal multiple
times causing kwebkitpart to unnecessarily perform rather CPU intensive
actions like filling forms on a page over and over again.

Writing of config entries entries

When writing an entry, a 5 second timer is started until the config is
synched, this also compresses multiple config changes in quick
succession into one sync event.

This seems to work quite well already for clearing the browser's history
and enabling / disabling adblock. The webbrowser doesn't correctly
reload history while running, it reloads but reads the old config
apparently, so the history isn't cleared until restart.

Better duplicate merging in storeResources

This is an inefficient way of doing this, but it's better than not
having duplicate merging at all.

The problem is finding duplicates in the graph provided when those
resources do not already exist in the repository. Previously, we
used to hash each of the resources, check for duplicates, and then
merge. Then we would perform the whole identificiation & merging
code.

This suffered from the draw back that it would not recognize
duplicates of the form -

:a a nco:Contact ;
nco:fullName "Peter" ;
nco:hasEmailAddress :b .

:b a nco:EmailAddress;
nco:hasEmailAddress "" .

:c a nco:Contact ;
nco:fullName "Peter" ;
nco:hasEmailAddress :d .

:d a nco:EmailAddress;
nco:hasEmailAddress "" .

Here :d and :b would be found as duplicates, but :a and :c would not
as their nco:hasEmailAddress property is different, and therefore
the hash would be different.

This has been solved by looking for duplicates multiple time. So, the
code is something like this -

do {
// Look for duplicates using hashing
// merge the duplicates

} while( there are duplicates );

// continue with the identification and merging process

Also added a unit test.

add a crash and sanity check in removeChild() in case the child map
is empty or the specified item to remove is not in the map.

might fix bug 258080.
but can't know for sure since I can't reproduce.
appreciate testing by those affected by the crash.


(cherry picked from commit f8c0f7eed9fa980ad31856d28266c2612e994cf0)

Don't try and embed remote images

Don't wrap all parts in <p></p>

Handling the fact that qt insists on having a paragraph in front of tables.

The solution is not to try and remove it (because we can't) but to make
sure there is always an extra empty paragraph in front of a table. The paragraph
is sort of hidden and only shows up as a cursor position to the left of the table

Qt 3 support gone

Merge branch 'master' into libs-connectionrouting-yue

Remove the optional dependency on libxine from kdemultimedia.

r1253879 made Dragon libxine-free, and nothing else depended on it.

REVIEW: 6826

Don't block the UI while scanning UMS device.

BookmarkProvider --> BookmarkManager

We have 7 managers and 1 provider... finally fixing this strange
thing!

Adblock disabled by default for 0.9

This was an initial misconception on adblock use (moreover considering
it is our worst bottleneck...)
If you wanna it, just enable it on your own...