Revision 79bd9a7...

Go back to digest for 4th December 2011

Optimization in Multimedia

Matěj Laitl committed changes in [amarok] /:

Fix infinite loop in context view eating CPU until main window is shown

We used to use _scene_ sceneRect in
VerticalToolbarContainment::updateGeometry() to update applets and
geometry, but that leaded to infinite loop (across mainloop) -
m_applets->setGeometry(), refresh() would enlarge _scene_ sceneRect by
a few pixels which would trigger updateGeometry() and so on...

We now use _view_ sceneRect to update geometry. Rick W. Chen discovered
some glitches in applet collapsing when this patch is applied, but he
has a patch for that in the works and this is more serious problem, so
pushing this.

REVIEW: 103271

FIXED-IN: 2.5

File Changes

Modified 2 files
  •   ChangeLog
  •   src/context/containments/verticallayout/VerticalToolbarContainment.cpp
2 files changed in total