Revision 015880b...

Go back to digest for 29th January 2012

Bug Fixes in KDE Base

Vishesh Handa committed changes in [kde-runtime] /:

Check the modification time before reindexing files

The modification time was always checked, but only when a directory
was sent for indexing. The analyzeDir function would check for files
as well. This worked fine the cases where the Indexer would routinely
check and re-index files.

It however didn't work so well in the cases where the file watcher
told the indexer to reindex a file cause of a inotify event. Specifically
CloseOnWrite event, which are emmited when a file opened with "r" mode
is closed. Even if modifications aren't made.

Applications like Amarok and KTorrent routinely open files in "rw" mode
even when they don't have to make changes. Those files used to get

REVIEW: 103794

File Changes

Modified 8 files
  •   nepomuk/interfaces/org.kde.nepomuk.FileIndexer.xml
  •   nepomuk/services/fileindexer/fileindexer.cpp
  •   nepomuk/services/fileindexer/fileindexer.h
  •   nepomuk/services/fileindexer/indexcleaner.cpp
  •   nepomuk/services/fileindexer/indexscheduler.cpp
  •   nepomuk/services/fileindexer/indexscheduler.h
  •   nepomuk/services/fileindexer/nepomukindexer.cpp
  •   nepomuk/services/filewatch/nepomukfilewatch.cpp
8 files changed in total