Revision c8913c3...

Go back to digest for 29th January 2012

Bug Fixes in Utilities

Raphael Kubo da Costa committed changes in [ark/KDE/4.8] kerfuffle/queries.cpp:

queries: Consider an empty password as a request cancellation.

Empty passwords do not make sense as valid passwords (infozip, rar and
the 7-Zip on Windows do not create archives with empty passwords, for

Calling Query::setResponse(false) when an empty password is passed
makes the code in CliInterface consider the current action has been
canceled, as if the user has pressed the Cancel button in the password
query dialog, and not pass a single newline in password queries.

Even though the related bug report can also be considered to be caused
by PasswordPromptPattern not being defined for the clizip plugin and
CliInterface::handleLine() not checking for password prompts in Copy
mode, this commit has the advantage that the user is not prompted twice
for zip files if she enters an empty password the first time.

The user should be informed that the action has been canceled, but
this can be done in a separate commit.

FIXED-IN: 4.8.1

File Changes

Modified 1 files
  • kerfuffle/queries.cpp
1 files changed in total