Issue 221

Fix two bugs with type support

1: foo = 3, 5 would not give a tuple, now does
2: all member functions which should return stuff depending on the content
type of a list or dict didn't work, no those that are supposed to do
(iteritems() for example)

Make sure the list of datasources has enough vertical space, and make room for the filenames (450 pix width, resizeable).
There is one issue left but it's more difficult to solve: when you add datasources while the dialog is open, it does not get updated. In this case you have to close and reopen it.

Don't crash when tile creation fails to create (write) images.

RevBy: Bernhard Beschow

Brief explanation of "open files" and crash fix

Added a short text describing the function to open image files. Sanity
check added for the file name to prevent crash on Id mapping if image is
from outside KPA pic root.

Make sure svg images are not considered to be raster images


FIXED-IN:2.8.1

Fix optional PAM support, patch by Michael Palimaka

REVIEW:103818

Fix crash in Compact View if view height is smaller then item height


FIXED-IN: 4.8.1
(cherry picked from commit f5ecaee9c40c940fe8e1bf4a7d50fe0b18e1932b)

Adjust zoom-slider in the statusbar if settings have been changed

This fixes the issue that changing the zoom-level in the settings
does not update the zoom-slider in the statusbar.

Fix crash when opening a tab during a tooltip is shown

Thanks a lot to Mathias Tillman for finding a 100 % reliable way
how to reproduce the issue and for the initial patch!


FIXED-IN: 4.8.1

When creating a new bookmark folder, prompt for the folder name.


FIXED-IN: 4.9.0
REVIEW: 103845

- Fixed invalid HTML.
- Added two more test case for a disabled textarea and a disabled spellchecking
textarea.

Apply changed home-URL to the URL navigator


FIXED-IN: 4.8.1

little delay to the deletion

prevent a crash when the qml root object is deleted with a job running:
it should be enough any delay more than two loops

Fix sorting issues

For some roles the sorting has not been implemented.


FIXED-IN: 4.8.1

Fix drag & drop issues with non-local URLs



FIXED-IN: 4.8.1

Adding eDP port as "laptop port" just like LVDS

eDP are just like LVDS but more modern, so they should be
considered as a laptop screen and inhibit when only it is
available.

This will fix the inhibition problem probably for the rest
of the affected users.

amichair thanks for the debugging :)

If kernel newer than 2.6.36 use the backlight type instead of whitelist

If the kernel is newer than 2.6.36 it indicates the type of the
backlight wether it is a firmware/platform or raw. We should
attempt to connect to these interfaces in this order.

This should fix any compatibility issue we have right now and make this
code comaptible with drivers that may appear in the future.




FIXED-IN: 4.9

Fix sorting issue when sorting by "size"

Root cause of the issue was an overflow in:
result = a - b;
where result is 'int' and a and b are 'KIO::filesize_t'.


FIXED-IN: 4.8.1

properly map rblk and wblk in and out of canonical form

the config dialog now loads and saves properly. also, i don't think
the write I/O was being read properly or at all. so now that's fixed as
well.

looks like it works on a desktop quite well, so it's nearly done, just
have to fix and test it when it's in the panel

Fix pending zooming animation

If doLayout() is invoked with the 'NoAnimation' hint, it must be assured
that any ongoing animations are stopped.

Set up the sorting and filtering in the popup view according to the parent icon view settings.

REVIEW:103851

Make sure the user's preference to show or hide the close buttons takes effect
as soon as the changes are applied. Not after restarting Konqueror.


FIXED-IN: 4.8.1
GUI: Removed portion of a tool tip text that is no longer valid.
(cherry picked from commit 2f63fe74e513580879cde3d4678d8268bd91da52)

Make KSMButton's height follow desktop font's point size.
Fixes bugs #216853, #175284.

Replace setExpanded(const QSet<KUrl>&) by expandParentItems(const KUrl&)

The use case of this function (Folders Panel) requires the expansion of
the parent items of a single URL, so it's not needed to handle a full
set of URLs in this function. Moreover, the issue that not only the
parents, but also the URLs themselves were expanded is fixed by this
commit.

Explicitly set the time component of the entered birthday to invalid.

The QDateTime constructor sets it to midnight if an invalid time
is specified. This persists throughout the storage and export, and
creates vCard files that GMail and Android fail to read.


REVIEW:103776
FIXED-IN:4.8.1

in setCollectionFullPath(), don't try to get the fullCollectionPath
from the Akonadi::Collection specified unless we have collectionModel
in the kernel.


MERGE: 4.8
FIXED-IN: 4.8.1

Fix enable/disable treeview

in some cases the itemsyncer is turned-off, so check for that
in itemsRetrieved and other places. avoids crashes.


MERGE: 4.8
FIXED-IN: 4.8.1

Fix Bug 293122 - synchronizing when selecting folder does not work

FIXED-IN: 4.8.1

save/restore the last used filename, sorting order and printing style.
Patch by Mario. Thanks Mario, keep the patches coming!

REVIEW: 103696
MERGE: none

Fix Bug 292869 - going to new message does not restore window

FIXED-IN: 4.8.1

in createDavItem(), if the DavProtocolAttribute is 0, then we can't
get the mimetype for vcards from the DavProtocol. In this case,
assume the mimetype is the KABC::Addressee:mimeType().


MERGE: 4.8
FIXED-IN: 4.8.1

Fix mem leak mailfilter was not deleted
(cherry picked from commit 1d5e87c5dc51ef79874cae8adb38e825975bbb2b)

Conflicts:

mailcommon/filterimporterexporter.cpp
mailcommon/kmfilterdialog.cpp

Fix "Bug 293138 - Marking a Mixture of Read und Unread Messages" (need

kmail too)

It fixes and other bug (don't remember) when user try to add shortcut
for an action but it changed name so it was not logical

FIXED-IN: 4.8.1

If we use transactions, then we need to remember to commit them!
With this fix, the new logic is starting to come to life - though
at present, it creates duplicate entries.

We might also be able to do without transactions anyway...

further zotero sync changes, fix some bugs

Fix crash when trying to save custom equalizer presets.

This also improves the UI a little bit (deactivates unusable buttons).

Also it prohibits saving a 'Manual' profile in non-english versions.
Overwriting default presets still doesn't work in non-english versions, though.


FIXED-IN:2.6

Fix failure to rip CD tracks with special characters in their title

Certain characters such as ? have a special meaning in URLs so they have
to be encoded when used in path component, but the AudioCdCollection
fails to do so and just embeds the raw track title into the URL. Thus it
is impossible to rip tracks that contain such characters in their title,
as the URL passed to the KIO subsystem is invalid.


FIXED-IN: 2.6
REVIEW: 103841

Another approach to fix bug 291068, be more permissive

Bart originally solved the bug by enabling track dropping only
precisely on root collection rows. This is IMO too much restrictive
as it prevents you to drag tracks between 2 large expanded collections
without excessive scrolling. (something I would miss) Additionally,
there was no visual indication that the drop will not be performed.

This is my try to rework it in a way that:
* keeps drops onto artists/albums (whatever you first level
entity in collection browser is) allowed. There is a drop indicator
that clearly shows that the drop will go _between_ the entities, not
to them.
* disables drops to read-only collections
* disabled drops are indicated visually using the not-allowed mouse
cursor (the tricky part, but commented well in code)

Some more code comments not present in review request are added.


REVIEW: 103856
DIGEST: More natural drag'n'drop behaviour in collection browser

Don't accept drops on non-collectionheader items.

Caused the copy dialog to come up.


FIXED-IN: 2.6

UmsCollectionLocation: cleanups, corrections, fixes

This fixes UmsCollectionLocation to be on par with Amarok standards.
This is the first part of making the USB Mass Storage collection behave
like it should.

BUGFIXES:
* Remove empty folders when deleting tracks from USB Mass Storage collection.
* Don't copy tracks to USB Mass Storage collection in move operation.
* Fix defunct aborting of transfers to USB Mass Storage collection.


FIXED-IN: 2.6
DIGEST: bugfix
CCMAIL: Bart Cerneels

Fix syndication plugin not handling relative urls properly

Fix settings tabs UI texts

Allow creating cdma connections when no cdma device is plugged.

Tidy up the log loader, and fix all associated crashes

REVIEW: 103824

Restore scrollbars when using websnap features

Fix wifi hidden network support. A new QtNetworkManager/libnm-qt snapshot
is also required.

client was able to send illegal chow to server

when showing all action buttons, including those not applicable,
the player was able to call chow even when it was not his turn next.
the client process must not do that - the server aborts the game if
a player tries to do something illegal

Qt -> KDE classes

Show download size for map themes and offline data.

initial debugger use.

Need more commands (start in debug mode, now allways run debugger)

Improving KStars FITS viewer to be utilized effectively in Ekos.
The viewer now supports opening multiple FITS simultaneously, each in its own tab with its own histogram, undo/redo stacks, settings...etc. The viewer will be used for focusing and guiding in addition for the regular image capture.

Allow the page number selector to be added to the toolbar

Ok, this is not really the review Jonathan did, i did rewrite the code partially because i did not really
want to have a new observer, but the code is heavily inspired in his patch.

Also the page number selector is not in the toolbar as the review had, it'd be silly to have it in both places
by default, so if you want to have it you have to go, edit the toolbar and add the "Page Number" action to it.

REVIEW: 103427

FIXED-IN: 4.9.0

enable Maintenance action in Tools menu.
Maintenance tool is able to run more than one process in background to maintain your collections, as thumb, finger-prints, duplicates, scan new items, metadata sync, etc...

RSS feed handling

Basic handling of RSS feeds, in KDeclarativeWebView and the QML UI
- KDeclarativeWebView exports a QStringList of RSS feeds
- In the dashboard, there's now an RSS button, which copies the link of
the first feed found to the clipboard

That way, the user can paste it into the RSS reader's add dialog, that
part already works.

Would be nicer to do this through Nepomuk, automatically, but this
already provides a nice base for it

Partial port of kdeui to Qt5.

Port kio to Qt5.

Enable Blur by default for SandyBridge

REVIEW: 103852

- Added the ability to spell check a selection.
- Removed unnecessary debug statements and some code.
- Wrapped some more literal text with QLatin1String.

Build interfaces with Qt5, except the part that needs phonon.

Added support for nepomuk:?resource=xxx URLs.

Allow Lanczos for SandyBridge

Add a define for KWindowSystem so that we can port to Qt5.

Do not write QtWebKit's history data to temporary files anymore.

Note that this is yet another attempt at integrating Konqueror's history
navigation with QtWebKit's without causing a regression. This change should
finally put this never ending problem to rest without eating up a user's
disk space.


FIXED-IN: 1.3.0

Nepomuk magic for downloading files

With this patch, the browser
- adds downloaded files to Nepomuk,
- tags them as "Download" (not translated -- maybe we should do that?),
- and adds them to the current Activity, as Ivan described and
- adds the source URL of the file as comment to the downloaded file's
metadata

Ivan, could you check that the activity part works?

Add options to auto-hide system tray icon when no alarms are due

Hide system tray icon by default if no alarms due within 24 hours.
Provide options to select a different time interval, or to show tray
icon at all times.

Allow to move multi filter to bottom

Show system tray icon while audio is playing

Provide a means of stopping audio while it is playing.

Start to implement sylpheed importer filters

Load and apply the ODF tick-marks attributes.

start a touch optimized version of krita

Support more number formats for check numbers

Original patch from Hilarius Warwinkel

Implement support for chart-axis value-ranges in the MSOffice 2000/2003/2007 filters.

MetaFile::Album: support for embedded album cover reading & writing

FEATURES:
* Support for embedded album covers in non-collection tracks and
in USB Mass Storage collection.

This could potentially slow down performace of album loading, but my
tests show that cover art loading takes 2 - 10ms, which is really okay.
Also, the fact that track has embedded cover is cached, so there is no
penalty for tracks wihout cover.

DIGEST: Feature

Shift key while dragging tracks to collections changes from copying to moving

The functionality was already there, but unintentionally disabled because
default implementation of CollectionTreeItemModel::supportedDropActions()
did not return Qt::MoveAction.

Care is taken to visually indicate the feature in gui by changing the mouse
cursor.

DIGEST: Feature, see title.

Enable keyboard activation of PlaylistBrowser items.

Note: keyboard navigation using the arrow keys is only possible if the
default shortcut asssignments for seeking are changed.

Add support for showing available rooms in join chat room dialog

This adds support for showing available rooms. You can query the default
server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are
there, the name and the description.


REVIEW: 103825

Get sure pdfs are loaded when restoring sessions

Add support for showing available rooms in join chat room dialog

This adds support for showing available rooms. You can query the default
server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are
there, the name and the description.


REVIEW: 103825

red versions of translucent/widgets/panel, widgets/panel-..

Add new icons confirming to harmattan ui styles

The icons were designed and provided by Nuno Pinheiro

A +- -- mobile/calendar/hi80-apps-korganizer-mobile-harmattan.png
A +- -- mobile/contacts/hi80-apps-kaddressbook-mobile-harmattan.png
A +- -- mobile/mail/hi80-apps-kmail-mobile-harmattan.png
A +- -- mobile/notes/hi80-apps-notes-mobile-harmattan.png
A +- -- mobile/tasks/hi80-apps-tasks-mobile-harmattan.png

Establish distinct SoundEffect components for each different "wav" files

Unfortunately as of now, the Qt Mobility Audio stack has a few cumbersome, but
known bugs. It involves the thing if you would like to play, and set the source
beforehand, it crashes with SoundEffect, and misbehavior with the Audio QML
Element, too. The current workaround is establish distinct components for each
sound effect. As for kanagram, it is not a huge problem because we use only
three difference SoundEffect elements.

new cmd line option --socket for kajongg and kajonggserver

allows running multiple pairs of client/dedicated server in
parallel using sockets, without having to resort to TCP/IP

kajonggtest: new option --jobs

start multiple kajongg instances simultaneously, each with a dedicated
server. This way we can make better use of all available cpus.

drastically improve performance of ProjectFileItem::setUrl

KMimeType::findByUrl was actually not the main culprit, instead it was
iconName with the url passed. This is then checked to see if the url
points to a directory and then it is checked whether that directory
contains a .directory file defining an icon.

Since we are looking at a Project*File*Item, this is of course nothing
we need to do. Just ommitting the URL speeds this procedure up by roughly
one order of magnitude (a big project - Qt in this case - took before
about 0.8s for the iconName call alone, now it's down to about 0.04s
these numbers are accumulated over the whole project loading process)

to factorize maintenace tools implementation with common features, add new class MaintenanceTool. Not yet used

Make moving animations less obtrusive

Only animate the moving of items if the new position is within the same
row or the same column. Otherwise just fade in the icon on the new position.
This makes the the animations when resizing the window or changing the zoom-level
a lot more pleasant.

Hidden option to disable nao:created handling on graphs.

This results in much less graphs to be created which in turn means
a significant performance increase.

Further animation optimizations

- Assure a proper minimim width in the compact mode.
- Don't calculate the old position of hidden items to animate the
moving. Just show them directly.

Use createGraph in findApplicationResource.

This is to reduce the places in the code where graphs are created and
to benefit from improvements in graph creation.

Improve import filter

Optimize memory-usage of the Excel 2000/2003 filter.
This optimizes the sidewinder Cell and Value classes (reported by massif as memory-hotspots while reading xls files) to use lesser memory.

Optimize image handling code in the MSOffice 2007/2010 filter.

Improve anchoringParagraphRect top

For anchoring the top of the rect is supposed to be the point where
potential borders are drawn too.
Previously we used the point where background was filled. Without
borders that was not the correct place, so now always use the
"divider" position.

In user terms it means top is above the letters where the paragraph
spacing is counted from.

A huge refactoring for KisNodeModel

Now the model doesn't depend on the hierarchy of the image. It uses
the hierarchy of the dummies stored in KiShapeController instead.

Some bullet points:
1) KisShapeController connects to the image and forwards the node
addition/removal signals for other recievers
2) KisNodeModel is connected to the KisShapeController and listens
to the forwarded signals. It follows that it doesn't depend on the image
directly, so there are no problems with multithreading.
2.5) KisNodeModel does not depend on sigLayersChanged() anymore.
3) KisShapeController manages when a node should be activated. It emits
the signal sigActivateNode(KisNodeSP) which is processed by the
KisNodeManager. It solved many problems at once. First, we needn't
workaround moving of nodes (KisNodeManager::Private::activeBeforeMove).
Second we are able to deprecate KisNodeManager::activateNode() now. (It'll be
done in one of next commmits).
4) Fixed KisNodeFacade::lowerNode(). Now newly activated node depends on the node
which is added in the end of the operation, so we should move exactly the node
which was requested.
5) A small refactoring for KisLayerBox is done. It was discussed with Boud on irc.


Not yet fixed issues:
1) I had to disable Bumpmap filter temporarily, because it didn't
compile with changed KisNodeModel. It'll be fixed in the following commits.
2) When loading an image with many layers KisLayerBox does not scroll to
the active layer.

Optimize the number-format logic in the Excel 2007/2010 filter.

This greatly decreases the time needed to load Microsoft Excel 2007/2010
document files.

Before loading the www.nsf.gov%2Frecovery* xlsx file took ~32 seconds
on my reference-system while after this patch loading that file takes
now ~24 seconds what equals a ~25% speed-up.

The magic that makes it possible is to fix the logic that before we
re-parsed and translated the MSExcel number-format for each cell again
and again into the ODF number-format. Now we do this rather expensive
conversation only once for every number-format. Since cells sharing
the same number-formats is more the rule then an exception and since
the cell-handling is a hotspot the patch has a huge impact on load of
Microsoft Excel 2007/2010 documents.

Fixups for the link popup

KDeclarativeWebView:
- delegate all links to us, we decide what goes where
- everything is loaded inside the current page -- we'll need
to check the target here, >> FIXME
- with all links intercepted from QWebPage, we can handle pressAndHold
in out own code, so wire up what we need exported to the QML WebView

FlickableWebView:
- suspendInteractive property: disables flicking temporarily, triggered
when our linkpop up opens -- this unscrews interaction with the
underlying flickable when our popup opens

LinkPopup:
- Make copy work
- Fix labels
- fix anchoring inside popup

bold progress, pre-kerning

PlacemarkLayout: limit the placemark number based on used area ratio

The goal is to keep a sane limit on the number of placemarks displayed,
by design, because one doesn't want to completely fill the screen with
placemark names.

REVIEW: 103813

pyqt4: use new style signals

Use Column for the timer settings so different rows for better UX

The space is very small especially in Portrait mode for the settings. The slider
might represent a bit more value than available for the relevant step size in
Portrait mode. It is essentially the same concept as for the Brightness slider
and setting. Even the word "Brightness" fills in 30-40% of the actual row, and
that is not even a long word enough in the practice. It must be at least that
font size though to be readable enough.

Initial changes for Windows support.

Here are the problems:
* PerlQt .dlls and Qt dlls use the same name ("QtCore4.dll", "QtGui4.dll").
So the PerlQt one gets loaded, but the Qt one doesn't. The only way to
get around this is to rename the .dll. But I don't want to rename all the
Perl modules, because that would break current code. So you'd end up with
the .pm files having a different name from the .dll files.

* ExtUtils::MakeMaker uses a separate file to list what functions should
be visible to outside code, specifically marking the boot functions as
visible. PerlQt uses CMake, which doesn't appear to support this,
expecting the visibility attributes to be set in the code. But Perl uses
macros to declare the XS functions, so in order to set the visibility in
the code, I have to redefine one of the Perl macros to inject
"__declspec(dllexport)".

I'm looking at