Issue 225

Fix a crash when importing declarations


There's apparently another bug left with dotted imports (again),
will be fixed as soon as possible.

Fix loading/saving of theme data

rewrite widget text caapture enabling in C++, because krosspython version was crashing

backport C++ rewrite of widget-text-capture.
new code is better than crashing one

minimumSize(): On loading, apparently it can happen that m_pObject is not
set - as witnessed by following crash:

Program received signal SIGSEGV, Segmentation fault.
UMLObject::name (this=0x0) at /trunk/KDE/kdesdk/umbrello/umbrello/umlobject.cpp:185
185 return m_name;
(gdb) bt
#0 UMLObject::name (this=0x0) at /trunk/KDE/kdesdk/umbrello/umbrello/umlobject.cpp:185
#1 0x083213ff in ObjectWidget::minimumSize (this=0x8857d68)
at /trunk/KDE/kdesdk/umbrello/umbrello/widgets/objectwidget.cpp:132
#2 0x0832f3bd in UMLWidget::constrain (this=0x8857d68, width=@0xbfffcafc, height=@0xbfffcaf8)
at /trunk/KDE/kdesdk/umbrello/umbrello/widgets/umlwidget.cpp:257
#3 0x08332add in UMLWidget::clipSize (this=0x8857d68)
at /trunk/KDE/kdesdk/umbrello/umbrello/widgets/umlwidget.cpp:1251
#4 0x0840bc63 in UMLView::loadWidgetsFromXMI (this=0x8854948, qElement=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/umlview.cpp:3464
#5 0x0841d917 in UMLView::loadFromXMI (this=0x8854948, qElement=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/umlview.cpp:3431
#6 0x08369b8e in UMLFolder::loadDiagramsFromXMI (this=0x8642658, diagrams=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/folder.cpp:381
#7 0x0836b2c9 in UMLFolder::load (this=0x8642658, element=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/folder.cpp:473
#8 0x084002cf in UMLObject::loadFromXMI (this=0x8642658, element=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/umlobject.cpp:1067
#9 0x083dbf39 in UMLDoc::loadUMLObjectsFromXMI (this=0x8620670, element=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/umldoc.cpp:2111
#10 0x083dba27 in UMLDoc::loadUMLObjectsFromXMI (this=0x8620670, element=...)
at /trunk/KDE/kdesdk/umbrello/umbrello/umldoc.cpp:2130
#11 0x083dd391 in UMLDoc::loadFromXMI (this=0x8620670, file=..., encode=<value optimized out>)
at /trunk/KDE/kdesdk/umbrello/umbrello/umldoc.cpp:1938
#12 0x083da8a0 in UMLDoc::openDocument (this=0x8620670, url=..., format=0x0)
at /trunk/KDE/kdesdk/umbrello/umbrello/umldoc.cpp:544

add hack to workaround strange ktextedit internal spellchecking behaviour

fix word (non-)wrapping


also cleanup propjectmodel nodes on exit

Properly escape special characters in file names.

Also, fix a bug in label positions coming out of 'maximize plot' mode.

- Only show 'lock pos to data' when it is relevant (ie, parent is a plot
render item).

- Lock the location of the bottom right of a text label, not the center.
Also add low level code for this to be the bottom left instead. The
ability to switch this awaits a UI.

With QPainter, draw a line only if the two points are visible (to prevent random lines with gnomonic projection).

Use temp file creation based on QTemporaryFile for BQM.
Use SafeTemporaryFile for JpegRotator.

Do not crash if null parent is given to notification wrapper

This can happen at startup. We could use the desktop window then, but I believe
putting a notifier just somewhere is more wrong than right, better skip it then.

Method was not virtual, therefore the implementation was never called.

Fixes bug that when revising Exif orientation tag, the file worker task
would never complete

Remove from the kickOff list before removing it from the resource watcher

This fixes a segmentation fault.

Fix repainting of items when toggling previews off.

The code was only going to update mimetypes whose mimetype wasn't already
known.

Patch tested by Ignat Semenov.

Add timeout for logoutSoundFinished() signal to prevent shutdown process
from stopping because of broken sound system.
Thanks to Peter OGorman for pointing this problem out.

REVIEW: 103593

Fix Bug 247338 - Sonnet spellchecking dialogue: Cancel action not implemented properly

signal languageChanged was emitted all the time when a config was changed in widget.
So it was not as defined in api.
Created a new signal configChanged() better name and keep old signal.
Remove it for KDE5 and clean up this class
(We need to make some work on sonnet for kde 5)

FIXED-IN: 4.8.1

Fix for mtab monitoring on Linux

Add a QSocketNotifier pointing to the mtab fd.

REVIEW: 103954

Combined handling of fstab and mtab, improved caching

This patch reworks several aspects of the fstab and mtab handling.
1. Most importantly, it takes the union of fstab and mtab to create a
list of available shares.
2. Mtab is cached and keyed by share name, as fstab already is
3. FstabManager serves as a central dispatcher for mtab/fstabChanged
signals. Caches are invalidated, and recreated when needed.
4. Caches and valid flags are members of the FstabHandling class. Valid
flags are needed to differentiate between "empty and valid" and invalid
caches.

REVIEW: 103956
REVIEW: 103957

fix configuration of file associations using full paths
this doesn't fix yet that spaces should be handled correctly.

Fix Bug 290720 - Cannot sort folders on left side anymore. Dragging only

makes a copy
FIXED-IN: 4.9

KexiDB SQLite Driver: fixed crash when inserting incomplete rows

KexiDB
*SQLite Driver
**fixed crash in prepared statement execution for inserting data when number of items to insert is smaller than expected; this case could be found when importing CSV data in Kexi with fewer columns specified than expected

Fix Bug 154087 - "New mail to mailist" should active folder "New mail" template

it fixed bug too when we click on a mailto and it doesn't use "new message" template.

FIXED-IN: 4.8.1

Avoid parsing the message multiple times in filters. This is against
the published KMime policy.

Fix last bug when register tag Thanks Vishesh Handa for his help

Open-XChange resource now handles dates before 1970-01-01 00:00:00.

Problem was, that QDateTime is not able to handle negative unix
timestamps (time_t).

Fixed with a workaround.

Fix: Bug 259093 - [regression] Search dialog missing folder selection

Readd search in specific folder

FIXED-IN: 4.8.1

Fix Bug 295125 - Saving message as template doesn't keep transport

We saved transport name and not transport id
FIXED-IN: 4.8.1

Pop up the correct context menu over blank space in the middle column


FIXED-IN:4.9

Mirror the masks too when the layer is mirrored

go into text editing after inserting a text shape

Fixed Pipe Brush mask generation

The wrong check was added due to non-obvious naming. Fixed both.

Fix transitive clones bug

Also fixes a crash on undo/redo of the clone layers
(unittests shows the case)

Fix the behaviour of list items when "Increase Indent" is used


REVIEW: 104144

Fix dropping of Selection Masks onto the root layer

Now it is possible only in case there is no global selection present.

TODO: port the methods of KisLayerBox coupled with KisNodeManager to
check the possibility of moving a node through the allowAsChildMechanism()
instead of hardicong checks.

Attempt to reconnect to the database (once) on accidental disconnects. If this still throws, we need to notify the user and reset the UI to the same state as "kmymoney -n".

Add a test case to reproduce the problem in the storage layer.

Fix crash on opening SQLite database.

Close any editor before adding a new object

If not closed, the insert command will be executed before the change in the open editor.
This is fairly confusing for the user ;)

Don't access changetracker unconditionally

Crop layers even when the crop rect is as big as the image

(In reply to comment #1)
> [...]
> you have an inheritance in the opposite direction.
> The mutual inheritance throws Umbrello off the handle and so I've removed
> the first one. (Actually I wonder why Umbrello did not disallow its
> creation.)

It turns out that
AssocRules::allowAssociation(Uml::AssociationType,
UMLWidget *, UMLWidget *)
was being called twice: First in ToolBarStateAssociation::setSecondWidget()
(toolbarstateassociation.cpp:226) and again via ToolBarStateAssociation::
addAssociationInViewAndDoc() in UMLView::addAssociation().
At the time of the second call, the AssociationWidget was already created
and inserted at its role widgets.

Fixed as follows:
- In UMLView::addAssociation(), remove the call to
AssocRules::allowAssociation()
- At ToolBarStateAssociation::addAssociationInViewAndDoc(), change return
type to bool (true for success) and test the success at
ToolBarStateAssociation::setSecondWidget()
- Revert the "#if 0" at the extendedCheck code at assocrules.cpp:170 ff.
thus re-enabling the check for illegal mutual associations.

Fix slider in Tray Popup to follow volume changes again (trunk)
Fix mute state for WheelEvent in DockIcon

Set codec to utf8 when reading our own lists

Apparently QTextStream doesn't detect it on non-utf8 locales

fix crash after resume

patch by Jiri Slaby, thanks!
(essentially adds a null pointer check)

Allow saving of file playlists with a dot in name

BUGFIXES:
* Playlists with a dot in name can now be saved to Playlist Files on Disk.


FIXED-IN: 2.6

Playlist browser: drag & drop and plugged playlists cleanups

This change fixes a couple of bugs:
* it is now possible to drop tracks & playlists to playlist providers
in Saved Playlists
* When a new empty playlist provider appears or disappears when Amarok is
running, the view is correctly updated.

FEATURES:
* "Crop playlist" functionality implemented using drag & drop.

CHANGES:
* Drag & drop of tracks and playlists to Saved Playlists works in all cases.

BUGFIXES:
* iPod playlists now appear even when plugged in while Amarok is running.





FIXED-IN: 2.6

Don't use the gcrypt version macro in it's version check

Some fixes for cryptography plugin.
Thanks to Pali Rohár for this patch.

REVIEW: 6768

Group Offline contacts into a separate group "Offline Users"
Thanks to Barry Carter for this patch.

REVIEW: 2179

do not hardcode pathes on windows

Fix 'Apply' button not being enabled when configuration of away/xa messages changes

Interesting that nobody has reported this yet...

Fix unbalanced cairo_context save() restore(), by moving up exit condition.

re-added painting of shadows inside client, in "preview()" case :(

added minimum value for progressbar, to fix rendering in amarok.

Convert columns to a QHash rather than a QVector in ExtraModelProxy

Previously number of columns was allocated to be the same as the number of rows which makes no sense
which caused a crash when the source model had no rows and a column was added.

more fixes for tooltips

- when hiding ClientDialog, also invalidate pointer to it.
- set activePlayer earlier (when assigning players to seats)

Integrating astrologics checkUp in simon-touch

Provides a graphical way to send the robot on a scouting mission and
return with a webcam video of it's findings

Save and reload settings exposed by katepart per file

Settings concerned :
- Bookmarks
- Folding
- Opening mode (rw, ro)
- Encoding


REVIEW: 104085

file search improvements, forward-port db recover code

Start kdeinit before nepomuk, which improves start up and make kded more
stabler since contour and activitymanager does not try to launch it at
the same time now.

Add a basic KDevelop sessions data engine and plasmoid.

It's a fork of the Konsole profiles data engine and plasmoid from
kdeplasma-addons master, cleaned up a little. Likely depends on
KDE 4.8 (which I tested it in) due to its use of Plasma's new QML
APIs. It was originally written by Shaun Reich and Laurent Montel.

add a cyclical color scale, max = min.
This is good for angles.

Offering to recover from backup if index corrupted

If index.xml is corrupted we check if a backup exists. Then we ask the
user if he would like to use the backup.

Added support for KDirNotify to signal newly created TV shows.

We simply create a new ResourceWatcher and watch for newly created
nmm:TVShow resources and type nmm:TVShow added to resources.

Two improvements to xml2pot

Reattach the attributes when the msgid of two different tags match.i.e.
<link linkend="Bit-Operations">Bit Operations</link>
and
<title>Bit Operations</title>

Do not kill a single tag at the end of a non tagged msgid, i.e.
Final step is to generate static &HTML; pages and upload to my web server for the enjoyment of friends and colleagues. &HTML; generation is described in <xref linkend="chp-generating-html"/>

Let's hope i did not break lost of other stuff :D

Make it possible to autologin as guest

Fixed misbehaving encoding selection when importing a CSV file

CSV Import
*Fixed bug: encoding selection misbehaves when importing a CSV file
**encoding selection was not retained between first and another displaying of the CSV Import Options dialog
**encoding selection made in the CSV Import Options dialog was not applied to the importing preview and process

Add email hook configuration for nepomuk-metadata-extractor

Ported to the new KParts::HtmlSettingsInterface so it works with the webkit
engine too.


FIXED-IN: 4.8.1
(cherry picked from commit 63ad7a573c5bb2876375d4fbd02ed2078588b3d5)

Fixed mouse/modifies for tools again

Ok, this path fixes several things:

1) It removes almost all uses of m_localTool technique (except
path-based tools). This caused various problems with processing
of the events by two independent KisTool-based tools. Now it is gone,
and creation of the Options widget is done by a separate class:
KisSelectionToolConfigWidgetHelper. This class will probably disappear
as well, when the figure-based tools are united in a single class.
KisToolSelectBase now uses the helper as well and non-figure-based
classes inherit it.

2) It fixes processing of mouse/keyboard events in KisTool/KisToolPaint.
Well, *we really need to write some interaction-based system for the events*.
The state machine of the interactions must be written separately. I've fixed
this at least three times in the last two years. Such code does not live
longer than half a year. Another change will break them again.

Ok, I must admit that I was wrong suggesting using SECONDARY_HOVER_MODE for
showing the cursor of the color picker. If we did so we would have to introduce
even more modes like MIRROR_HOVER, PAN_HOVER. In this case it would be almost
impossible to deal with these states manually using 'if's. So what I did was
introducing KisToolPaint::specialHoverModeActive(), which is checked by the
KisToolFreehand. This is a hack, but it will go when we do the tools in a right
way. Currently, any change in this area will demand rewriting this part anyway.

hidden option: disable line modification markers

In KDE >= 4.8.1, it is now possible to disable the line modification system
in Kate with

kwriteconfig --file katerc --group "Kate View Defaults" --key "Line Modification" --type bool false

This only works if all Kate instances are closed. To enable it again, close
Kate and run

kwriteconfig --file katerc --group "Kate View Defaults" --key "Line Modification" --type bool true

If you want to do the same for KWrite or Kile, use kwriterc or kilerc
instead of katerc. Same for KDevelop or other applications using kate part.

In master (KDE 4.9), there is a graphical option in "Appearance > Borders"

add initial bing runner

this is meant mostly for images i think. it looks like it has a nice
api. how ironic is this world that microsoft's search engine is the one
with the easiest and only non-limited by queries count api.

Support loading/unloading of scripts on config change

Whenever the KWin configuration is changed, scripting has to unload
scripts no longer loaded and load the scripts which have been added.
For this new methods are introduced to check whether the script is
loaded.

REVIEW: 104037

Make the tray popup follow the slider orientation setting.

Add code for import evolution v1/v2

Add import mail widget

- Wrong values in Monthly Report "Amounts in accounts"

add the metadata extractor library to allow web fetching

Adding support for custom navigation of pages for CA Text doc.
User can see the pages to navigate on the left side of the CA Text doc
and clicking those pages, one can view particular page.

REVIEW: 104092

Ported database compacting code to the new Kexi that uses system SQLite

KexiDB
*SQLite Driver
*Ported database compacting code to the new Kexi that uses system SQLite version



DIGEST:Kexi switched to a new optimized SQLite database compacting tool

Added support for checking the type of newly added dummy

We should not call QAbstractItemModel::beginInsertRows if this dummy
has a type which will not be shown in the layers tree. This feature
was planned, I simply forgot about it.

Update libkcddb to use libmusicbrainz-4.0,
which uses the new api from last year,
fixing lookup for releases with multiple discs.
Kscd still uses 3.0, so the libmusicbrainz-3 cmake
files are still left.

Also, enable Musicbrainz lookup by default,
don't know why I haven't done that earlier.

Introduce a new type of MediaSource, for AVCapture

This type of media source describes an audio device and a video device
together. It's purpouse is to enable the backends to implement audio
video capture, for example capturing video from a webcam and audio from
a microphone, at the same time.

MediaSourcePrivate now has separate device access lists.

Deprecated an old unused protected constructor that stood in the way.

This commit tries to preserve source / abi compatibility.

Added release grouping.

There are three groups:
- New: a new episode has already been aired.
- Upcoming: a new episode is scheduled.
- Finished: no new episode is scheduled.

Implemented ResourceWatcher signals for added and removed types.

This is done by simply adding a special case for rdf:type into the
changeProperty method in the manager.

Put an away overlay on the tray icon when in global away state.

Beginning of Plasma NM interface using QML

Add options for logo and welcome message to the greeter config

Allow searching for notes by people

One can click on the person in the PersonGrid to show all the notes which are
related to that person.

Implement RDFa parsing

And extract the people from the note properly. This fixes the saving
of people in notes.

Add date of won game to high score dialog

Code by Arjun Basu


REVIEW: 6905
FIXED-IN: 4.9.0

optimize: reduce memory consumption of Token class by 50% on 64Bit

By removing the ParseSession pointer from it, we get rid of 8 bytes
and furthermore reduce the alignment size to 4. This way, we now
only require 12 bytes per token compared to 24 bytes previously.

This also allows us to define the Token class as a primitive type,
potentially speeding up the TokenStream even further.

The "cost" is a changed API, to get the string representation of
a token, one must now ask the TokenStream. In practice this is very
rarely a real pita, as before one often did

stream->token(i)->symbol()

now you just do

stream->symbol(i)

Furthermore I've consolidated the tons of custom "AST* node to QString"
functions into one central ParseSession::stringForNode.

Finally, I've replaced some costly token.symbol() == IndexedChar("somechar")
with the much faster token.kind == Token_xyz comparisons.

All in all, this should a) make our code faster and b) let it use much
less memory while at it. For the big resource file in the bug below,
the difference of 50% in the Token class results in ~250MB less memory
consumption

UMLDoc::loadFromXMI (tagEq(tag, "Package") ||
tagEq(tag, "Class") ||
tagEq(tag, "Interface")) :
Do not call loadUMLObjectsFromXMI() because that method again iterates over
the child nodes of the element (not appropriate here because we already
identified the exact tag to load.)
Instead, use Object_Factory::makeObjectFromXMI() for creating and
UMLObject::loadFromXMI() for loading the object.

memory errors fixes

*optimize more tm fuzzy search more
*fix valgrind errors

limit the quantity of query clents kept in memory

OK, ditch itemSync with its performance woes, and go back to
something custom. The good news is that this now works fast,
and the memory bloat is gone. yaay!

in progress

A +- -- Oxygen-Regular/Oxygen (2012-02-24 20-12-09 GMT).vfb

bing engine works

OPTIMIZE: Use an actionGroup to compress events during marking before committing changes.

Cuts the time left waiting for larger commit changes to be marked in half.

Create new library for classes that are planned to be submitted to Qt5.

Please do not contribute to these classes, it makes submission under the
CLA very difficult :/

First class in libkdeqt5staging is QUrlPathInfo.

Move K3Network stuff to kde4support.

Port from KUrl to QUrl+QUrlPathInfo

Port from KUrl to QUrl.

Deprecate ugly KRecentDocument::add(QString, bool) method.

try to get the thumbnail.

can't work because krunner can only accept a QIcon, which is not
transportable across threads (requires a conversion from qpixmap, and
qpixmaps are not threadable). perhaps i'll have to add a method to
accept a QImage?