Revision 5b31b80...

Go back to digest for 29th April 2012

Bug Fixes in Office

Friedrich W. H. Kossebau committed changes in [calligra] /:

Fixes: ensure same order of units in whole Calligra UI, have ruler and page layout dialog update to change of document's unit type

also tune KoUnit API a little:
* rename KoUnit::unit(...) to KoUnit::fromSymbol(...) <- more Qt'ish
* turn static KoUnit::unitName(KoUnit) into member method KoUnit::symbol() <- as typical use-case is on existing KoUnit instance, also shorter and more OOed
* rename KoUnit::Unit to KoUnit::Type <- "type" feels a better term here
* added KoUnit::type() and KoUnit::setFactor(...) <- useful in a few places
* remove KoUnit::unitDescription(...) from API <- not used outside
* rename KoUnit::PixelVisibility to KoUnit:: ListOption <- more general, some might want to add other flags like HideImperial

And adds unit tests for the touched KoUnit API

Thanks to boemann and Cyrille for making it compile with Qt 4.7 as well

REVIEW: 104626

File Changes

Modified 42 files
  •   sheets/DocBase.cpp
  •   karbon/ui/KarbonPart.cpp
  •   libs/kopageapp/KoPADocument.cpp
  •   libs/main/KoDocument.cpp
  •   libs/main/KoDocument.h
  •   libs/main/KoRuler.cpp
  •   libs/main/KoView.cpp
  •   libs/main/KoView_p.h
  •   libs/odf/KoUnit.cpp
  •   libs/odf/KoUnit.h
  •   libs/widgets/KoPageLayoutWidget.cpp
  •   libs/widgets/KoUnitDoubleSpinBox.cpp
  •   sheets/dialogs/LayoutDialog.cpp
  •   sheets/part/Canvas.h
  •   sheets/part/Doc.cpp
  •   sheets/part/HeaderItems.cpp
  •   sheets/part/HeaderWidgets.cpp
  •   words/part/KWApplicationConfig.cpp
  •   words/part/KWOdfLoader.cpp
  •   filters/karbon/image/ImageExportOptionsWidget.cpp
  •   krita/ui/widgets/kis_custom_image_widget.cc
  •   libs/kopageapp/dialogs/KoPAConfigureDialog.cpp
  •   libs/koproperty/editors/spinbox.cpp
  •   libs/koreport/common/KoReportItemBase.cpp
  •   libs/koreport/common/krsectiondata.cpp
  •   libs/koreport/wrtembed/KoReportDesigner.cpp
  •   libs/koreport/wrtembed/KoReportDesignerItemBase.cpp
  •   libs/koreport/wrtembed/KoReportDesignerItemLine.cpp
  •   libs/koreport/wrtembed/reportscene.cpp
  •   libs/koreport/wrtembed/reportsection.cpp
  •   libs/main/config/KoConfigGridPage.cpp
  •   libs/main/config/KoConfigGridPage.h
  •   libs/main/config/KoConfigMiscPage.cpp
  •   libs/main/config/KoConfigMiscPage.h
  •   libs/odf/tests/TestKoUnit.cpp
  •   libs/odf/tests/TestKoUnit.h
  •   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp
  •   sheets/part/dialogs/PreferenceDialog.cpp
  •   words/part/dialogs/KWPageSettingsDialog.cpp
  •   words/part/dialogs/KWPageSettingsDialog.h
  •   krita/plugins/extensions/imagesize/dlg_imagesize.cc
  •   krita/plugins/tools/defaulttools/kis_tool_measure.cc
42 files changed in total