Revision d1a1c80...

Go back to digest for 6th May 2012

Bug Fixes in Multimedia

Matěj Laitl committed changes in [amarok] /:

QtGroupingProxy: don't re-enter beginInsertRows() (crashfix)

This should fix a nasty crash that was only reproducible when Qt was
build with debugging assertions enabled. (and perhaps only if you have
empty playlist providers) The fix is based on an assumption that
addSourceRow() in QtGroupingProxy is only called from:

a) buildTree(), which encompasses it in {begin/end}ResetModel()
b) modelRowsInserted(), but that should be always preceeded by
modelRowsAboutToBeInserted() that calls beginInsertRows()

Bart, this is largely your code, is this correct?

* Fix crash on start when Qt is build with debugging assertions

DIGEST: fix rather nasty crash

File Changes

Modified 3 files
  •   ChangeLog
  •   src/browsers/playlistbrowser/QtGroupingProxy.cpp
  •   src/browsers/playlistbrowser/QtGroupingProxy.h
3 files changed in total