Revision a3d378d...
Go back to digest for 13th May 2012Bug Fixes in Multimedia
AudioCdCollection: don't create a reference out of temporary var (crashfix)
There's following code in AudioCdCollection::updateProxyTracks():
const QString &urlString = url.url().remove( "audiocd:/" );
Which I think is wrong, because url.url() returns a temporary QString
and QString::remove() returns a reference to itself. However, the
temporary is AFAICS destroyed as soon as this line ends. This IMO
results in urlString being an invalid reference.
I'm not really sure about this, I haven't read C++ spec, but given many
users report crash on the following line, this could be the culprit.
I was never able to reproduce the bug, so I'm shooting blindly.
Reporters, please test reproducibility with current git and reopen if
this is not fixed.
FIXED-IN: 2.6
DIGEST: fix grave crash
File Changes
- ChangeLog
- src/core-impl/collections/audiocd/AudioCdCollection.cpp