Revision 05a3420...

Go back to digest for 27th May 2012

Bug Fixes in KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

Use smart pointers to protect access to TabBoxClient

Client holds a SharedPointer to the TabBoxClient and only
provides access to a WeakPointer which is passed to TabBox.
ClientModel is adjusted to hold a list of WeakPointers instead
of the direct pointers.

This fixes the following reproducable crash:
1. Configure both primary and secondary TabBox with different
2. Use primary TabBox
3. Close a window, best the one which used to be active
4. Use secondary TabBox
-> Crash

The reason is that the ClientModel still contains the pointer
to the deleted TabBoxClient in step 3 and while creating the
layout access to the TabBoxClient is needed to get the Client's

By using the weak pointer it can be ensured that we don't try
to dereference the deleted pointer and prevent the crash.

REVIEW: 105000

File Changes

Modified 8 files
  •   kwin/client.cpp
  •   kwin/client.h
  •   kwin/tabbox/clientmodel.cpp
  •   kwin/tabbox/clientmodel.h
  •   kwin/tabbox/tabbox.cpp
  •   kwin/tabbox/tabbox.h
  •   kwin/tabbox/tabboxhandler.cpp
  •   kwin/tabbox/tabboxhandler.h
8 files changed in total