Revision 2185fa1...

Go back to digest for 10th June 2012

Bug Fixes in Multimedia

Matěj Laitl committed changes in [amarok] /:

ContextView: fix crash in addCollapseAnimation, dedicated to Mamarok

With some gdb fu, I was able to investigate that the root cause of the
bug was invalid static_cast<>, I wish static_casts were (almost) never
used in Amarok.

This crash-fix is a day-late present for Myriam Schweingruber's
birthday - cheers, Myriam! :-)

[this crash existed (in its current form) since at least 2011-07-14 as
reported by Marian Kyral. We thought we have fixed it already, but we
have in fact just reduced its probability by defaulting to a different
configuration wrt collapsing applets. My last patch touching this
7ff8068a993b3ef08 was rather a blind guess and debugging patch than
a real fix.]

CCMAIL: Myriam Schweingruber
DIGEST: Amarok crash-fix, please mention dedication ;-)

File Changes

Modified 3 files
  •   ChangeLog
  •   src/context/Applet.cpp
  •   src/context/ContextView.h
3 files changed in total