Revision 5301ebe...

Go back to digest for 10th June 2012

Bug Fixes in Multimedia

Matěj Laitl committed changes in [amarok] /core-impl/collections/ipodcollection:

IpodCollection: prevent crash on early disconnect and double-freeing

We were deleting Itdb_Playlist's twice, once in itdb_free and for the
second time in IpodPlaylist::~IpodPlaylist. Ensure we delete it only in
the second call by using trick we already do with tracks.

Also, try to prevent crashes when IpodCollection is destoryed while
IpodPlaylistProvider is still in parseItdbPlaylists() (needs testing)


File Changes

Modified 7 files
  • /core-impl/collections/ipodcollection
  •   src/IpodCollection.cpp
  •   src/IpodPlaylist.cpp
  •   src/IpodPlaylist.h
  •   src/IpodPlaylistProvider.cpp
  •   src/IpodPlaylistProvider.h
  •   src/support/IpodDeviceHelper.cpp
  •   src/support/IpodDeviceHelper.h
7 files changed in total