Revision d64d61b...

Go back to digest for 8th July 2012

Bug Fixes in KDE-PIM

Andras Mantia committed changes in [kdepim] /:

A biggish refactoring of the filter functionality:

1) Do not take the items from the cache only, as they might be incomplete (especially in online imap case, but not only).
This should fix the body loss bug on spam filtering.(Bug 287752 and similar ones + countless of reports on user list)
Might fix 293768.

2) Download only what is really needed for the filter and add safety checks that
the mail is not modified if the requested part is missing. So far the distinction
was only betwee the body and rest. This should speed up filtering.
Also related to 287752, but should fix also 292283, 288109.

3) Rename qDebug->kDebug + fix some includes

4) The code should also fix the duplicate mails appearing after filtering (some of the duplicates
with empty content), eg. 275233

All bug reporters: in case you still see the bug, reopen the corresponding one.
For the reports that were CC'd, but not closed, please try to reproduce and tell
the result.

So far the bug is fixed on master, but might be backported later to 4.9.

File Changes

Modified 67 files
  •   kmail/kmcommands.cpp
  •   kmail/kmcommands.h
  •   kmail/kmmainwidget.cpp
  •   mailcommon/searchpattern.cpp
  •   mailcommon/searchpattern.h
  •   mailfilteragent/filtermanager.cpp
  •   mailfilteragent/filtermanager.h
  •   mailfilteragent/mailfilteragent.cpp
  •   mailfilteragent/mailfilteragent.h
  •   mailcommon/filter/filteraction.cpp
  •   mailcommon/filter/filteraction.h
  •   mailcommon/filter/filteractionaddheader.cpp
  •   mailcommon/filter/filteractionaddheader.h
  •   mailcommon/filter/filteractionaddtag.cpp
  •   mailcommon/filter/filteractionaddtag.h
  •   mailcommon/filter/filteractionaddtoaddressbook.cpp
  •   mailcommon/filter/filteractionaddtoaddressbook.h
  •   mailcommon/filter/filteractionbeep.cpp
  •   mailcommon/filter/filteractionbeep.h
  •   mailcommon/filter/filteractioncopy.cpp
  •   mailcommon/filter/filteractioncopy.h
  •   mailcommon/filter/filteractiondelete.cpp
  •   mailcommon/filter/filteractiondelete.h
  •   mailcommon/filter/filteractionexec.cpp
  •   mailcommon/filter/filteractionexec.h
  •   mailcommon/filter/filteractionforward.cpp
  •   mailcommon/filter/filteractionforward.h
  •   mailcommon/filter/filteractionmove.cpp
  •   mailcommon/filter/filteractionmove.h
  •   mailcommon/filter/filteractionpipethrough.cpp
  •   mailcommon/filter/filteractionpipethrough.h
  •   mailcommon/filter/filteractionplaysound.cpp
  •   mailcommon/filter/filteractionplaysound.h
  •   mailcommon/filter/filteractionredirect.cpp
  •   mailcommon/filter/filteractionredirect.h
  •   mailcommon/filter/filteractionremoveheader.cpp
  •   mailcommon/filter/filteractionremoveheader.h
  •   mailcommon/filter/filteractionreplyto.cpp
  •   mailcommon/filter/filteractionreplyto.h
  •   mailcommon/filter/filteractionrewriteheader.cpp
  •   mailcommon/filter/filteractionrewriteheader.h
  •   mailcommon/filter/filteractionsendfakedisposition.cpp
  •   mailcommon/filter/filteractionsendfakedisposition.h
  •   mailcommon/filter/filteractionsendreceipt.cpp
  •   mailcommon/filter/filteractionsendreceipt.h
  •   mailcommon/filter/filteractionsetidentity.cpp
  •   mailcommon/filter/filteractionsetidentity.h
  •   mailcommon/filter/filteractionsetstatus.cpp
  •   mailcommon/filter/filteractionsetstatus.h
  •   mailcommon/filter/filteractionsettransport.cpp
  •   mailcommon/filter/filteractionsettransport.h
  •   mailcommon/filter/filteractionstatus.cpp
  •   mailcommon/filter/filteractionstatus.h
  •   mailcommon/filter/filteractionunsetstatus.cpp
  •   mailcommon/filter/filteractionunsetstatus.h
  •   mailcommon/filter/filtermanager.cpp
  •   mailcommon/filter/filtermanager.h
  •   mailcommon/filter/itemcontext.cpp
  •   mailcommon/filter/itemcontext.h
  •   mailcommon/filter/kmfilterdialog.cpp
  •   mailcommon/filter/kmfilterdialog.h
  •   mailcommon/filter/mailfilter.cpp
  •   mailcommon/filter/mailfilter.h
  •   mailcommon/tests/searchpatterntest.cpp
  •   mailcommon/filter/filterimporter/filterimporterevolution.cpp
  •   mailcommon/filter/filterimporter/filterimporterprocmail.cpp
  •   mailcommon/filter/filterimporter/filterimportersylpheed.cpp
67 files changed in total