Issue 245

22nd July 2012 by KDE Commit-Digest Team


Marta Rybczynska
Jos Poortvliet

This Week...

Improvements in QML shutdown dialog. KDE-PIM allows toggling full window view mode for Todo and Month views and gets a special character adding feature. KTouch adds a skeleton for keyboard layout properties widget. Digikam gets a new tool: filmtool, an automatic whitepoint finder. In Kooka, the user can now drag and drop in the gallery. Calligra supports animation motion along a path. New Amarok's Context View is available.


Commits 2401 by 194 developers
Open Bugs 21386
Open Wishes 16875
Bugs Opened 313 in the last 7 days
Bugs Closed 349 in the last 7 days

Commit Summary

Module Commits
Files Developer Commits
Laurent Montel
Roman Paholík
Allen Winter
Burkhard Lück
Aleix Pol Gonzalez
Marco Martin
André Marcelo Alvarenga
Bernhard Beschow
Boudewijn Rempt
Percy Camilo Triveño Aucahuasi

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
Ukrainian (uk)
Swedish (sv)
Polish (pl)
Estonian (et)
Spanish (es)
Dutch (nl)
German (de)
French (fr)
Italian (it)

Bug Killers

Person Bugs Closed
Jekyll Wu
Laurent Montel
Allen Winter
Sven Langkamp
Christoph Feck
Albert Astals Cid
Myriam Schweingruber
Martin Koller
Ben Cooksley
Janek Bevendorff

Commit Countries

Commit Demographics




  Bug Fixes Features Optimization Security Other



Development Tools



[] []    []


[] []    

KDE Base

[] []    []


  []    []


[] []    




[] [] []   

Networking Tools

[] []   []  

User Interface



[] []    





There are 39 selections this week

Bug Fixes


Bernhard Beschow committed changes in [marble] /:

don't crash on reload (F5) when switching from textured to vector-only map theme

* also add unit test to catch this case in the future

Wagner de Melo Reck committed changes in [rocs] /Plugins/DataStructure/RootedTree:

Fix manual creation of edges (pointers) when not showing all pointers

Rooted tree have 2 types of view, in one all pointers are painted,
and in the other one only pointers to the children are painted. This commit
fixes the manual creation of edges in last one.



Fabio D'Urso committed changes in [okular] core/generator.cpp:

Call Generator::signalPixmapRequestDone _after_ saving the calculated bounding box

Fixes a bug that causes the extraction of a wrong bounding box:

If the request queue is not empty, signalPixmapRequestDone causes a new
pixmap request to be started, thus overwriting mPixmapGenerationThread's
mCalcBoundingBox before it is read by the if in the next line.

Now signalPixmapRequestDone is called after the bounding box is saved,
so that new requests are started only after all data from
mPixmapGenerationThread have been saved.

REVIEW: 105600

Marcel Wiesweg committed changes in [digikam] /:

Move the message box execution out of the immediate scope.

The problem of event loop recursion seemingly cannot be cleanly fixed.
There's a tiny delay now and the next image is already select when the message box pop up,
I hope that's not too confusing.

FIXED-IN: 2.8.0

KDE Base

Emmanuel Pescosta committed changes in [kde-baseapps] dolphin/src/dolphinmainwindow.cpp:

Fix open-in-new-window to work with remote URLs

FIXED-IN: 4.9.0
, 292822

Emmanuel Pescosta committed changes in [kde-baseapps] /src:

Fix bug 303375 - Dots in directory names treated as file extension.

Patch by Emmanuel Pescosta

REVIEW: 105575
FIXED-IN: 4.9.0


Gopalakrishna Bhat committed changes in [calligra] libs/main/KoRuler.cpp:

Fix bug 301212: Ruler is not shown in mm units

In the current implementation, even if the ruler unit is set to millimeters the ruler shows measurement in centimeters. This
commit fixes this by showing mm measurements.

REVIEW: 105602

Gopalakrishna Bhat committed changes in [calligra] /main:

Show error message to the user on "Export to PDF" failure

Currently while exporting PDF we do not check if we are able to create the file at the location or not. This leads to the
"Export to PDF" action to fail silently. This patch adds check for that and the user is notified of failure.

Though I could not test in the exact environment as mentioned in bug 291925, what I did was that I created a folder with no
write permissions and tried to export PDF to that folder. In my test environment I could see that export failed silently
without this patch.

REVIEW: 105623

Sven Langkamp committed changes in [calligra] krita/ui/widgets/kis_paintop_presets_popup.cpp:

revert small settings change as that caused problems on high resolution displays

Thorsten Zachmann committed changes in [calligra] /:

Fix loading of embedded svg graphics.

This fixes loading of draw:image of the type svg in case the mimetype is not provided as in the document
create by LO attached to the bug report. When the mime type is not found we try to guess it by the content
of the file. To do that we read the first 16K data and pass it to KMimeType. After we found out the mime
type we also set it so it is there for later usage.

REVIEW: 105589


David Faure committed changes in [soprano] tools/onto2vocabularyclass.cpp:

Fix crashes due to using the same QUrls in multiple threads.

I'm also working on a Qt4 QUrl fix (using QMutex), and this is already
fixed in Qt5 (the rewrite does no more delayed parsing), but let's make
our software stable as soon as possible, too, by using QThreadStorage
to avoid the race.

REVIEW: 105621

Networking Tools

Joris Guisson committed changes in [ktorrent] /:

Fix crash when looking up country for IP address

Arthur Ribeiro committed changes in [networkmanagement/arthur] /:

Improved interfaces list model to show each interface differently in the QML. It is being treated wired, wireless and modem connections. The status of each one updates in the interface when it changes.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 55d677e...
Alexander Reinholdt committed changes in /trunk/playground/network/smb4k/core:

Fixed IP address lookup. First of all, the usage of the WINS server
was removed since it seems that it causes more trouble than it helps.
Second, the lookup was moved to the timerEvent() function, so that
each time a new host is added (d->haveNewHosts is set to true) the
hosts list is traversed and a lookup attempt is made for each server
that does not have an IP address set.


Laurent Montel committed changes in [kdepim/KDE/4.9] kleopatra/utils/validation.cpp:

Fix Bug 303767 - Unable to enter email address for new key because "-"

is not accepted
Patch from Julian Bäume posted in september 2011



Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

When a connection to server is not needed anymore, disconnect

This fixes a bug where a client connects with username A to server, hides
the table list and connects again with username B. But what actually
happened was that the existing table list was reshown, so he was not
really player B as expected but player A.

Diffs: 1, 2, 3, 4, 5 Revision 1306248



Sebastian Gottfried committed changes in [ktouch/next] /:

resource editor: skeleton for keyboard layout properties widget

Provides widgets to set the various properties of the keyboard layout
itself and its keys. Adapts whether currently a key is selected and to
the type of the key. Actual editing function is still missing.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 14af36a...


Matthias Welwarsky committed changes in [digikam] /color:

Filmtool: add automatic whitepoint finder

with this feature it's no longer necessary to use the color picker
to calibrate the white point of the negative. It requires to have
some residual orange mask around the exposed area of the negative.

Jonathan Marten committed changes in [kooka] /:

Allow dragging or dropping into the gallery (copy or move)

Added API documentation for the libfiletree library and the
filetreeview.h file.

Diffs: 1, 2, 3, 4, 5 Revision 131cfa8...
Islam Wazery committed changes in [digikam/development/3.0.0] /cameragui/items:

Implemented the category drawer for the import tool

KDE Base

Erlend Hamberg committed changes in [kate] kate/app/kateappcommands.cpp:

Add tab-switching commands

Add ":tabclose", ":tabedit", ":tabnew", ":tabnext", ":tabprevious",
":tabfirst" and ":tablast". These are just aliases for the
buffer-switching commands.

Lamarque Souza committed changes in [kde-workspace] /themes/default:

Improve QML shutdown dialog: add submenu support, align reboot menu
entries to the left instead of center, add hover effect.

REVIEW: 105568

FIXED-IN: 4.9.0


Laurent Montel committed changes in [kdepim] /:

FEATURE: insert special character

Diffs: 1, 2, 3, 4, 5, 6 Revision 12a66e4...
Volker Krause committed changes in [akonadi] /src/storage:

Support multi-column primary keys.

This will enable us to use the regular table setup code also for the n:m
relation helper tables, which so far have their own setup code, causing
duplicated code and a number of inconsistencies in the db schema.

Diffs: 1, 2, 3, 4 Revision c11c8bb...
Allen Winter committed changes in [kdepim] /:

FEATURE: allow toggling full window view mode for Todo and Month views.

Now we can toggle full window mode in the todo and month views
without having to go into the prefs dialog. However, the prefs
are synchronized accordingly.

In month view I used a QToolButton (double arrow left) which looks ok.
In todo view I used a QCheckBox adjacent to the Flat View QCheckBox.

Forgot to mention that I added a prefs dialog option for setting
the Flat View.

The prefs dialog options for this stuff are redundant now
and probably should be removed from koprefsdialog.cpp
Yes.. I think I'll do that.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision d517a58...


Thorsten Zachmann committed changes in [calligra] /part/animations:

Add support for animateMotion on a path

We read and write out the same data as LO/OO however this is invalid ODF according to the schema.
However that seems to be a bug in the schema.
This also adds support for loading/saving the smil:fill attribute.

FEATURE: This adds suppor for the animation motion along a path.

Diffs: 1, 2, 3, 4, 5 Revision eebc10e...
Boudewijn Rempt committed changes in [calligra] /data:

Add David Revoy's color schemes for Krita


Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision c57e0ef...


Riccardo Iaconelli committed changes in [amarok/qml] /:

Replace Amarok's context view with a QML rewrite

First integration of the mockup, further development will happen here

The initial work on Amarok's Context View has just been merged. This means a
much improved UI which will eventually lead to the development of Amarok
3.0, or at least a mobile version. The current result is still non
functional and suboptimal, but already shows promising results. A blog
post describing this work will soon follow.

Signed-off-by: Riccardo Iaconelli

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision ad2e07a...
Dan Vratil committed changes in [ktp-contact-runner] /:

Add support for opening logviewer

REVIEW: 105441

Networking Tools

Dan Vratil committed changes in [ktp-text-ui] /:

Support drag and drop file transfer

REVIEW: 105511


Friedrich Karl Tilman Pülz committed changes in [publictransport] /timetablemate/src:

Improve project actions for opening documents

- Change action text from "Show ..." to "Open ...",
change icons to "document-open"
- Add enumerables OpenScript == ShowScript, ...
- The actions open a document if not done already,
otherwise they show the opened document



Matěj Laitl committed changes in [amarok] /core-impl/meta/stream:

MetaStream: big clean-up, implement play statistics methods

* remove many unused and useless methods such as setTitle() and
* additionally take genre, comment, track number from Engine
Controller's signal
* implement rating, score, first & last play and play count. These are
rather debugging tool for EngineController, but they also give you
nice info on how many songs have played in the stream
* no need to reimplement observer pattern, use MetaBase implementation
* implement length, EngineController will emit length info soon

Diffs: 1, 2, 3 Revision 09bea01...


Networking Tools

Ilia Kats committed changes in [networkmanagement/nm09] vpnplugins/vpnc/vpnc.cpp:

fix VPNC group password decryption
The KProcess is not needed here, an instance of it is already created
in line 145. In fact, by setting the ciscoDecrypt to a new KProcess here,
the signals/slots no longer work, so the group password is not added
to the data map.



Michael Palimaka committed changes in [marble] /:

Make automagic dependencies controllable.

Instead of building plugins unconditionally if the required dependency
is found, make it possible to choose at configure time.

The macro macro_optional_find_package is bundled to support Qt-only builds,
but is conditionally defined in that circumstance.

REVIEW: 105598

Rafal Kulaga committed changes in [kstars] /:

Deleting broken AAVSO feature.

This feature had been broken for quite some time, so we've decided to
remove it. Due to the big changes at AAVSO site, it might be quite hard
to get it running in the future. Fortunately, we have one person who is
working on it right now.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision c8dd5af...

KDE Base

Vishesh Handa committed changes in [nepomuk-core/testLibrary-resourceRefacto] /resource:

Ractor ResourceData and ResourceManager

Improve the concepts of kickoff lists and make the code a lot easier to
understand. Most of the "magic" of the kickoff lists has been removed to
make it more explicit, and easier to understand.

Instead of having one kickOff list for everything. We now have 3 lists -
* One for initialized data. Maps uri -> ResourceData*
* One for nao:identifiers. Maps nao:identifier -> ResourceData*
* One for nie:urls. Maps nie:urls -> ResourceData*

When constructing a ResourceData, the ResourceManager checks the kind
QUrl it has been given - a nepomukuri, a nie:url or nao:identifier.
Based on the results it passes the arguemnts to the ResourceData

This change was only possible cause with the DMS, we have made it clear
that all resource uri's will be of the form 'nepomuk:/'. This makes the
logic a lot simpler.

Diffs: 1, 2, 3, 4 Revision eb45cf4...
Erlend Hamberg committed changes in [kate] /:

Use Singleton pattern for commands

Add a static self() method to KateCommands::CoreCommands,
KateCommands::ViCommands, KateCommands::AppCommands,
KateCommands::Character, KateCommands::Date and KateAppCommands.
This allows for easier code reuse among commands. The Singleton
pattern is justified as follows:

1. The Command classes have no state, and the only reason they
are instantiated at all is so they can be passed to the command
system. Therefore, they only need to be instantiated once.
2. Other parts of Kate already provide static access: e.g., the
KateDocManager, KatePluginManager and KateGlobal classes all
have a self() method. So there is some precedent for making
common components easier to access.
3. While the Singleton pattern can turn into an anti-pattern if
different parts of the code modify the object as they would a
global variable, the Command objects are stateless and immutable.
In this regard, they are similar to a constant defined in a
much-included header file.

The Singleton pattern guarantees that only one instance of the class
is ever created, and provides access to this instance with the static
self() method.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision c79537a...


Allen Winter committed changes in [kdepim] korganizer/koprefsdialog.cpp:

remove checkboxes for:
* month view uses full window
* todo view uses full window
* todo view displays flat list

no longer needed since thes options are dynamic on the views now.

Volker Krause committed changes in [akonadi] /:

Make referential action explicit.

So far we relied on the various backends adding those, and we had no way
of defining what the actual actions should be (DELETE doesn't make sense

This doesn't yet fix the inconsistencies in the n:m tables nor does it
correct previously missing/wrong referential actions, that's the next

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 83e5d35...