Revision e1d2ea6...

Go back to digest for 29th July 2012

Bug Fixes in Multimedia

Matěj Laitl committed changes in [amarok] /:

EngineController: don't do serious work in slotAboutToFinish()

...because slotAboutToFinish() may be called twice (or not at all) per
track by some Phonon backends (hi, vlc) - increase play count rather in
slotNewTrackPlaying() or in slotFinished(). This also needs to change
how m_currentTrack is handled, because slotNewTrackPlaying() needs to
have the old one in m_currentTrack.

Also, PlaylistActions::requestNextTrack() is changed to be a read-only
method that shouldn't change playlist state especially when there is no
next track. PlaylistActions::reflectPlaybackFinished() is introduced to
do the thing and is called from EngineController::slotFinished(), which
is a much better place for it than slotAboutToFinish().

Reporters of CCed bugs, please re-test your bug with this commit
applied, it is possible it has been resolved by this patch.


File Changes

Modified 4 files
  •   ChangeLog
  •   src/EngineController.cpp
  •   src/playlist/PlaylistActions.cpp
  •   src/playlist/PlaylistActions.h
4 files changed in total