Revision e2af7a5...

Go back to digest for 9th September 2012

Other in KDE Base

Martin Gräßlin committed changes in [kde-workspace/KDE/4.9] /effects/translucency:

Remove animations from Translucency effect

The effect should have had two animations:
* on move resize
* on active/inactive change

But the timeline was adjusted in the prePaintWindow call and the timeline
is effect global and not per window. Which means that for each window the
same time is added. So instead of adding time t each frame t*n with n
being the number of windows got added. So in most cases the animation
ended in the first or second frame which means its not visible.

Through git blame I was able to track down that this incorrect behavior
was introduced in 2008. An animation broken for more than four years
without anybody noticing is probably not required. Because of that it's
dropped from the effect. As this includes quite some code and performance
improvements it goes into the release branch.

A better solution could be implemented, but that should be for 4.10.


FIXED-IN: 4.9.2
REVIEW: 106335

File Changes

Modified 4 files
  • /effects/translucency
  •   kwin/translucency.cpp
  •   kwin/translucency.h
  •   kwin/translucency_config.cpp
  •   kwin/translucency_config.ui
4 files changed in total