Revision d84b318...

Go back to digest for 23rd September 2012

Optimization in Multimedia

Matěj Laitl committed changes in [amarok] /:

Adapt StatisticsProvider & co. to Meta::Statistics, rename

...and use directly in Track implementations, which saves some code.
Also move all to core-impl/suppor - it is just an implementation
detail.

Also modify PersistentStatisticsStore (legacy StatisticsProvider) to
call notifyObservers() as appropriate, which needs some friend
declarations in Meta.h. Use new Observer functionality to track
linked tracks without holding a reference to them. (to avoid circular
reference counting)

File Changes

Added 1 files
  • src/core-impl/support/PersistentStatisticsStore.h
Deleted 1 files
  • src/core/statistics/StatisticsProvider.h
Modified 19 files
  •   ChangeLog
  •   src/CMakeLists.txt
  •   src/core/CMakeLists.txt
  •   src/services/ServiceMetaBase.cpp
  •   src/services/ServiceMetaBase.h
  •   src/core/meta/Meta.h
  •   src/services/magnatune/MagnatuneMeta.cpp
  •   src/core-impl/collections/playdarcollection/PlaydarMeta.cpp
  •   src/core-impl/collections/playdarcollection/PlaydarMeta.h
  •   src/core-impl/meta/file/File.cpp
  •   src/core-impl/meta/file/File.h
  •   src/core-impl/meta/file/File_p.h
  •   src/core-impl/meta/stream/Stream.cpp
  •   src/core-impl/meta/stream/Stream.h
  •   src/services/lastfm/meta/LastFmMeta.cpp
  •   src/services/lastfm/meta/LastFmMeta.h
  •   src/services/lastfm/meta/LastFmMeta_p.h
  •   tests/core-impl/meta/file/TestMetaFileTrack.cpp
  •   tests/core-impl/meta/file/TestMetaFileTrack.h
21 files changed in total