Revision 4dc8ea3...

Go back to digest for 30th September 2012

Bug Fixes in KDE Base

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.9] /src:

Find out the main window by calling the parent widget's window() member

KFileItemModel calls the dir lister's setMainWindow() method to make
sure that the dir lister caches authentication data. However, the method
used to determine the main window (qApp->activeWindow()) is not
guaranteed to yield the DolphinMainWindow or the KonqMainWindow. In
particular, if "Split View" is enabled in Dolphin's settings dialog, the
active window is the dialog, and when it is closed, any later access to
the stored pointer leads to a crash.

A better method is to verify that the model's parent is a QWidget and
then use this widget's window(). I had to make a small modification in
DolphinMainWindow to make sure that it also works correctly when the
view is split (the new view container had been created with a 0 parent

I tested it in Dolphin and Konqueror and verified that the "main window"
passed to the dir lister is really the application's main window.

FIXED-IN: 4.9.3

File Changes

Modified 2 files
  • /src
  •   dolphin/dolphinmainwindow.cpp
  •   dolphin/kitemviews/kfileitemmodel.cpp
2 files changed in total