Revision 57e5bf4...

Go back to digest for 2nd December 2012

Bug Fixes in Multimedia

Matěj Laitl committed changes in [amarok] /:

PlaylistActions: fix sloppy "stop playing after" API and friends

...plus clean-up some EngineController <-> PlaylistActions interaction
and remove some hackiness like frequent calls to ::repaingPlaylist()

First, I wanted to merge the https://git.reviewboard.kde.org/r/107457/
- but the patch just opened my eyes to a greater flaw in the design of
"stop playing after"... So thanks, V. A. Amarnath - you triggered me
studying the code.


FIXED-IN: 2.7
REVIEW: 107457

Bug 253822: stop after current track works only once but remains marked for stop
 
777 days

File Changes

Modified 10 files
  •   ChangeLog
  •   src/ActionClasses.cpp
  •   src/EngineController.cpp
  •   src/playlist/PlaylistActions.cpp
  •   src/playlist/PlaylistActions.h
  •   src/scriptengine/AmarokPlaylistScript.cpp
  •   src/dbus/mpris1/PlayerHandler.cpp
  •   src/dbus/mpris2/MediaPlayer2AmarokExtensions.cpp
  •   src/playlist/view/PlaylistViewCommon.cpp
  •   src/playlist/view/listview/PrettyListView.cpp
10 files changed in total