Revision cbb7f57...

Go back to digest for 13th January 2013

Optimization in KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

Improved resolving whether a window is on local machine

Most windows use the hostname in WM_CLIENT_MACHINE, but there are windows
using the FQDN (for example libreoffice). So instead of "foo" it is
"" or similar. The logic so far has been unable to properly
determine whether windows with FQDN are on the local system.

In order to solve this problem the handling is split out into an own
class which stores the information of hostname and whether it is a local
machine. This is to not query multiple times. To determine whether the
Client is on the local system getaddrinfo is used for the own hostname
and the FQDN provided in WM_CLIENT_MACHINE. If one of the queried
names matches, we know that it is on the local machine. The old logic to
compare the hostname is still used and getaddrinfo is only a fallback in
case hostname does not match.

The problem with getaddrinfo is, that it accesses the network and by that
could block. To circumvent this problem the calls are moved into threads
by using QtConcurrent::run.

Obviously this brings disadvantages. When trying to resolve whether a
Client is on the local machine and a FQDN is used, the information is
initially wrong. The new ClientMachine class emits a signal when the
information that the system is local becomes available, but for some
things this is just too late:
* window rules are already gathered
* Session Management has already taken place

In both cases this is an acceptable loss. For window rules it just needs
a proper matching of the machine in case of localhost (remote hosts are
not affected). And the case of session management is very academic as it
is unlikely that a restoring session contains remote windows.

FIXED-IN: 4.11
REVIEW: 108235

File Changes

Added 3 files
  •   kwin/client_machine.cpp
  •   kwin/client_machine.h
  •   kwin/tests/test_client_machine.cpp
Modified 13 files
  •   kwin/client.cpp
  •   kwin/client.h
  •   kwin/CMakeLists.txt
  •   kwin/rules.cpp
  •   kwin/rules.h
  •   kwin/toplevel.cpp
  •   kwin/toplevel.h
  •   kwin/utils.cpp
  •   kwin/utils.h
  •   kwin/tests/CMakeLists.txt
  •   kwin/kcmkwin/kwinrules/CMakeLists.txt
  •   kwin/kcmkwin/kwinrules/kwinsrc.cpp
  •   kwin/kcmkwin/kwinrules/main.cpp
16 files changed in total