Revision 0be3da5...

Go back to digest for 20th January 2013

Features in KDE Base

Martin Gräßlin committed changes in [kde-workspace/KDE/4.10] /:

Use translucent/dialogs/background elements where possible

In effects it's obvious that compositing is enabled, so specifying the
translucent element is no problem.

In tabbox a context property "compositing" is injected which decides
whether "translucent" or "opaque" elements should be used. Here the
translucent elements are only used if the Blur effect is available - for
this a new Effect::Feature Blur is introduced and in addition it is
tested whether the theme provides the translucent element.

Also the masking is adjusted to ensure that only the shadow is not

Reason for this change is that Plasma theme seems not always to pick up
whether compositing is used when used from inside KWin. It does not cover
the Desktop Change OSD which uses PlasmaCore.Dialog and there we cannot
(yet) inject that we use compositing.

Overall I'm quite unhappy with this patch and I do hope we can fix it in
the proper place in the lifetime of 4.10 and revert this patch.

REVIEW: 108438

File Changes

Modified 15 files
  •   kwin/libkwineffects/kwineffects.h
  •   kwin/tabbox/declarative.cpp
  •   kwin/effects/blur/blur.h
  •   kwin/effects/desktopgrid/desktopgrid.cpp
  •   kwin/effects/presentwindows/presentwindows.cpp
  •   kwin/tabbox/qml/CMakeLists.txt
  •   kwin/tabbox/qml/desktop.qml
  •   kwin/tabbox/qml/ShadowedSvgItem.qml
  •   kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml
  •   kwin/tabbox/qml/clients/compact/contents/ui/main.qml
  •   kwin/tabbox/qml/clients/informative/contents/ui/main.qml
  •   kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml
  •   kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml
  •   kwin/tabbox/qml/clients/text/contents/ui/main.qml
  •   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml
15 files changed in total