Revision 21d4b1f...

Go back to digest for 2nd June 2013

Features in Office

Elvis Stansvik committed changes in [calligra] plugins/textshape/dialogs/DockerStylesComboModel.cpp:

Ignore default styles in styleApplied.

DockerStylesComboModel::styleApplied may be called with the default
paragraph style as argument.

The function assumes that the source model can provide an index for the
supplied style (see the calls to indexForCharacterStyle). But the source
model explicitly avoids adding items for the default styles, so these
calls will return an invalid index, which results in a -1 being added as
a row to m_usedStyles. In the next call to styleApplied, this will
result in an invalid internalId being used to try to get the
corresponding style from the style manager. The invalid style pointer is
then used, resulting in the crash described in the bug.

This fix turns DockerStylesComboModel::styleApplied into a no-op if the
supplied style is either the default character style or the default
paragraph styles, since there will never be any items for these in the
source model.

REVIEW: 110506

File Changes

Modified 1 files
  • plugins/textshape/dialogs/DockerStylesComboModel.cpp
1 files changed in total