Revision 2725226...

Go back to digest for 2nd June 2013

Bug Fixes in KDE Base

Vishesh Handa committed changes in [kdelibs/KDE/4.10] /ui:

KEditTagsDialog: Avoid using QDialog::exec

QDialog::exec runs an event loop at waits for the dialog to be closed.
Running another event loop is generally not recommended cause it can
result in *other* events being process which one might not want.

In this particular case the ResourceLoader, which runs in another
thread, would emit the finished signal would result in the
FileMetadataWidget deleting all its previous content, which would
delete the TagWidget and its children aka the KEditTagsDialog => CRASH

Instead we now set the windowModality and use QDialog::open, which
returns immediately and then connect to the finished signal.

Backported from nepomuk-widgets 2080bc1d4fe7c249c28930b18f03741c53025b13

File Changes

Modified 3 files
  • /ui
  •   nepomuk/tagwidget.cpp
  •   nepomuk/tagwidget.h
  •   nepomuk/tagwidget_p.h
3 files changed in total