Revision 4de9a23...

Go back to digest for 16th June 2013

Bug Fixes in KDE Base

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.10] /src/kitemviews:

Do not rename files unexpectedly when changing the URL

If the role editor loses focus, it considers the current renaming
operation finished, and tells DolphinView to rename the file. This is a
problem when changing the directory, because the URL change happens
before DolphinView receives the signal, which results in a file in the
new directory being renamed unexpectedly.

The solution is to establish the connection to the
slotRoleEditingFinished signal only when the "rename inline" editor is
opened, and disconnect it when renaming is finished or canceled or the
URL changes.

FIXED-IN: 4.10.5
REVIEW: 110908

File Changes

Modified 4 files
  • /src/kitemviews
  •   dolphin/kstandarditemlistwidget.cpp
  •   dolphin/kstandarditemlistwidget.h
  •   dolphin/private/kitemlistroleeditor.cpp
  •   dolphin/private/kitemlistroleeditor.h
4 files changed in total