Revision ecf6768...

Go back to digest for 23rd June 2013

Bug Fixes in KDE-PIM

Lindsay Mathieson committed changes in [kdepim-runtime] /nepomukfeeder:

Fix bug in running job count

Fixes problem where the count of running jobs becomes less than zero
(-1), causing an assert in itemqueue.cpp at line 113 to trigger. This
was happening because ItemQueue::clear() was setting the running job
count to zero when there was unfinished jobs, when the jobs actually did
finish the running job count was decremented to below zero.
The batch fixes this by keeping a QList<KJob *> of running jobs, adding
them when created and removing when the job finishes (via the result
signal). When ItemQueue::clear() is called any outstanding jobs are
silently killed and the list cleared.

REVIEW: 111089

File Changes

Modified 2 files
  • /nepomukfeeder
  •   agents/itemqueue.cpp
  •   agents/itemqueue.h
2 files changed in total