Revision acf7cfa...
Go back to digest for 30th June 2013Bug Fixes in Multimedia
Matěj Laitl committed changes in [amarok] /:
ScanManagers, ScanResultProcessors: don't call non-thread-safe code from a thread
Excessive usage of direct Qt connections lead to a large amount of code
in various ScanResultProcessors being called from a non-main thread, but
the result processors didn't expected it, weren't thread-safe, which
lead to data races.
This fixes one confirmed crash and may fix more seemingly random Local
Collection updating behaviour.
FIXED-IN: 2.8
File Changes
Modified 13 files
- ChangeLog
- src/scanner/AbstractScanResultProcessor.cpp
- src/scanner/AbstractScanResultProcessor.h
- src/scanner/GenericScanManager.cpp
- src/scanner/GenericScanManager.h
- src/scanner/GenericScannerJob.cpp
- src/scanner/GenericScannerJob.h
- tests/scanner/TestGenericScanManager.cpp
- tests/scanner/TestGenericScanManager.h
- src/core-impl/collections/umscollection/UmsCollection.cpp
- src/core-impl/collections/umscollection/UmsCollection.h
- src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
- src/core-impl/collections/db/sql/SqlScanResultProcessor.h
13 files changed in total