Revision 36e28db...

Go back to digest for 7th July 2013

Bug Fixes in KDE Base

Frank Reininghaus committed changes in [kde-baseapps] /src/kitemviews:

Make sure that KItemListSizeHintResolver is always consistent

This was the root cause of bug 317827. The assert tried to make sure
that we never access KItemListSizeHintResolver from
KItemListViewLayouter inside the loop over the item ranges. This would
be dangerous because it might be in an inconsistent state - the removed
item ranges were removed step by step, so accessing the item size hints
before the operation was finished could lead to wrong results.

The solution is to insert/remove all item ranges immediately. A nice
side effect is that there are no sources of O(N^2) complexity in
KItemListSizeHintResolver any more if many item ranges are
inserted/removed.


FIXED-IN: 4.11.0
REVIEW: 111382

File Changes

Modified 3 files
  • /src/kitemviews
  •   dolphin/kitemlistview.cpp
  •   dolphin/private/kitemlistsizehintresolver.cpp
  •   dolphin/private/kitemlistsizehintresolver.h
3 files changed in total