Issue 296

cpp_header.h: Conditionally add license header

If no license text is given, don't add any comment at all.
I'm not adding "None" or similar to the combo box, because I think that
just clutters the box with another redundant item.

If you don't want a license, select "Other" and leave the text edit empty.

Cleanup and fixup ProjectUtils to not leak and not trigger crashes.

The most important part of this patch is the change to use a dynamic
allocated QMenu which is then _not_ run synchronously via exec() but
rather allocate it on the heap and use QObject/QWidget parentship
to handle the deallocation eventually.

This also fixes the memory leak of the populator objects.

And it fixes a crash since QMenu::exec applies a nested event loop
which apparently does not work nicely together with KXMLGUI. One
could also fix that by delaying (i.e. Qt::QueuedConnection) the
handling of _all_ QMenu actions - but that won't work of course.

So yeah, I think this is the best option to handle this crash.

Maybe one should even investigate whether we can/should deprecate
the usage of QMenu::exec in our codebase...

FramestackWidget: Make keyboard navigation useful


REVIEW: 110960

Fixes hang in in-painting tool and segfault caused by leaking threads each iteration of cimg tool use.



FIXED-IN: 3.3.0

use configured xrender filter

that's why it's configured

REVIEW: 111428

FIXED-IN: 4.11

Don't keep a stale model index around.

ignore unredirection configuration on intel

the only thing it does on these systems is cause users
trouble because usually when there's a client where
unredirection makes sense, that uses OpenGL - and then
things break in the driver.


REVIEW: 111476

Observe the `view created' event and subscribe to a document close and name/URL change, so the plugin's menu will be updated.
Also this would fix a bug w/ menu update after closing a document in a usual way (via Ctrl+W).

Avoid Double Delete of Cookie Jar

The old cookie jar is deleted internally in setCookieJar if appropiate


FIXED-IN: 4.11 RC1

Office Extractor: Do not store empty resources

This used to make encryped document files give an error during indexing,
because a SimpleResource with just a uri would be pushed, and that is
invalid.

Load unknown icons for items just before showing items in the view

Rather than loading many icons (without full mime type determination)
in advance, we make sure that an item has an icon just before it is
shown in the view. This makes sure that no "unknown" icons are shown
unnecessarily, and saves some resources.

REVIEW: 111396

Minimap: Top align the minimap in stead of center-align


FIXED-IN: KDE 4.12
GUI:

Do not show multiple dialogs when KIO sends error messsages or confirmation requests.
This fix resolves one of the oldest known issues in KIO.



REVIEW: 111335
FIXED-IN: 4.11

rather omit lanczos than capping windows

capping shadows is seen as bug (and is ugly and
because of the non lanczos transition causes visual
flicker) so if the window+shadows extends the buffer,
lanczos is simply not possible.


FIXED-IN: 4.11
REVIEW: 111425

Fix modulation in Invert effect

Thanks to Kevin for spotting and providing a fix.


FIXED-IN: 4.11

Looks like there was a bit of a misunderstanding about how either Kate Ranges, or just selections, actually work: the end of the selectionRange appears to be one space ahead of where I expected. Fix earlier test, and add test for bug 309191, which was the motivating example for this.

Maildir resource: Fix handling of whitespace-only header lines

Previously, affected mails' headers would be parsed only in part,
resulting in (for example) seemingly empty subject lines.

BUG:
FIXED-IN: 4.11
REVIEW: 111307

Upgrade the Tp::Connection to upgrade FeatureRoster inside GlobalContactManager

GlobalContactManager is useless without FeatureRoster so it makes sense
that if one instantiates this class, we upgrade the connection.

This will allow apps that only occasionally need a full contact list
such as contact-applet and text-ui to not rely on FeatureRoster and thus
will can a connection object without loading details on every contact ever.

This is an important step towards a singleton AccountManager, in addition
text-ui will load substantially faster.

REVIEW: 111440

rfc1951: Fix deleting buffer in destructor

Array _buffer is allocated by new char[chunkSize], so must be freed by delete[] operator instead delete.

REVIEW: 111490

in the ctor, be careful when setting the toplevelwidget


FIXED-IN: 4.12
REVIEW: 111412

korgac: Read "ShowReminderDaemon" setting from correct config group

Before, the daemon would be shown in the tray no matter what the user
had selected in the configuration dialog.


FIXED-IN: 4.11

Fix data loss bug.

MemoryCalendar::deleteAllEvents() clears the in-memory containers,
but it's virtual so it actually does whatever the sub-classes mean
by "delete", which in case of akonadi calendars, is a ItemDeleteJob.

Fixed by calling the non virtual method.

Lots of API cleanup to do in KCalCore/Calendar.h for KDE5.

Fix high CPU usage caused by EntityCache


Reviewed-By: Sergio Martins

Fix Bug 322303 - Kmailcvt fails to import Outlook Express mailbox with error "failed to read temporary file"

FIXED-IN: 4.11

Don't crash after receiving a dataChanged() about unknown item.

The item isn't in the map because it was ignored, for example
because of not having a DTSTART.

Fix Bug 316249 - kmail does not remember sieve user & password

FIXED-IN: 4.12

Set the nco:nickname() on nco:PersonContact too when alias updates

Reviewed-by: David Edmundson

FIXED-IN: 0.7.0

replace the "override user formatting" options with a single one. Make it actually work.

The only times it does not work is when The LaTeX plugin is enabled AND actually
doing something, or on history messages.

This situation is better than the previous, in which it never worked

bug #277508

my first commit in years! :O

Always specify ColorGroup when fetching color from QPalette.

This commit fixes a huge number of color inconsistencies that existed
between the inital colors of widgets at Amarok startup, and the colors
that resulted from switching to the same theme at runtime.

It is *crucially important* when using QPalette::color() to always
specify the ColorGroup too, not just the ColorRole. Otherwise whatever
is the currently active group will be used.

Review ssl widget generation code.

This also seems to fix some way problem about multiple widget creations

What about you, guys?

Check validity of a contact based on RowTypeRole not whether parent is valid

This makes us able to start chats whilst filtered

Add a guard that the current tab exists on a window activated event

This fixes a crash


Fixed-in: 0.6.3
Reviewed-by: Sven Brauch

Fetching list of twitter Lists that the requested user owns, fixed!
The trick here was that You should pass the base URL to TwitterApiMicroBlog::authorizationHeader() funtion to make OAuth signature based on that! (without parameters!)

Avoid clipping in group chat tab in config

Fixed GCancellable handling in PolkitQtListener

There was a race condition happening on two simultanneous requests to the agent, causing it to crash.

fix for bug #320803 and building on OSX

Fix Animations.

This commit includes two fixes:
1. Writing "property: 'x'" in a NumberAnimation caused a syntax error because it
was handled as a property definition.
2. Animations didn't get their properties applied properly, because this had the
wrong value in the animations init().

SPHINX: support for continuous recognition

Added the Github plugin in the providers directory.

REVIEW: 111477

Multiple breakpoints.

For multiple breakpoints show not all breakpoints with location
like: "Your GDB is too old" even though gdb is the latest one, but the
parent one with normal location. Add
unit test for it.

Make it possible to export 3D plots to PDF

Remove ASCII input restrictions for XMP byline and identifiers fields.


FIXED-IN: 3.3.0

import/export VPN plugins config

WIP, no GUI yet

Adding more default filename parsing/cleaning rules specifically to help the anime usecase.
Minor modifications and additions to fileanalyzer unit tests to support these.

REVIEW: 111245

[Jira Syntax Highlighting] Finished implementing support for text effect syntax (bold, quotes, color, and more).

Implement indented paste (]p and [p).

This is a pretty ugly one :/ Essentially, we want "/" and "?" to be usable as motions so that we can do e.g. d3/bar<enter> to delete up to the third occurrence of bar. We also want them to be usable in Visual Mode.

Firstly: get rid of the "/" and "?" commands - they're not really commands, plus if they are they make us exit Visual Mode whenever we press them. Make them motions instead.

Problem: we don't have the m_commandRange for the motion until the user has interacted with the search bar and dismissed it. So we need to special case "/" and "?" by manually invoking the search bar when they are pressed, then exiting the key handler. The user will then choose the search term and press Enter or whatever, so we can now deduce the m_commandRange and execute the command with the search motion. We trigger this execution by (ugh) having the search bar send a synthetic keypress back round the Vi keypress handler that either aborts the current command (if we aborted the search bar) or completes the motion, allowing us to execute the command. This is very ugly (especially as this synthetic keypress must not be logged for replay via "."!) but it's tough to think of an alternative.

This commit also makes searches countable.

Some more of the KateViVisualMode::goToPos code had to be removed to get this working when using "?" with no wraparound in Visual Mode, but I think this part of the code (which resets the whole selection to m_commandRange under certain conditions e.g. pressing "iB" when we have already moved around in Visual Mode) has been broken for a while :/ I'm going to try a different approach to fixing this.

Add option (Automatic - only addresses) to IPv4/IPv6 setting

Use enum for better manipulation with indexes

Implement keyboard navigation for battery monitor

When opening the popup the brightness slider has focus so you can immediately adjust brightness
using left/right arrow keys. Tab moves you to the keyboard brightness slider, then to the PM
checkbox which you can toggle using Return/Space, then to the battery list through which you
navigate using arrow up/down and expand/collapse using Return/Space/Arrow left/right.

FIXED-IN: 4.10.95

Big chunk of work on incorporating ":" (i.e. running commands) in KateViEmulatedCommandBar. Includes basic running of commands (of course); display of output of commands; and completion of commands, along with the other advantages of KateViEmulatedCommandBar. Also includes a bunch of refactorings.

In practice, I'm finding this a bit clunky, usability-wise: for example, one requires *two* presses of Enter to run the command: the first clears the completion box, the second actually runs the command. This really needs to be changed to be more like the way Kate currently does things, which I'll do in due course.

Storage: Export the port number in the nepomukserverrc config file

This way clients can lookup the port number and connect to that specific
port. Before this patch one could not run multiple nepomuk sessions in
parallel as they would not always connect to the correct virtuoso
instance.

kwin: Make PaintRedirector work without NPOT texture support

Add new widget for settings time/date

Start to implement generate script sieve from kmail filter

Start to implement settings for enable/disable agents (as sendlateragent/mailnotifier etc.).

For the moment we can do it with dbus interface.

Gui: SettingsDialog: For SMTP and SSMTP methods enable Save Outgoing Mail checkbox

When user click on IMAP SENDMAIL method, Trojita automatically check
Save Outgoing Mail checkbox and disable it. When user again select SMTP
method Trojita should re-enable this checkbox and allow user to uncheck
this checkbox.

REVIEW: 111495

Changes in python backend behaviour to his works like python interactive mode and no python script mode. Tab complet using xml file implemented.

Better and new advices based on limits of accounts

feature: Max and min limits on accounts
feature: Better advices based on limits of accounts

New icons for palette docker

Add 2 icons for the new palette docker. Icons sources by deevad.

REVIEW:111406
FIXED-IN:1.4
New line support for submitting(Shift+Enter) and showing tweets [Patch by Ahmed Ibrahim]

%time Variable to get the current UTC time in the away message

To make this option visible I've changed the tool tip (I think the first thing a user would do if he wants no away message is to remove the message text [if there is one, which isn't by default], so this double information can be replaced).

Adding an extra widget for drag n drop like in now playing would be too much for this I think. It would blow up the UI if I add this under every lineedit (as more stuff is visible on the first sight for the user as more complicated it looks) and it would be confusing if I add it only once in a central place, so I decided to just inform the user through a tool tip (it's also not a important feature, so it's ok if it's a little bit hidden).


FIXED-IN: 0.7.0
REVIEW: 110334

Ignore context ChatWindow's notification setting in NotificationHandler::nick(On|Off)line.

Watched Nicks coming online or offline is connection-global, not
specific to any particular ChatWindow, so checking whether the one
passed as context (in practice the call sites use the StatusPanel,
and the notification handler only cares to get the corresponding
Server) has notifications enabled or not makes no sense here.

As "parking" on a status tab before switching away from the app is
a common behavior, as is switching off its notifications to avoid
certain highlights during connect, this is the likely cause of in-
termittent reports of this KNotify event not working reliably.

Add a simple ssh sync handler


REVIEWED-BY: adjam

Many thanks, Radu! And sorry for the late merge ;)

finish import/export VPN connection

trello feature: https://trello.com/c/gahk2GML

[ #25405 ] Implement a new transfer dialog (view only)

Implement showing asset info for incoming assets.

ResourceLoader: Load all the associated properties as well

When using the FileMetadataWidget, the MetadatFilter class is used which
internally uses Types::Property. This Property class is unfortunately
synchronous and can block for a bit. Therefore we load all the
properties in this separate thread so that they are always there in the
cache.

This never used to be a problem earlier because connecting to the
Nepomuk Server used to be quite fast. Since now we connect directly to
virtuoso, it can take some time and block.

Major re-working of how [s and ]s are made (or not made) literals when converting from vim to Qt regex's, with motivating examples.

DesktopQueryParser: Map commonly used keywords to their properties

Otherwise hasTag maps to both pimo:hasTag and nao:hasTag
rating maps to 3 different ratings
mimetype maps to 2 different properties

For these common keywords the user doesn't expect the other properties
to be searched. Additionally, we're just slowing down the queries by
searching through those extra properties.

Don't use 1.5 GB when importing a big maildir.

The code was creating 70k ItemCreateJobs first, and then starting them all.
That makes mem usage reach a peak of 1.5GB here.
It does have code to do one event loop iteration every 20 e-mails,
but that only makes it fire one ItemCreateJob, so they pile up anyway.

Solution is to throttle ItemCreationJob creation.

CPU-wise, this solution and the old one are equivalent,
they are both equally fast.

REVIEW: 111469

Add file monitoring to iCalDir and vCardDir resources and move common code to shrade base class

Similarily to iCal and vCard resources, the iCalDir and vCardDir resources
are essentially identical. This patch moves all the code to a template-based
DirResource class, making VCardDirResource and ICalDirResource specializations
of the DirResource class, implementing only loading and saving of payload
from/to file. QObject-related stuff is implemented in DirResourceBase class.

The shared code now also supports watching the directory (via KDirWatch)
for changes and will automatically add, update or remove entries from
Akonadi when a file is added, changed or removed in the resource's data
directory.

Rearrange image-from-clipboard page

So it doesn't take so much space.

Optimize default ResourcesModel roles retrieval

Reduce calls to indexOfProperty by one
Tells the compiler our branching priorities

Switch to an external LibRaw

Instead of using an embedded copy of LibRaw, look for an external LibRaw
as mandatory dependency with a new CMake module and using its variables.

Considering some LibRaw versions seem to be underlinked and not linking
to OpenMP, link it manually in libkdcraw to overcome such lack.

Switch back to the MAKE_KDCRAW_LIB define (i.e. the default set by
KDE4_ADD_LIBRARY) as the one used to check whether it is being built,
as otherwise LIBRAW_BUILDLIB would conflict with LibRaw.

See review #110962

Remove FeatureRoster from ConnectionFeatures

Now that GlobalContactManager will upgrade the connection object
when we request a full contact roster (in the "invite contact" dialog)
we don't need to fetch the whole roster on load.
(see http://commits.kde.org/telepathy-common-internals/9cc7ea57c830d345bab5377208058fb47b428b69)

This should result in faster load times.