Revision 36cce28...
Go back to digest for 21st July 2013Bug Fixes in Office
Boudewijn Rempt committed changes in [calligra/krita-opengl2-rempt] /:
Wrap KoShapeBackground in QPointer
This patch wraps KoShapeBackground in a QPointer instead of doing manual
refcounting. Bug 321714 shows, imo, that the manual refcounting is
fragile and sometimes breaks. I don't remember why we weren't supposed
to use QPointer (other than that it gets a little ugly with subclassing),
but it seems a good fit here.
There are other classes that do manual refcounting, and I think those
should be converted, too -- but in another patch.
File Changes
Modified 45 files
- karbon/ui/KarbonView.cpp
- libs/flake/KoConnectionShape.cpp
- libs/flake/KoOdfWorkaround.cpp
- libs/flake/KoOdfWorkaround.h
- libs/flake/KoShape.cpp
- libs/flake/KoShape.h
- libs/flake/KoShape_p.h
- libs/flake/KoShapeBackground.cpp
- libs/flake/KoShapeBackground.h
- libs/flake/KoShapeBackground_p.h
- libs/kopageapp/KoPAPageBase.cpp
- libs/widgets/KoFillConfigWidget.cpp
- libs/widgets/KoFillConfigWidget.h
- libs/widgets/KoResourcePopupAction.cpp
- libs/widgets/KoResourcePopupAction.h
- plugins/chartshape/ChartShape.cpp
- plugins/textshape/TextShape.cpp
- words/part/KWPageStyle.cpp
- words/part/KWPageStyle.h
- words/part/KWPageStyle_p.h
- filters/karbon/wmf/WmfExport.cpp
- karbon/plugins/tools/KarbonGradientEditStrategy.cpp
- karbon/plugins/tools/KarbonGradientTool.cpp
- karbon/plugins/tools/KarbonPatternEditStrategy.cpp
- karbon/plugins/tools/KarbonPatternEditStrategy.h
- karbon/plugins/tools/KarbonPatternTool.cpp
- karbon/ui/widgets/KarbonPaletteBarWidget.cpp
- karbon/ui/widgets/KarbonSmallStylePreview.cpp
- krita/ui/flake/kis_shape_selection_model.cpp
- krita/ui/tool/kis_tool_shape.cc
- libs/flake/commands/KoShapeBackgroundCommand.cpp
- libs/flake/commands/KoShapeBackgroundCommand.h
- libs/flake/svg/SvgParser.cpp
- libs/flake/svg/SvgStyleWriter.cpp
- libs/flake/svg/SvgStyleWriter.h
- libs/flake/tests/TestShapeBackgroundCommand.cpp
- plugins/dockers/styledocker/StrokeFillWidget.cpp
- plugins/dockers/styledocker/StrokeFillWidget.h
- plugins/dockers/styledocker/StyleDocker.cpp
- plugins/dockers/styledocker/StyleDocker.h
- plugins/dockers/styledocker/StylePreview.cpp
- plugins/dockers/styledocker/StylePreview.h
- plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp
- words/part/frames/KWFrameLayout.cpp
- libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp
45 files changed in total