Use const_iterators for our Effect iterators

We never modify the list, so we don't need the mutuable iterator. This
ensures that the data doesn't get detached.