Revision a741a27...

Go back to digest for 18th August 2013

Bug Fixes in KDE-PIM

Dan Vratil committed changes in [akonadi] /:

Change the notifications filter to match the one from Akonadi::Monitor

The reverse filtering (i.e. getting list of sources that accept
given notification) cannot be mapped 1:1 to the original behavior
of Akonadi::Monitor easily while keeping the code readable and
causes various subtle bugs in filtering out (or not filtering)
certain notifications. Therefor we revert to the original approach
of asking each source whether it accepts given notification.

In the end it is probably faster than the previous approach
because it does only simple comparisions instead of uniting sets.

And except for other things it fixes problem with endless item
fetch loop when resource cannot retrieve all requested payload parts
(emails without a body for instance), an example of the subtle bug
mentioned above.

File Changes

Modified 5 files
  •   server/src/notificationmanager.cpp
  •   server/src/notificationmanager.h
  •   server/src/notificationsource.cpp
  •   server/src/notificationsource.h
  •   server/tests/unittest/notificationmanagertest.cpp
5 files changed in total