Revision c802f3d...

Go back to digest for 13th October 2013

Bug Fixes in KDE Base

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.11] /src:

Include "Space" in the keyboard search string

Before this commit, we only added pressed keys to the search string if
they have no other meaning. This means that files containing a Space in
their name could not be searched because Ctrl+Space toggles the
selection state of the current item, and Space alone selects the
current item.

After this commit, Space is added to the search string if

(a) the key press did not have any other effect, i.e., if Ctrl was not
pressed, and the current item is selected already, and
(b) a keyboard search has been started already (to prevent unexpected
effects when pressing Space accidentally - I think that it's rather
uncommon to have files whose names start with a Space - and to make
the unit test simpler).

I modified the unit test of KItemListController, which did not test
keyboard search yet. This uncovered a small problem in
KItemListController::slotChangeCurrentItem() when NoSelection mode is
used. It's not really relevant for anything that is executed inside
Dolphin, but I still fixed it to make the unit test happy.

FIXED-IN: 4.11.3
REVIEW: 113071

File Changes

Modified 3 files
  • /src
  •   dolphin/kitemviews/kitemlistcontroller.cpp
  •   dolphin/tests/kitemlistcontrollertest.cpp
  •   dolphin/kitemviews/private/kitemlistkeyboardsearchmanager.cpp
3 files changed in total