Revision 866fb73...

Go back to digest for 27th October 2013

Bug Fixes in KDE Base

Harald Sitter committed changes in [kde-runtime/KDE/4.11] /kcm:

Prevent KCM crash after a context goes bad

If AudioSetup cannot connect to the context at construction the entire tab
will simply not be added, so the KCM cannot crash on nullptr access in
that case. However when a context goes bad after initial connection the KCM
did not try to reconnect which pretty much ensures a crash on s_context=0.

Connection logic was refactored into af function and used to attempt a
reconnect. Additionally when failing to connect to the context the widget
is now disabled, so even if the reconnect fails the user can not crash
AudioSetup (also without a context the widget is useless).

FIXED-IN: 4.11.3

File Changes

Modified 2 files
  • /kcm
  •   phonon/audiosetup.cpp
  •   phonon/audiosetup.h
2 files changed in total